Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Feb 2022 14:37:56 +0000
From:   Aaron Tomlin <atomlin@atomlin.com>
To:     Miroslav Benes <mbenes@suse.cz>
Cc:     Aaron Tomlin <atomlin@redhat.com>, mcgrof@kernel.org, cl@linux.com,
        pmladek@suse.com, akpm@linux-foundation.org, jeyu@kernel.org,
        linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
        live-patching@vger.kernel.org, ghalat@redhat.com,
        allen.lkml@gmail.com, void@manifault.com, joe@perches.com
Subject: Re: [RFC PATCH v4 07/13] module: Move extra signature support out of
 core code
Message-ID: <20220209143756.53gw3ve46gaseqny@ava.usersys.com>
References: <20220130213214.1042497-1-atomlin@redhat.com>
 <20220130213214.1042497-8-atomlin@redhat.com>
 <alpine.LSU.2.21.2202091526260.32090@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.21.2202091526260.32090@pobox.suse.cz>
Precedence: bulk

On Wed 2022-02-09 15:28 +0100, Miroslav Benes wrote:
> Please, drop these extern modifiers in front of function declarations. 
> They are unnecessary. It applies to different patches of the set as well.

Agreed - this was suggested previously.
The next iteration should be published soon. Just waiting on 0-day.

> > +#ifdef CONFIG_MODULE_SIG
> > +extern int module_sig_check(struct load_info *info, int flags);
> > +#else /* !CONFIG_MODULE_SIG */
> > +static int module_sig_check(struct load_info *info, int flags)
> > +{
> > +	return 0;
> > +}
> 
> I think it should be 
> static inline int module_sig_check(struct load_info *info, int flags)

Yes, indeed it should. Thanks for the feedback.


Kind regards,

-- 
Aaron Tomlin