Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Feb 2022 13:40:43 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Yun Zhou <yun.zhou@windriver.com>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        ying.xue@windriver.com
Subject: Re: [PATCH] spi: disable chipselect after complete transfer
Message-ID: <YgPEWyEj7lbQJgAn@sirena.org.uk>
References: <20220209100042.22941-1-yun.zhou@windriver.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5jCZZYA68rLFpXRe"
Content-Disposition: inline
In-Reply-To: <20220209100042.22941-1-yun.zhou@windriver.com>
Precedence: bulk


--5jCZZYA68rLFpXRe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 09, 2022 at 06:00:42PM +0800, Yun Zhou wrote:
> If there are 2 slaves or more on a spi bus, e.g. A and B, we processed a
> transfer to A, the CS will be selected for A whose 'last_cs_enable' will
> be recorded to true at the same time. Then we processed a transfer to B,
> the CS will be switched to B. And then if we transmit data to A again, it
> will not enable CS back to A because 'last_cs_enable' is true.
> In addition, if CS is not disabled, Some controllers in automatic
> transmission state will receive unpredictable data, such as Cadence SPI
> controller.

This sounds like you've got an issue with mixing devices with and
without CS_HIGH - that is probably broken but...

>  out:
> -	if (ret != 0 || !keep_cs)
> -		spi_set_cs(msg->spi, false, false);
> +	spi_set_cs(msg->spi, false, false);

...this will obviously break cs_change support, clearly that's not OK.
The last_cs_high should be moved to the device.

--5jCZZYA68rLFpXRe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIDxFsACgkQJNaLcl1U
h9AC5gf/QnfdqF4bxfMlcz/+CEL3cJsquOhbXqelLfIGLo7xhpl5E2fYklnxH7oI
JskQEzXWCEHUndus0bQ4Cpz4NCoP/u2jseFdUcp8pw4dtqEHU4xEAN6lE36rKX/X
gHhnGO17RjkH4ob4dG7wKBbBflSmSTEwVkgHZ4yfj3x58l2GYBnltI8OTZsOP1c7
fnoPeV3otEr7hJ4TuB/u8JuAk2lja359T4zFNk/mcz2tFK/hqdu7Y7Bses89sRn8
Lia7l+LJhlHtDCbwBYEY6JEP8evFE9LPqwP51g38qlzFp4FDyc7vp2nEa7dmSpad
5xAH7YF2ykqoH/VyKtnhl4F0PuxSYA==
=9k4w
-----END PGP SIGNATURE-----

--5jCZZYA68rLFpXRe--