Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <636929f8-0448-8ed9-34d2-ddc442f6b205@quicinc.com>
Date:   Wed, 9 Feb 2022 20:22:48 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] sched/uclamp: New sysctl to tweak boost for uclamp tasks
Content-Language: en-US
To:     Vincent Donnefort <vincent.donnefort@arm.com>
CC:     <mingo@redhat.com>, <peterz@infradead.org>,
        <juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
        <dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
        <joel@joelfernandes.org>, <linux-arm-msm@vger.kernel.org>,
        <quic_lingutla@quicinc.com>, <linux-kernel@vger.kernel.org>
References: <20220209134319.1183-1-quic_ctheegal@quicinc.com>
 <YgPIzXWpWeEpUJbi@FVFF7649Q05P>
From:   Chitti Babu Theegala <quic_ctheegal@quicinc.com>
In-Reply-To: <YgPIzXWpWeEpUJbi@FVFF7649Q05P>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


Sorry, please ignore this patch. It was wrongly uploaded here.
Will pursue this to right tree.

On 2/9/2022 7:29 PM, Vincent Donnefort wrote:
> [...]
> 
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index 634d571e39d77..55019eb9c83c5 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -1269,6 +1269,14 @@ unsigned int sysctl_sched_uclamp_util_max = SCHED_CAPACITY_SCALE;
>>    */
>>   unsigned int sysctl_sched_uclamp_util_min_rt_default = SCHED_CAPACITY_SCALE;
>>   
>> +/* UCLAMP_MIN knob clamps the util_value within uclamp_min & max. By default,
>> + * these uclamped tasks are also boosted to bigger cores which can impact power.
>> + *
>> + * This knob provides an option to turn-off 'boosting to gold cores' and
>> + * just restrict to 'clamping util value' job.
>> + */
>> +unsigned int sysctl_sched_uclamp_util_min_to_boost = 1;
>> +
>>   /* All clamps are required to be less or equal than these values */
>>   static struct uclamp_se uclamp_default[UCLAMP_CNT];
>>   
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 7cd316793f4e3..44adcbfa9eb32 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -6829,7 +6829,7 @@ static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu, int sy
>>   		goto unlock;
>>   
>>   	latency_sensitive = uclamp_latency_sensitive(p);
> 
> I don't think this is the right tree.

Thanks ! I just noticed it :-(

> 
> 
>> -	boosted = uclamp_boosted(p);
>> +	boosted = sysctl_sched_uclamp_util_min_to_boost && uclamp_boosted(p);
>>   	target_cap = boosted ? 0 : ULONG_MAX;
>>   
>>   	for (; pd; pd = pd->next) {
>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>> index 8f196ed2ec065..6463d60fed84e 100644
>> --- a/kernel/sysctl.c
>> +++ b/kernel/sysctl.c
>> @@ -1882,6 +1882,15 @@ static struct ctl_table kern_table[] = {
>>   		.mode		= 0644,
>>   		.proc_handler	= sysctl_sched_uclamp_handler,
>>   	},
>> +	{
>> +		.procname	= "sched_util_clamp_min_to_boost",
>> +		.data		= &sysctl_sched_uclamp_util_min_to_boost,
>> +		.maxlen		= sizeof(unsigned int),
>> +		.mode		= 0644,
>> +		.proc_handler	= proc_dointvec_minmax,
>> +		.extra1		= SYSCTL_ZERO,
>> +		.extra2		= SYSCTL_ONE,
>> +	},
>>   #endif
>>   #ifdef CONFIG_SCHED_AUTOGROUP
>>   	{
>> -- 
>> 2.17.1
>>