Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Feb 2022 17:04:02 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     =?iso-8859-1?Q?H=E5kon?= Bugge <haakon.bugge@oracle.com>
Cc:     Jason Gunthorpe <jgg@ziepe.ca>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-rc] IB/cma: Allow XRG INI QPs to set their local ACK
 timeout
Message-ID: <YgPX4lxiNcT7Gx9t@unreal>
References: <1644412980-28424-1-git-send-email-haakon.bugge@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1644412980-28424-1-git-send-email-haakon.bugge@oracle.com>
Precedence: bulk

On Wed, Feb 09, 2022 at 02:23:00PM +0100, H?kon Bugge wrote:
> XRC INI QPs should be able to adjust their local ACK timeout.
> 
> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
> Signed-off-by: H?kon Bugge <haakon.bugge@oracle.com>
> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com>
> 
> ---
> 
> To avoid excessive discussions around the *if (WARN_ON( ...*
> construct, just saying that it has been sanctioned by Jason here:
> 
> https://lore.kernel.org/linux-rdma/20210413135120.GT7405@nvidia.com/

And I think that this is wrong, because it cane be triggered by user.
1. Create cm_id with any QP type you want - ucma_create_id()
2. Call to set option - ucma_set_option()
3. See WARN_ON.

Thanks

> ---
>  drivers/infiniband/core/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index 0f5f0d7..006ea9c 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout)
>  {
>  	struct rdma_id_private *id_priv;
>  
> -	if (id->qp_type != IB_QPT_RC)
> +	if (WARN_ON(id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_INI))
>  		return -EINVAL;
>  
>  	id_priv = container_of(id, struct rdma_id_private, id);
> -- 
> 1.8.3.1
>