Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1949985pxb; Wed, 9 Feb 2022 07:54:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqA+fOuLK9D8Y1omEP2ITNcTAUCa/G2oLABpmKsm+CvSf56ArLzyQP77HIxgrzYivKjac1 X-Received: by 2002:a05:6402:22f3:: with SMTP id dn19mr3242500edb.449.1644422092820; Wed, 09 Feb 2022 07:54:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644422092; cv=none; d=google.com; s=arc-20160816; b=rn+VEbPg2IBQjU1xEc8bMG2o3JxWEc6gkupdooKY8UUk6JWYFAT41Ou19+/82JT27n we/vCq59y7BpbDvNn1U9O5BHs6h4FCatwVxOCm7neNkZd9UIuJgy4RJlFnMWQYuUjtyk IAxZ/yhgtETJZ7t11qLfX4Xmv6qXKsLn1tt+aC10+HMcy6KeeLqbiYvvpzvOpbBqQlUj oc1gqhRBqj/eyF2AV5y5KdGSQwLeOQPq4/T4VzHAD/ixAqFfv9TZgBgY9I0wwp5kV7Ph VIe+g58g2LYo/rUzUQIluzkf+yOjts4yw3iQQ1+6cn6gw1pnrDdr9b8QdfE7QKY8aHxf 55MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=HWJxSwYp7jtZ92shaLhTfEcqyJ4FcqxLKxSHScXMFmA=; b=QKjBywV3a9d7Hg4nxV2eIyMCfYgZPiU7vCzlAIoHJNmJ8Ij8fmah8WEkcrug+zgskg 5YeKnQNhCiOMzHSLs5tsbi635kw9lUtzWmIRF6rvTbgFHI/vD5gFfOBV+pu8zQvtSY1X uMoURgRrFvUeHyg7KOpO8LQPQqS9iwY1srRwMexvQycR31rGOofvmY+XJ0MkN5/ayFm9 SUg5WItC8vnc6NPdlmfpd0t6jDEUJojb5dHucCGYL8WCFNRupYeoYeYZ45d0YfUD+UEz zSKUqmj0MC1yyj9yIR3CwG3Jnnck5cAikugYZ53ZMcQJRyx0IrgbwooaqQhPGT09pZI5 WF5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PyuTenbJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x5si3514537edd.246.2022.02.09.07.54.24; Wed, 09 Feb 2022 07:54:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PyuTenbJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235686AbiBIPUX (ORCPT + 99 others); Wed, 9 Feb 2022 10:20:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235683AbiBIPUV (ORCPT ); Wed, 9 Feb 2022 10:20:21 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C4F1EC0613CA for ; Wed, 9 Feb 2022 07:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644420024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HWJxSwYp7jtZ92shaLhTfEcqyJ4FcqxLKxSHScXMFmA=; b=PyuTenbJ41dM5debF7w6Co+TKiLJfVBr8cyhYPUt4fu3dF08QvMM59PBa3YU3t17p2HsxK vFbAgD2o6GVPyf86BefZ69if5ZvtmMZtWxa+4YzYM7zZJ2bIKSBLAgApQUAnrwC0eJKzGU BY9JrygxUlbsn/uIpnzLeMZNAbu1B18= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-249-zb1mVJcgP2uMAOLwj5qykg-1; Wed, 09 Feb 2022 10:20:22 -0500 X-MC-Unique: zb1mVJcgP2uMAOLwj5qykg-1 Received: by mail-wm1-f72.google.com with SMTP id 125-20020a1c0283000000b0037bf720e6a8so448511wmc.8 for ; Wed, 09 Feb 2022 07:20:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HWJxSwYp7jtZ92shaLhTfEcqyJ4FcqxLKxSHScXMFmA=; b=4P4BH9eRJtFeYXCSpn9AuwgRh3gAykRAmn32BUECZHZnyyAav0JR6JjEqh0zG44JNs BDImuSVIO2y6c27vFIrBOhMCufUw0zZ1xIki1shMgcSliuoh3UJM9qoXs/zPCTNOaziL nBuj9q4eDJEnl0Kc7HKFh3LqBqDDuKypDnewkd5slHeTkM/OOhKm17EdQ4/5v1zzYS1a 0d7YhqLwHdZjWqPIvBELxjyNj0gdyDWI9UkhBaHhbxkyciFjCFyYdWKSmDvvyqgaBHLz XANqHjkVmWlmvxvWA+Oiy+ol2nv253raapiC1FM1Rw2mrpZjuL5WLyOm/6UgaY4Xo6nJ gMDw== X-Gm-Message-State: AOAM533XsEBugy/ZwfBMVlwUb/SH1zlDpk9PJiNbJoGL4+Ti6pi6Af8m 0B98Q/irGts0Y+0YbnPtaRpn1otTkQi0T6gM2ADuqEj4CZMP5tjx1qmZ0wR9ggZ/7oFI8IvODIq xoTzjRqnfojNQSh/Lm1D7veF+LJSeRDRI8g6virIQ X-Received: by 2002:a1c:2942:: with SMTP id p63mr2494643wmp.75.1644420021706; Wed, 09 Feb 2022 07:20:21 -0800 (PST) X-Received: by 2002:a1c:2942:: with SMTP id p63mr2494623wmp.75.1644420021540; Wed, 09 Feb 2022 07:20:21 -0800 (PST) MIME-Version: 1.0 References: <20220209085243.3136536-1-lee.jones@linaro.org> <20220209150904.GA22025@lst.de> In-Reply-To: <20220209150904.GA22025@lst.de> From: Andreas Gruenbacher Date: Wed, 9 Feb 2022 16:20:10 +0100 Message-ID: Subject: Re: [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures" To: Christoph Hellwig Cc: Lee Jones , LKML , Stable , Dave Chinner , Goldwyn Rodrigues , "Darrick J . Wong" , Bob Peterson , Damien Le Moal , "Theodore Ts'o" , Ritesh Harjani , Johannes Thumshirn , linux-xfs@vger.kernel.org, linux-fsdevel , linux-ext4 , cluster-devel , syzbot+0ed9f769264276638893@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 9, 2022 at 4:09 PM Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 08:52:43AM +0000, Lee Jones wrote: > > This reverts commit 60263d5889e6dc5987dc51b801be4955ff2e4aa7. > > > > Reverting since this commit opens a potential avenue for abuse. > > > > The C-reproducer and more information can be found at the link below. This reproducer seems to be working fine on gfs2, but the locking in gfs2 differs hugely from that of other filesystems. > > With this patch applied, I can no longer get the repro to trigger. > > Well, maybe you should actually debug and try to understand what is > going on before blindly reverting random commits. Andreas