Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Feb 2022 16:26:09 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Qing Wang <wangqing@vivo.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Lee Jones <lee.jones@linaro.org>, linux-pwm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: use div64_u64() instead of do_div()
Message-ID: <20220209152609.gqeivcehkuzgz3sk@pengutronix.de>
References: <1644395998-4397-1-git-send-email-wangqing@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hakboj7n3cnu24o3"
Content-Disposition: inline
In-Reply-To: <1644395998-4397-1-git-send-email-wangqing@vivo.com>
Precedence: bulk


--hakboj7n3cnu24o3
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Feb 09, 2022 at 12:39:58AM -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>=20
> do_div() does a 64-by-32 division.
> When the divisor is u64, do_div() truncates it to 32 bits, this means it
> can test non-zero and be truncated to zero for division.
>=20
> fix do_div.cocci warning:
> do_div() does a 64-by-32 division, please consider using div64_u64 instea=
d.
>=20
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
>  drivers/pwm/pwm-berlin.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c
> index e157273..15b10cb3
> --- a/drivers/pwm/pwm-berlin.c
> +++ b/drivers/pwm/pwm-berlin.c
> @@ -109,7 +109,7 @@ static int berlin_pwm_config(struct pwm_chip *chip, s=
truct pwm_device *pwm,
> =20
>  	period =3D cycles;
>  	cycles *=3D duty_ns;
> -	do_div(cycles, period_ns);
> +	div64_u64(cycles, period_ns);

This is wrong, div64_u64() has a different calling convention than do_div().

The issue however is real. Please add=20

Fixes: 30dffb42fcd4 ("pwm: berlin: Implement .apply() callback")

to your v2.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--hakboj7n3cnu24o3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmID3Q4ACgkQwfwUeK3K
7AllnAf+O+1frxj5epv4nRAEt/Fq5cqM1lXqY1SLK9WFn7QzGqaDSdxFZX8HQJJB
1Ab3fUkZ3DCm9Wy4gEz7Hf5k43iiv+ZG5MvPKQgsoB2R40ru6RcOxftrdh2vYh5U
yhG8sklLkgM0U1Q2X65IMPXi8Vz4tB6FRK2pR+vrPl/Ae+loTkU337pN7ccCk5ur
IuIzZ4lkynjhX/1eU/ORevpZSvSp3HxyqBxFPx9oRSJ2J30gl2ElEWNYgnh+E8Vq
92RITLFwDGoZ1VYiZaGgFxI6vLSjGt1WxyCCMZv1vn+e4c4fw94328Vc2K/kzY5E
+S+u966W1vF4Z4ZTnt97oQUFJ01wPQ==
=Wd2L
-----END PGP SIGNATURE-----

--hakboj7n3cnu24o3--