Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   <alexandru.tachici@analog.com>
To:     <o.rempel@pengutronix.de>
CC:     <alexandru.tachici@analog.com>, <andrew@lunn.ch>,
        <davem@davemloft.net>, <devicetree@vger.kernel.org>,
        <hkallweit1@gmail.com>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux@armlinux.org.uk>,
        <netdev@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45
Date:   Wed, 9 Feb 2022 17:12:20 +0200
Message-ID: <20220209151220.15154-1-alexandru.tachici@analog.com>
In-Reply-To: <20220207092753.GC23727@pengutronix.de>
References: <20220207092753.GC23727@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

> On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:
> > > +		ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> > > +		if (ret < 0)
> > > +			return ret;
> > > +
> > > +		if (ret & MDIO_PMA_EXTABLE_BT1)
> > 
> > 
> > This pattern of reading the MDIO_PMA_EXTABLE register and then looking
> > for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
> > is expected to change is it? So i wounder if it should be read once
> > and stored away?
> 
> What is the state of this patches? Will you be able to make requested
> changes and send new version?

I will come back with a V5 where I will add the requested changes.

Regards,
Alexandru