Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <250ce1c2-95bf-3067-7bd6-5655038c5e69@gmail.com>
Date:   Wed, 9 Feb 2022 16:51:44 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [syzbot] WARNING in component_del
Content-Language: en-US
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        syzbot <syzbot+60df062e1c41940cae0f@syzkaller.appspotmail.com>
Cc:     andriy.shevchenko@linux.intel.com, dri-devel@lists.freedesktop.org,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        rafael.j.wysocki@intel.com, rafael@kernel.org,
        syzkaller-bugs@googlegroups.com
References: <00000000000016f4ae05d5cec832@google.com>
 <000000000000a17f2305d77f4cb7@google.com>
 <YgPEtCGDlSrqa1fK@kuha.fi.intel.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <YgPEtCGDlSrqa1fK@kuha.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Heikki,

On 2/9/22 16:42, Heikki Krogerus wrote:
> On Tue, Feb 08, 2022 at 02:37:10AM -0800, syzbot wrote:
>> syzbot has bisected this issue to:
>> 
>> commit 8c67d06f3fd9639c44d8147483fb1c132d71388f
>> Author: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Date:   Thu Dec 23 08:23:49 2021 +0000
>> 
>>     usb: Link the ports to the connectors they are attached to
>> 
>> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=14063168700000
>> start commit:   555f3d7be91a Merge tag '5.17-rc3-ksmbd-server-fixes' of gi..
>> git tree:       upstream
>> final oops:     https://syzkaller.appspot.com/x/report.txt?x=16063168700000
>> console output: https://syzkaller.appspot.com/x/log.txt?x=12063168700000
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45
>> dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f
>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15880d84700000
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14de0c77b00000
>> 
>> Reported-by: syzbot+60df062e1c41940cae0f@syzkaller.appspotmail.com
>> Fixes: 8c67d06f3fd9 ("usb: Link the ports to the connectors they are attached to")
>> 
>> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> 
> I'm guessing the component_add() is failing in this case. So I guess
> we need to consider the component_add() failures fatal in
> drivers/usb/core/port.c, which is a bit of a bummer. I'll send the
> fix.
> 

Seems something similar to your approach is already posted

https://lore.kernel.org/linux-usb/20220208170048.24718-1-fmdefrancesco@gmail.com/


With regards,
Pavel Skripkin