Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Feb 2022 07:45:14 -0800 (PST)
From:   Hugh Dickins <hughd@google.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
cc:     Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@suse.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Matthew Wilcox <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Alistair Popple <apopple@nvidia.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Rik van Riel <riel@surriel.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Yu Zhao <yuzhao@google.com>, Greg Thelen <gthelen@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        SeongJae Park <sj@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH 10/13] mm/munlock: mlock_page() munlock_page() batch by
 pagevec
In-Reply-To: <CAMuHMdVxrYioQX1H8CPpYcSADN=22Se-pW14fPu9R0G+6iDtYw@mail.gmail.com>
Message-ID: <d6a391-212f-af1-d762-6231ed904135@google.com>
References: <8e4356d-9622-a7f0-b2c-f116b5f2efea@google.com> <eadba522-cfe1-b0d6-56fc-7bc9f649b89d@google.com> <CAMuHMdVxrYioQX1H8CPpYcSADN=22Se-pW14fPu9R0G+6iDtYw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="0-1892591577-1644421517=:6994"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-1892591577-1644421517=:6994
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 9 Feb 2022, Geert Uytterhoeven wrote:
>=20
> Thanks for your patch, which is now commit cbaf47432c909044
> ("mm/munlock: mlock_page() munlock_page() batch by pagevec") in
> next-20220209.
>=20
> > --- a/mm/internal.h
> > +++ b/mm/internal.h
> > @@ -402,7 +402,8 @@ extern int mlock_future_check(struct mm_struct *mm,=
 unsigned long flags,
> >   *
> >   * mlock is usually called at the end of page_add_*_rmap(),
> >   * munlock at the end of page_remove_rmap(); but new anon
> > - * pages are managed in lru_cache_add_inactive_or_unevictable().
> > + * pages are managed by lru_cache_add_inactive_or_unevictable()
> > + * calling mlock_new_page().
> >   *
> >   * @compound is used to include pmd mappings of THPs, but filter out
> >   * pte mappings of THPs, which cannot be consistently counted: a pte
> > @@ -425,6 +426,9 @@ static inline void munlock_vma_page(struct page *pa=
ge,
> >             (compound || !PageTransCompound(page)))
> >                 munlock_page(page);
> >  }
> > +void mlock_new_page(struct page *page);
> > +bool need_mlock_page_drain(int cpu);
> > +void mlock_page_drain(int cpu);
>=20
> This is inside an #ifdef CONFIG_MMU section.
>=20
> > --- a/mm/swap.c
> > +++ b/mm/swap.c
>=20
> > @@ -640,6 +634,7 @@ void lru_add_drain_cpu(int cpu)
> >                 pagevec_lru_move_fn(pvec, lru_lazyfree_fn);
> >
> >         activate_page_drain(cpu);
> > +       mlock_page_drain(cpu);
>=20
> noreply@ellerman.id.au reported for m5272c3_defconfig:
>=20
>     mm/swap.c:637:2: error: implicit declaration of function
> =E2=80=98mlock_page_drain=E2=80=99 [-Werror=3Dimplicit-function-declarati=
on]
>=20
> http://kisskb.ellerman.id.au/kisskb/buildresult/14694567/

Hi Geert, thanks for your report: SeongJae has posted a fix

https://lore.kernel.org/lkml/20220209094158.21941-2-sj@kernel.org/

but there I'm wondering if it's complete: I'll settle it later today.

Hugh
--0-1892591577-1644421517=:6994--