Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220209100413.23714-1-potin.lai@quantatw.com>
In-Reply-To: <20220209100413.23714-1-potin.lai@quantatw.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 9 Feb 2022 09:33:44 -0600
Message-ID: <CAL_JsqLM552FjvjdECq56kYsx9+mPuyvpUNibtuH--pgyF4pDQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/1] arch: arm: dts: update bletchley dts
To:     Potin Lai <potin.lai@quantatw.com>
Cc:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        Patrick Williams <patrick@stwcx.xyz>,
        Allen Wang <Allen_Wang@quantatw.com>,
        devicetree@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 9, 2022 at 4:04 AM Potin Lai <potin.lai@quantatw.com> wrote:
>
> updates:
> * seperate leds into multiple groups
> * switch sled numbering to 1-based
> * disable inchip rtc
> * add flash1 in fmc
> * switch spi2 pnor using spi-gpio
> * update gpio-line-names
> * add interrupt pin for each sledx_ioexp
> * enable mdio3
> * update ADM1278 shunt resistor (300 micro Ohm)
> * add INA230 for each sled

Please read documentation on writing commit messages. Answer why you
are making the change, not what you are changing.

Each bullet should probably be a separate commit. The question to
answer is are there compatibility issues (what happens with old DT and
new kernel and vice-versa)?

Rob