Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220123184541.993212-1-daviddunn@google.com> <20220123184541.993212-2-daviddunn@google.com>
 <CALMp9eSuavLEJ0_jwuOgmSX+Y8iJLsJT0xkGfMZg6B7kGyDmBQ@mail.gmail.com> <09d8b472-000b-7150-f60d-ffb5706b164e@gmail.com>
In-Reply-To: <09d8b472-000b-7150-f60d-ffb5706b164e@gmail.com>
From:   David Dunn <daviddunn@google.com>
Date:   Wed, 9 Feb 2022 09:30:10 -0800
Message-ID: <CABOYuvZubA+Et9hzVrF03xCsNeAG4cz68_qG6KgAmTVHBvPoXw@mail.gmail.com>
Subject: Re: [PATCH v5 1/3] KVM: x86: Provide per VM capability for disabling
 PMU virtualization
To:     Like Xu <like.xu.linux@gmail.com>
Cc:     "Paolo Bonzini - Distinguished Engineer (kernel-recipes.org) (KVM HoF)" 
        <pbonzini@redhat.com>, kvm@vger.kernel.org, seanjc@google.com,
        Jim Mattson <jmattson@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Joerg Roedel <joro@8bytes.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks Like.

I just sent a new v6 series with these minor merge conflicts resolved.

Dave

On Wed, Feb 9, 2022 at 2:33 AM Like Xu <like.xu.linux@gmail.com> wrote:
>
> cc LKML and full list of KVM reviewers.
>
> On 25/1/2022 2:39 am, Jim Mattson wrote:
> > On Sun, Jan 23, 2022 at 10:45 AM David Dunn <daviddunn@google.com> wrote:
> >>
> >> KVM_CAP_PMU_DISABLE is used to disable PMU virtualization on individual
> >> x86 VMs.  PMU configuration must be done prior to creating VCPUs.
> >>
> >> To enable future extension, KVM_CAP_PMU_CAPABILITY reports available
> >> settings via bitmask when queried via check_extension.
> >>
> >> For VMs that have PMU virtualization disabled, usermode will need to
> >> clear CPUID leaf 0xA to notify guests.
> >>
> >> Signed-off-by: David Dunn <daviddunn@google.com>
> >
> > Nit: The two references to CPUID leaf 0xA should be qualified as
> > applying only to Intel VMs.
> >
> > Reviewed-by: Jim Mattson <jmattson@google.com>
> >
>
> Nit: It looks like we already have "#define KVM_CAP_SYS_ATTRIBUTES 209".
>
> Hope it helps a little:
>
> Reviewed-by: Like Xu <likexu@tencent.com>