Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2101721pxb; Wed, 9 Feb 2022 10:52:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRjp4H8S1G3hzKmX7wWRm+B6chPRB4HMzqhLtsZdyD2dxP/+TfedeREAosYRiofiKbvRQd X-Received: by 2002:a17:90b:4b90:: with SMTP id lr16mr4065228pjb.52.1644432743028; Wed, 09 Feb 2022 10:52:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644432743; cv=none; d=google.com; s=arc-20160816; b=rNbJA3Ia0/j2jYQiKF6kGm2DAcXzNruIgsalGQ7yZme74ajk+2yp6eu0r/6VLEQ87x z3I5R7vjb0sbSbYjyxogs+4GH4FsY/gPlB4K+Pf4SpmWqxSf35jJyk+Q5UQMBzSlODix iOLB5ZHE/FWrZa/sH60j3G1oK5fzLEZbSQxvRe7xWWANy+jl+g8qzMbR8O1S5AO9rZfQ IF3FSJ3GaUv/CxJ6SUYt7kUNypNPTf7l4W5rxG3cRedF1sk0AWuXQEN75CB2Rgm358qF 4pnqnGqqTLrYX4Bhv4bHI8LWkYNz50Yw26x5EKnO7ygQGRWDVyO+62nlBGEGyQHI0d6P Q7lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Bn0WKXvV0wH64Fyn35769rJ1j57jq4L1z8r72QPkfFc=; b=bwfdShRjBTyb/6jTfu9UByIe5NzZIO69MRX4Zrgr/FqA7JYn0nBCs16X+JrayZqmIb aGj9iYJUy7hSqc7YMl8Z+dqTWqCNc5tkL9IVGkEzgy+WB4cfBgcChEnWrofQRO++ndyu GgfUHtFcoKRdrZbQ/N+Lctk+Ze2I8jIvhnIzHDLWHoJeyit+wtmnIBW0TbWFtt6EXjrW icikk4FsFyjB2CLIXijAxnU9tg29I94+ZO4dtx5MCIVQqgDFAiP5WKABwVSIpbGLq5sI P7PFpgHR8jFwBpPreuH/PmZdwVzTN9olkoFNfHPZEneEuU7635sSz+PKW1UcjphNnfg2 vL1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mk35s4az; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si15224737plr.568.2022.02.09.10.52.11; Wed, 09 Feb 2022 10:52:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mk35s4az; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237655AbiBIS2b (ORCPT + 99 others); Wed, 9 Feb 2022 13:28:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231371AbiBIS23 (ORCPT ); Wed, 9 Feb 2022 13:28:29 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A2D3C0613C9; Wed, 9 Feb 2022 10:28:32 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id g145so2383255qke.3; Wed, 09 Feb 2022 10:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bn0WKXvV0wH64Fyn35769rJ1j57jq4L1z8r72QPkfFc=; b=mk35s4az97TJp7WfXMKqywtvIL/s3xNeyXIfFuo5hIiD8kYz7JSXzA7iPm9s93qzia rb9GnE5LW7nRpZ5aApDa/VEWjtoepo5/CyhjVaBUdBoy+s6YmL5mMXqhqTveEu2JO6ig acHz36mOOUPVnZ/e87ob1egzCaZQlawtlR2btLGEwhgHF68EfsS+2QcmFuQlR6w9ddkC ko1PzC494fLN6e9THRBv01pXvoFr01ts5EwGBi5MyI3IcDPQdsUOdjYRKqsH4MSehPV2 6iD5ZLJLjhdlURGdbduaTHkRstqsfgK4kkffV4QSa6AH4AAUjSL+rVzPKnfrwBnjD36v vPog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bn0WKXvV0wH64Fyn35769rJ1j57jq4L1z8r72QPkfFc=; b=4pZN49pjxBX1E0zORTBujEtykZxz1BrChcZVv6eABMeN5nKPFUPawekPtt2eSaU27/ Zgstm6JrxLXYjCf2W4YUk0hKboL5iKJ7DpLrqgqwNS2pHQtSR8tyJQD8sq17cKffhvCP zF2NBx/NlnvVdwcF57/74uCHVQQ391kT+9Dj55tjXXvGtR+ROw8M5vrqeQT9db6cTFpa SXumzXAC+3ggXq12AAsUX6+9zrUaqOxExD4+pFRdInckINR1SUEkwJt+rrIwbhuq3eP8 3kjNal0HSPz+P5MPfEYXPPOMy912Fd9q2gv22UgFs43FBrCKQXsbRuY0bjnhUG4pQDgx UWAw== X-Gm-Message-State: AOAM532X2yu/9f+PioajrLZvUKTuMNZFkcrFFiujfllhzhz58Jy3DKgl mK/DlOt8nKX5XzIXZDKmcNk= X-Received: by 2002:a05:620a:25d2:: with SMTP id y18mr1886373qko.522.1644431311724; Wed, 09 Feb 2022 10:28:31 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.gmail.com with ESMTPSA id z4sm9831131qtw.4.2022.02.09.10.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 10:28:31 -0800 (PST) From: Sean Anderson To: Linus Walleij , linux-gpio@vger.kernel.org Cc: Damien Le Moal , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter , Sean Anderson Subject: [PATCH] pinctrl: k210: Fix bias-pull-up Date: Wed, 9 Feb 2022 13:28:22 -0500 Message-Id: <20220209182822.640905-1-seanga2@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using bias-pull-up would actually cause the pin to have its pull-down enabled. Fix this. Signed-off-by: Sean Anderson --- drivers/pinctrl/pinctrl-k210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c index 49e32684dbb2..1ad61b32ec88 100644 --- a/drivers/pinctrl/pinctrl-k210.c +++ b/drivers/pinctrl/pinctrl-k210.c @@ -527,7 +527,7 @@ static int k210_pinconf_set_param(struct pinctrl_dev *pctldev, case PIN_CONFIG_BIAS_PULL_UP: if (!arg) return -EINVAL; - val |= K210_PC_PD; + val |= K210_PC_PU; break; case PIN_CONFIG_DRIVE_STRENGTH: arg *= 1000; -- 2.34.1