Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
To:     Jani Nikula <jani.nikula@linux.intel.com>,
        Christoph Hellwig <hch@lst.de>
CC:     Zhi Wang <zhi.wang.linux@gmail.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Xu, Terrence" <terrence.xu@intel.com>
Subject: Re: [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO
 new mdev API
Thread-Topic: [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support
 VFIO new mdev API
Thread-Index: AQHYHNy+WB6hSk3In0CMw3y1iZvDnKyJw40AgAEP4YCAABsQgIAAtm8A
Date:   Wed, 9 Feb 2022 19:57:55 +0000
Message-ID: <99c2ad07-ddce-2473-fb30-388760a924e7@intel.com>
References: <20220208111151.13115-1-zhi.a.wang@intel.com>
 <871r0dqtjf.fsf@intel.com> <20220209072805.GA9050@lst.de>
 <87v8xopg06.fsf@intel.com>
In-Reply-To: <87v8xopg06.fsf@intel.com>
Accept-Language: en-FI, en-US
Content-Language: aa
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?Uyp9Sl/G5rLOEnhEnw0QM9Wr0cFtnhUzZkTFFTSbFUmA2Nx0FcCkqR27?=
 =?Windows-1252?Q?ak7LUDFpfwpp89a4tzy3zQxjiKi6IXe3eGt/X3QjbZ0mCl8Artphfraa?=
 =?Windows-1252?Q?nHctWTnuOQ4gUZF2rY1yMzIU752J5RBmR593xCh+vHLBhp8T3CByn9lq?=
 =?Windows-1252?Q?YgCEL9QDLmOBWoCqRZ9OesVdiBIwqdYeiBWnHppAII8gWIeu1HriN5W+?=
 =?Windows-1252?Q?u/x8CZqX08mikeux8Fm+lLqJ0oGv24S/C/G3GDrC6JCMmrUt+ZtlrEZH?=
 =?Windows-1252?Q?vyiwR/zb5MXB3ZNjKDfrqYl2pzpchXdDYYBWr3KxEtSjI0MT5hMoGh5N?=
 =?Windows-1252?Q?BklAk5MLz0+OmN1K5XKhMAWdsKMSKlhqOrV4J0cwV4o3CvBxMRIlBn5p?=
 =?Windows-1252?Q?hNYAJNOc+Lk95MCqDE3QPjkGxh4Mn83GxiNwI1vLg1lfJ+3e+3glp20y?=
 =?Windows-1252?Q?EP8uxb/Ud6MdqdGntMrG+5HdRRuiAFrbn9D1gNYsp43RiP/kCMGkwt1W?=
 =?Windows-1252?Q?mwm/gxd50X3fdOw0YFHGravJAWcM/PrJZppTjM9XCWyaaczoI1k+Ez9F?=
 =?Windows-1252?Q?I5TpVrfUNKTPHFH/qAIfMIdx81QiCkO3qlGedH7il0kdHb5NL+YnBfoO?=
 =?Windows-1252?Q?GE2Cx7s/7K5LrBP+y8KQhO59w91V+0tgaFPEfO2YuQxzMOfOy1UjHahQ?=
 =?Windows-1252?Q?ZlEQLDoXduRjhSkf2HjbUts/NJXX5ioihPIEynS2sMdDVEqPnS+pNkSo?=
 =?Windows-1252?Q?zyRWxTZTDVC8MrT1morKJApPLDC3o4hHFAUqRxzPcp1CtGuRIoTWTgIx?=
 =?Windows-1252?Q?yhwo4CsOwdP7M5FAw+/hbz49gtvv4pW431Ywq/pBn+vDIA1xh81AcN8E?=
 =?Windows-1252?Q?Rja0De72btUHRDz4/xMsa6n/f4Rm1ADw3Wb1sgStCozlALw3XcQagzqV?=
 =?Windows-1252?Q?sUAdLjTNuaO3xQvW6R6f3K/g7WAjeGPdFyodgdrJXVZ728asQWZPfbMo?=
 =?Windows-1252?Q?mwzrv9UsS7vqTEH7/7J9H48zsGaC8z6JF6KDJpsor7wr1snHdb5oXVij?=
 =?Windows-1252?Q?PjhdVYIkUy07A6PykrT+P/sJDYQ+rtNo8327TzA6M+eNxlQOQR6hTuUy?=
 =?Windows-1252?Q?xow9uK8bOd2QFsuonJlIieAWUN2XaQ3pdrk0jzH/o4wC+0gC2XGeyg1k?=
 =?Windows-1252?Q?byBiB8aEdTEL2VqePsdEZvy+JSXkMYgVaKselDB+XHhW/Tp4dipA2SsM?=
 =?Windows-1252?Q?hAJ6OVjMCiNQ4jsPOPygjGSitKc+Yeq0EyrNjSeBZvAoiWAVa8NYWzxo?=
 =?Windows-1252?Q?tXGVdzwxHvQ+aT2JytjeDs6h+OkUBv9PAtBGj1+UANJE5zr7vmMtHPLn?=
 =?Windows-1252?Q?ryneOZgaB7aYMLHq8ivleTXD2AcYomisvCmK7CvwkJE1OH/ixVN9pvVi?=
 =?Windows-1252?Q?7UG51dAaP2r4R5wTHEg20x4PtJUjvbaYTVOaAX39tymSa7Nya4I2uyc+?=
 =?Windows-1252?Q?hDemwTLpwSH+ALEexzZb0IsD2QrsAYSa6915oad2C5OYutnVq4AKwMID?=
 =?Windows-1252?Q?oHIrb8asoH4MTqLtvzXCVl+QOUmeKJ9A+mkpaMmgKtNPjFbEAZylk5xi?=
 =?Windows-1252?Q?CfF/8bvVToS7xu3IZigDDWoxGD1BW1loTQRlCULwOImqNyE0e3mCt9xE?=
 =?Windows-1252?Q?IVHi9kLI4DTboVyWrcMWHfRa7/u3mKv8UreLPYGUC44+D3qUwfzC27oG?=
 =?Windows-1252?Q?xkD+zeV/Cmcujfo8CMg=3D?=
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <23DC5BC60BCC7548AB12F214222648B7@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 476cf8ba-55b8-422c-5298-08d9ec067680
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 19:57:55.0934
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /5j3BLR/u6ae+tT48M8aVViZnvegKv/S/yrb81Px4LUNQ1JSy6ZH0UYSy7zvYl3sCg+d6uPFbrnbfMobY4pJJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2897
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/9/22 9:04 AM, Jani Nikula wrote:
> On Wed, 09 Feb 2022, Christoph Hellwig <hch@lst.de> wrote:
>> On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote:
>>>>  #ifdef CONFIG_DRM_I915_GVT
>>>> +
>>>> +#define D_BDW   (1 << 0)
>>>> +#define D_SKL	(1 << 1)
>>>> +#define D_KBL	(1 << 2)
>>>> +#define D_BXT	(1 << 3)
>>>> +#define D_CFL	(1 << 4)
>>>> +
>>>> +#define D_GEN9PLUS	(D_SKL | D_KBL | D_BXT | D_CFL)
>>>> +#define D_GEN8PLUS	(D_BDW | D_SKL | D_KBL | D_BXT | D_CFL)
>>>> +
>>>> +#define D_SKL_PLUS	(D_SKL | D_KBL | D_BXT | D_CFL)
>>>> +#define D_BDW_PLUS	(D_BDW | D_SKL | D_KBL | D_BXT | D_CFL)
>>>> +
>>>> +#define D_PRE_SKL	(D_BDW)
>>>> +#define D_ALL		(D_BDW | D_SKL | D_KBL | D_BXT | D_CFL)
>>>
>>> If these really need to be in a header in i915/, I think they need to b=
e
>>> longer with some namespacing or something. I do wish these could be
>>> hidden though.
>>
>> I think we could actually kill them off entirely.  They are used as
>> arguments to the macros that setup the mmio table.
>>
>> Thefunctions to build these tabls are already organized by families,
>> so we'd need relatively few conditions to just build them the right
>> way.  There also are some runtime checks in the callbacks, but they
>> seem entirely superflous as far as I can tell.
>>
>> Only the cmd parser is a bit messy.  So maybe we could keep these
>> constants just for the cmd parser inside of gvt for now (and clean
>> that up later) and remove them entirely from the mmio table.
>=20
> I'm fine with cleaning this up in follow-up, provided the follow-up
> actually happens! ;)

Thanks so much for the comments and the support. :)

>=20
> BR,
> Jani.
>=20
>=20