Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 9 Feb 2022 15:57:03 -0600
From:   Rob Herring <robh@kernel.org>
To:     Rajat Jain <rajatja@google.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rajat Jain <rajatxjain@gmail.com>,
        Dmitry Torokhov <dtor@google.com>,
        Jesse Barnes <jsbarnes@google.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Pavel Machek <pavel@denx.de>,
        Oliver O'Halloran <oohall@gmail.com>,
        Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: Document "UntrustedDevice" property
 for PCI devices
Message-ID: <YgQ4r34842L6puV+@robh.at.kernel.org>
References: <20220202020103.2149130-1-rajatja@google.com>
 <20220202020103.2149130-2-rajatja@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220202020103.2149130-2-rajatja@google.com>
Precedence: bulk

On Tue, Feb 01, 2022 at 06:01:03PM -0800, Rajat Jain wrote:
> Add the new "UntrustedDevice" property for PCI devices. This property
> is optional and can be applied to any PCI device.
> 
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> v2: Initial version (added documentation based on comments)
> v1: Does not exist.
> 
>  Documentation/devicetree/bindings/pci/pci.txt | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)

New properties have to be in a schema which resides here:

https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/pci/pci-bus.yaml

> 
> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> index 6a8f2874a24d..bc1ba10f51e1 100644
> --- a/Documentation/devicetree/bindings/pci/pci.txt
> +++ b/Documentation/devicetree/bindings/pci/pci.txt
> @@ -82,3 +82,38 @@ pcie@10000000 {
>  		external-facing;
>  	};
>  };
> +
> +PCI Device Properties
> +---------------------
> +Following optional properties may be present for any PCI device:
> +
> +- UntrustedDevice:
> +   When present, this property is an indicator that this PCI device (and
> +   any downstream devices) are to be treated as untrusted by the kernel.
> +   The kernel can, for example, use this information to isolate such
> +   devices using a strict DMA protection via the IOMMU.
> +
> +   Example device tree node:
> +	pcie@0008 {
> +		/* PCI device 00:01.0 is an untrusted device */
> +		reg = <0x00000800 0 0 0 0>;
> +		UntrustedDevice = <1>;
> +	};
> +
> +   Example ACPI node:

Humm, your caret case smelled like ACPI to begin with. As far as ACPI 
bindings in Documentation/devicetree/bindings/ are concerned, NAK.