Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <8622afaf-6448-8932-9971-6bfaaa8c311a@amd.com>
Date:   Wed, 9 Feb 2022 16:14:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH -next] drm/amdkfd: Fix NULL but dereferenced coccicheck
 error
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, daniel@ffwll.ch
Cc:     airlied@linux.ie, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220209013940.71348-1-yang.lee@linux.alibaba.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <20220209013940.71348-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ri92MUZ0MGFHTXZET3dRSU1hNDEybUgyL3VUQmhyRGhwR3VoNGEwSU5WbEQ2?=
 =?utf-8?B?aW4zL3hTRFF2YjZDbDgxUVpKNmlyVms4bUFMcTdkMGVURVN4eThZaklTVTZN?=
 =?utf-8?B?di9tL25mRWZEVkZORmZqUXZTWkJNd3lVNzBDQVBDNkZ1allYRC9nTEZUSEtj?=
 =?utf-8?B?NElBcFI3d0phbnhRTEpOMktUR0NDcWU1NE02YjUyaldKWC9MRmlNQ3dwU1JL?=
 =?utf-8?B?TWorYmtWcmE3aVFmbXJRcE5wOU83dlNDTm9McWVFdG52OS9ETG1GYzhDYzBw?=
 =?utf-8?B?WTdyOU5jRDZGMU4vTWw0M3hlSS9SUjY2dWRRTDRsaGwvTWhlODBUZG5SZjRV?=
 =?utf-8?B?QVkweitDUnFWdHZONUxLQmxXTGl3UXlLK3NqZlYwNUJ2dGVDTlkzVFJGUk5t?=
 =?utf-8?B?Wk5nRnUwZmlzODJ1RFk1M0dERWY1eFJ6cU9IN0ZhVzRla0tZWDNDbUI0VmFi?=
 =?utf-8?B?OUdKVFpUemhodGtjL0JqR1cyclVDdkcvNDcwQWFUUWVNWTEwVDlUaGZTQzJp?=
 =?utf-8?B?NmJCb0kwazdKTHd1MnA4bnR5c2l4bmdLVzRWL0d0WXdRTm5xUDBPTlBnNk15?=
 =?utf-8?B?ZHREUEU2ekFaUUxWbUFtalNLZmRHMUlSc2VJUUNhOUxScjVmUnRJZTJBUkVH?=
 =?utf-8?B?UkhMd0xERXgyYTRmd2duYUNoZk1Ndko5T0E1emMwckdPN1hyQjR3N1R3dGtn?=
 =?utf-8?B?Y1I4NCttL3lHdXNEZDFFUDBjQjVKMTIxYXl3anljdllsVDZLaHV4Q1dlQWpF?=
 =?utf-8?B?NHA5aW41UFZtanFlM0NXbE4vbHFkK2FSZmpuQ1MzOEdaS2pmdGFybnBZa1hp?=
 =?utf-8?B?RUpRZi91cFNTOU5PQTdvQXh5RjVpYUk2bHQyamZoYVEwQWRvSDR0bFZZZHpm?=
 =?utf-8?B?NW8yRWVyb29GNFVsbDVBdDdTNXIwWlNjaTNDQXZEZkowbW00dUw3YVU1Wkda?=
 =?utf-8?B?TVF2WHFyazl2ejhXVzM5dlFuNGtMOXdkN05UV2pDUlA4UXJOWDVKSnlTbnl1?=
 =?utf-8?B?d3FIVWU1elhpNGozNU1hTG1IRXFoUDBiKzExYmdFYzRHdWFiS3pJL3YzUlh5?=
 =?utf-8?B?SVVyNHQxVVdmWUEwVC9MSVRxZDBMRDNNUnJ4aS9DSG1OMnRidWlQTWZOZUJ2?=
 =?utf-8?B?Z1paV0NTVUZmUHJZM3dJVk0rVzNVR2NBZWlSR3o3UHZ5b2V6Y0tkZTJySGdi?=
 =?utf-8?B?VCtScDhJQ1NHSlRyc0FoT2FEczUybmlLdzVFU2R3N1VZSzdxR0grc2h5NFho?=
 =?utf-8?B?emEyZ1NEZjNVYllhSkVhQnZYSFdYK2ErVTJlYjMzWmtCWWkwZ2Y0bFgxRG12?=
 =?utf-8?B?ei9iRFJKWmlSNXNseUZxclB3elB4ckVTR2hPdXc5aHBqSXRIQkJGNDkrLzFL?=
 =?utf-8?B?RS8xTzJQcjNCV09aMFVjTW5lcmt5MEFWMlpmOGkxZDRabWF6UmwxUVZsRjIw?=
 =?utf-8?B?Q0gzU3BtS28xNEFjMnE2eXRVTEd3MFJBQ2lmYU9TNzRTRG5TaUk4U0RpdHpt?=
 =?utf-8?B?RC9OdGhGWmdoWGpoQU1SNnppcVQ4MC9YYkF4Ymt6Y0FaNU5lZnhCMkhGTDQ1?=
 =?utf-8?B?UXlMcDFoUW02WnJkRjAzZ3Z1cXd0QWh0ZnFLTmtRNWJtd0xjZzBhQ2piSVpl?=
 =?utf-8?B?ZHN1Qmk5TGxQNHlsdWQ4c01kNDhMS01iTW0vOXlTVDdSUGFhTEhGNnFzVjZG?=
 =?utf-8?B?WDJ2VjVEeWhuTXUvQ1k0bDJML1YxRFU1UGd2K2lRNnYvSEpKODBpWlkxVFda?=
 =?utf-8?B?VW0zczBqenRmdG1pd0Nrb003S1BjWlFoVDY3ZnNLTk9zZGpwUHloVmNTSEhW?=
 =?utf-8?B?Wkx0OUtQMTdjNWZ5VzVNQS9JeGVydzRJT1hEUXZOWlVxbGt6VjkxcTRsamM3?=
 =?utf-8?B?MlZ3d0IweG9QK2ZtTkdoeWpkcitCVFhBZE1QdVY4aXRuVldiWDlBdDdpRWVG?=
 =?utf-8?B?aU9UeHkyOHVjdkJuSzRPSkE4cUpqckR5dUtyOEFYQU5remtTanpSOXN0S0FK?=
 =?utf-8?B?T1JkWEdUQld2YmJJSnNXTDJtUkU2NnBIK3VuZlU4bG96ZDFINTlGL21jdFZn?=
 =?utf-8?B?L3dnYWJIanR4Z29PcUpDZVB2UXlNUG1BejRscjJVanNLL1hZVUtORHVTK0Fj?=
 =?utf-8?B?R2QvcmM5V1VGdHZZempCU1UrS2lkZzVHZW91dUNmUml0OFlhK29IOGFRRDhj?=
 =?utf-8?Q?+HKdNBm4JjsOuM2tYHEECEw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85f00187-eecf-4ac2-c5df-08d9ec113602
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5112.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 21:14:51.6104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PN3+RtGmspX+/fx4zvG/tl4AXmA4cmSImq0QfQA+iTnkNAeaCec0RCLvN7XSFJsxZeztUQNkUeK21/IkpRn86A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5556
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-02-08 20:39, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:2087:27-38: ERROR: bo_buckets
> is NULL but dereferenced.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Thank you. I already picket up Tom Rix's patch for the same issue.

Regards,
   Felix


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 64e3b4e3a712..636391c61caf 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -1982,10 +1982,8 @@ static int criu_checkpoint_bos(struct kfd_process *p,
>   	void *mem;
>   
>   	bo_buckets = kvzalloc(num_bos * sizeof(*bo_buckets), GFP_KERNEL);
> -	if (!bo_buckets) {
> -		ret = -ENOMEM;
> -		goto exit;
> -	}
> +	if (!bo_buckets)
> +		return -ENOMEM;
>   
>   	bo_privs = kvzalloc(num_bos * sizeof(*bo_privs), GFP_KERNEL);
>   	if (!bo_privs) {