Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 9 Feb 2022 20:07:01 +0100
From:   Pavel Machek <pavel@denx.de>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Miaoqian Lin <linmq006@gmail.com>,
        Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 4.19 77/86] ASoC: fsl: Add missing error handling in
 pcm030_fabric_probe
Message-ID: <20220209190701.GA10459@duo.ucw.cz>
References: <20220207103757.550973048@linuxfoundation.org>
 <20220207103800.195504006@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua"
Content-Disposition: inline
In-Reply-To: <20220207103800.195504006@linuxfoundation.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--SUOF0GtieIMvvwua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> commit fb25621da5702c104ce0a48de5b174ced09e5b4e upstream.
>=20
> Add the missing platform_device_put() and platform_device_del()
> before return from pcm030_fabric_probe in the error handling case.

Are you sure?

> --- a/sound/soc/fsl/pcm030-audio-fabric.c
> +++ b/sound/soc/fsl/pcm030-audio-fabric.c
> @@ -90,16 +90,21 @@ static int pcm030_fabric_probe(struct pl
>  		dev_err(&op->dev, "platform_device_alloc() failed\n");
> =20
>  	ret =3D platform_device_add(pdata->codec_device);
> -	if (ret)
> +	if (ret) {
>  		dev_err(&op->dev, "platform_device_add() failed: %d\n", ret);
> +		platform_device_put(pdata->codec_device);
> +	}
> =20
>  	ret =3D snd_soc_register_card(card);
> -	if (ret)
> +	if (ret) {
>  		dev_err(&op->dev, "snd_soc_register_card() failed: %d\n", ret);
> +		platform_device_del(pdata->codec_device);
> +		platform_device_put(pdata->codec_device);
> +	}
> =20
>  	platform_set_drvdata(op, pdata);
> -
>  	return ret;
> +
>  }

Besides interesting whitespace, this will happily do
platform_device_put() twice. I suspect it should return or
something. This does not look right.

Best regards,
							Pavel
--=20
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--SUOF0GtieIMvvwua
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYgQQ1QAKCRAw5/Bqldv6
8r6yAJ0b32yBnFzeOQ+ZKSYI5cF+pD0jXQCfUFZuWjyWGVZtzMvCNHmWiEODMZs=
=FNvY
-----END PGP SIGNATURE-----

--SUOF0GtieIMvvwua--