Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Sender: nitirawa=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 10 Feb 2022 02:47:47 +0530
From:   nitirawa@codeaurora.org
To:     Keith Busch <kbusch@kernel.org>
Cc:     Vidya Sagar <vidyas@nvidia.com>, rafael.j.wysocki@intel.com,
        keith.busch@intel.com, hch@lst.de, bhelgaas@google.com,
        mmaddireddy@nvidia.com, kthota@nvidia.com, sagar.tv@gmail.com,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Query related to shutting down NVMe during system suspend
In-Reply-To: <20220209202639.GB1616420@dhcp-10-100-145-180.wdc.com>
References: <65b836cd-8d5d-b9c2-eb8f-2ee3ef46112b@nvidia.com>
 <20220209202639.GB1616420@dhcp-10-100-145-180.wdc.com>
Message-ID: <bc80ec7d1ca2c56feded1a6848c285ef@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2022-02-10 01:56, Keith Busch wrote:
> On Tue, Feb 01, 2022 at 09:52:28PM +0530, Vidya Sagar wrote:
>> Hi Rafael & Christoph,
>> My query is regarding the comment and the code that follows after it 
>> at
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nvme/host/pci.c?h=v5.17-rc2#n3243
>> What I understood from it is that, there is an underlying assumption
>> that the power to the devices is not removed during the suspend call.
>> In the case of device-tree based platforms like Tegra194, power is
>> indeed removed to the devices during suspend-resume process. Hence, 
>> the
>> NVMe devices need to be taken through the shutdown path irrespective 
>> of
>> whether the ASPM states are enabled or not.
>> I would like to hear from you the best method to follow to achieve 
>> this.
> 
> Christoph prefers to append quirks for platforms that need full device
> shutdown on s2idle instead of changing the driver default.
> 
> We use dmi matching for our current platform quirk list. I do not know
> what the equivalent is for device-tree based platforms. Do you know?

Hi Keith,

IMO, the NVME driver is not associated with any device tree, Instead PCI 
driver is associated with device tree.
So unlike ACPI based platform where we have platform specific DMI 
matching, we don't have equivalent check for DT based platform.

Do we see any concern if we introduce a module param with default not 
set to quick suspend.
For platform that need full shutdown durring resume , they can set it to 
quick suspend.