Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <cf985291-36a9-e60e-f1e1-f12719c7b3fb@oracle.com>
Date:   Wed, 9 Feb 2022 10:59:20 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 4/5] mm: hugetlb: fix missing cache flush in
 hugetlb_mcopy_atomic_pte()
Content-Language: en-US
To:     Muchun Song <songmuchun@bytedance.com>, akpm@linux-foundation.org,
        zi.yan@cs.rutgers.edu, kirill.shutemov@linux.intel.com,
        rientjes@google.com, lars.persson@axis.com, ziy@nvidia.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        duanxiongchun@bytedance.com, fam.zheng@bytedance.com
References: <20220208073617.70342-1-songmuchun@bytedance.com>
 <20220208073617.70342-5-songmuchun@bytedance.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20220208073617.70342-5-songmuchun@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnJhSFpDN2pHMGhhYXVSNEpDbDh5NUFmUFdKM2R1Ty9ZWlUyZ2RicktBaUdr?=
 =?utf-8?B?bTdGUTRuRk1hYmpTMGRTWHp3alVkTlhxWjNORlNJTDZQZkloanJmWERrUVZn?=
 =?utf-8?B?RnRlR1lxdUdxUDFwek8xd3hiazMwTTgzNEQyNkIvTUtmM09YOTY3cGs5bVZj?=
 =?utf-8?B?bi8yVnBtbXA1T1p4aitLTzcvWE1YLzFvZWdrVWxTYStCT3lFclhZVy9uZXR6?=
 =?utf-8?B?am5QdHhUZWk3bFdoZXNsYUZ5TDJpcXkwOVlTRjN4UnM1bnk5TEVTMlYxcjRP?=
 =?utf-8?B?OHNKNm11NDBJZ3k3M2ZXd0Y3SmlZSU0wbnVjWUN3RUxQZk91LytYODJnejUy?=
 =?utf-8?B?TU9YSG9JQmtLZmtsY3daOUQ1WjBFTllYL3BGekRpSUx2NEFFOVM4VkwzcDRu?=
 =?utf-8?B?dVVvQ1grN25jOGdxSkZ2ZlRxVkt6bDJOZ0ZOUjc3cmJjQ1BhR1RSdE44WWp4?=
 =?utf-8?B?T05jdk1Uck1pa1F6OHlvaGIra1VXL0EzRkxtZWJheTVjWnlPdTYyR1R5VTli?=
 =?utf-8?B?dlUzTWxlWEJUQXppbnVqNmdSSzM4S01PZFY0L2N6TTcrQlBOcGx1TnUvWU1P?=
 =?utf-8?B?OGZRVzNIVjhONHV0N2hWMnpGZWh2UUZDamZHUWR6bGFJbGptT1VhcTJmNDRk?=
 =?utf-8?B?VFIxOHpCY0ZwTFY1dHlYNVBOZ1V5bldsL05hT2prTFNCZUJJSWpoRm9CRWV0?=
 =?utf-8?B?UUI5MDFsLzBQNTFOREN0RzRtb1hsOEZtdGRvZFZkaTBKZGZaQ3liV01adTNQ?=
 =?utf-8?B?T1FzenAzclo0OWN3ZlQ2MEJ0V1JVcW1tbmgzeXdVWHNBdFhXU2swSkErTmdx?=
 =?utf-8?B?bWtTeVlDUkhUOUI2dG1YU3JLQ0xLZk9kWjFjc0xYZ2ZIVUxRWDlzb1ZPcXYv?=
 =?utf-8?B?NXhBUVM3MEFmM3Zoek9QUlprc1Fabnd2S1NhNThaRCt0VHB4R3NzUWFXaVlO?=
 =?utf-8?B?VXpJVXNWMXJWV3ZHOFNOeHBvZTdVaE0wSUp2WmZoOUhSa0dKemExd2loSTEr?=
 =?utf-8?B?NWovU3FxK29yYk01aXRwcTRDR3h4VTV1a3dLM05uQjFaUnlQSlJQaXU0Z0lQ?=
 =?utf-8?B?MFc5QXlxNlhNaHB3cGlGZjNUMWtLT2szUERZM3Qrc0hRUHZjbll2bVNhYzRG?=
 =?utf-8?B?bjMrdGx0WGZXejV6bmliQi9iMS81TWhNUzZwc2h4YkdkVXNvNVVuRUNRcUtG?=
 =?utf-8?B?UElnU0ROWUpJY1RidWw3V0dFRDVuQ01pa2E2bVBoSmRERXpBR29iY0hORXRu?=
 =?utf-8?B?akdpT0p0anpSRkQzS084c0d5QWlVaTI4YlM0TXg5ek5pTHdGQlJ6ZTdaQ1hZ?=
 =?utf-8?B?MTByZ0RsYVA0QzNRbWU4NjUxY0JYdlJOYXVpdXN6VTFENnBUQkZnSFFEQUdB?=
 =?utf-8?B?Z0FlaUxZc2J6TGVLWkNOWnkrK2NTV3pLamRyRWxVY2NhK1RvczVLbWNMMWZn?=
 =?utf-8?B?THNyVUFiaDFMVHhDNkM3bHp3a3BPWC9nazNUc2NZNktmSitQVVNpS0QwK2hE?=
 =?utf-8?B?RG41WGJycWVoQ0F5dmpSeG82eHVXeTJZYjZ4WktRNEdWamJBMkt2NnFEQkwv?=
 =?utf-8?B?OEZteXZXYXZERkZtRUVId1ZFR2tGcnlQWmlleHEvVG5aRlQ1RFQzL1ZKZkRz?=
 =?utf-8?B?NWUva01UR3J2U0VLT2NidHdDVVZkTXlnYlpNUWhQYkpMQ0ZaeHFYUUZjQkN2?=
 =?utf-8?B?WGRSU3dleDNkalNMK29iR0V6eFh4MmFucm1DZ3dsVXMvR00vaVhPVWM5SmxY?=
 =?utf-8?B?amFtQ2dhOHYrZmZCTWJnTDNLZlFwKzlGRVFtS2lWSWU4UitkUVhIcmM4bTNy?=
 =?utf-8?B?MXNFclllR1NtVE93QVcyU1A1dGdWa2l6cFBnb0YyVWZEU2xSZEtOejNLTUwx?=
 =?utf-8?B?Qno4cWZ5c1BxWGVzak1Oa3hYZFVPMW9FSFZ3VlpxWC9BOXFPb2lkeWoyeG1P?=
 =?utf-8?B?L1JITlkxYWlSUUZoUExpZVVRdXhkRy9WbTRVR3NtRTVUNlZYNUk3SGZ4ZGln?=
 =?utf-8?B?QVVWM2N5ajJMS3k4ZytGc3FLODgyQ1RGamJORHNVTnphcGZIWHNrK3E1ZEFJ?=
 =?utf-8?B?eG1TUjkxQ2lscVBqZ0dTa2ErRUlQVWpuOW1NcDFpNjRkL01IUXlXWjVtL1FK?=
 =?utf-8?B?ODhJNUhPdFpjWm9peDd2amJUVk4zSWREeWFwTm1jcW82eDUvMFdsMDh3UExI?=
 =?utf-8?Q?FJYDb7nY0eVqvMtg/OOIgWA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d40aaa40-6b74-4277-8a9f-08d9ebfe4941
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 18:59:23.5388
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xUilNjv1dUD5qQ0BVsUy1le4TpJiPXJRGfO9+oXSuvrTSkG96fqfQMGxkAIQep+cZL5jNXyBu36pQP/K7L+I1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2885
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202090100
X-Proofpoint-GUID: D4lFvOQ9tOo2MREcfTtCUHnPSEGxYQUm
X-Proofpoint-ORIG-GUID: D4lFvOQ9tOo2MREcfTtCUHnPSEGxYQUm
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/7/22 23:36, Muchun Song wrote:
> folio_copy() will copy the data from one page to the target page, then
> the target page will be mapped to the user space address, which might
> have an alias issue with the kernel address used to copy the data from
> the page to.  There are 2 ways to fix this issue.
> 
>  1) insert flush_dcache_page() after folio_copy().
>  2) replace folio_copy() with copy_user_huge_page() which already
>     considers the cache maintenance.
> 
> We chose 2) way to fix the issue since architectures can optimize this
> situation.
> 
> Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY")
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks!  This will also make backports easier.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz