Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, hdanton@sina.com, hch@infradead.org,
        stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com,
        sgarzare@redhat.com, virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH V8 3/8] fork: add USER_WORKER flag to not dup/clone files
Date:   Wed,  9 Feb 2022 17:29:34 -0600
Message-Id: <20220209232939.9169-4-michael.christie@oracle.com>
In-Reply-To: <20220209232939.9169-1-michael.christie@oracle.com>
References: <20220209232939.9169-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uncSZwZsNt4+aix0p6vEIaFIcdPzH/+6f83fnzurl0ACcCxqrebTK/FimsOV?=
 =?us-ascii?Q?xiWUmblGF/AADmdNNSUOcaJJtaOv394Rmcvq45jwNDV+isnFPtirmSNc2BRX?=
 =?us-ascii?Q?nJwgtbmpaTuRahlWM4x36AeBEU/VS8X1mnHpjD4T3CXPeODU8z8lf/rYiCnF?=
 =?us-ascii?Q?Rvie/8u2NbKdf4SdOO7ikPpvSPdxz5Z3YQ0r9Y00kV+4o5p+C6OjGeDT0VJZ?=
 =?us-ascii?Q?U8ty24ZRP37zbKuiUF5KqO4K4XQx6bQccN93Gk0bKvgtPs9Bvn9lkPRl1MT+?=
 =?us-ascii?Q?MQ9rnsuL/zIYfNmx3C2kzqzmcgWMpiGk+QsMNl7fkAXTJ3U92qpQ3PFPySWl?=
 =?us-ascii?Q?AYTyZRDRL5rMcLUMSc88WO+fDFT5CLgfON7IOCev5OSNX1dkX6eLbCjUqmzS?=
 =?us-ascii?Q?beTAJtVU+YlOF9e1cXRbXRrp2jJMBU1M9uoFRDmfjGXIUEHqPHlanXO3UbhU?=
 =?us-ascii?Q?J2RrzUcMbBPxaceB4QuO44JFIlR1VQD0O6WXJ/+u3L+npFv48JZmGNcvVoLp?=
 =?us-ascii?Q?SoTMvsK4yyOpA2h9Pz6KpZEHzt6M/jyGMsptfgfcHL2Q27V9XB2YE5KYGmTE?=
 =?us-ascii?Q?wBjukLBqoZ/HL35LZGxXrVOgePjBXg89N/3XKMxokSTxloA8QsAMx56HdZ5E?=
 =?us-ascii?Q?ZbZ4EJwfA1oV7XzKa29NIz8Y/CegzDVH0Hz1YgHAm3htNj+0DXzhVzZkQni4?=
 =?us-ascii?Q?AQ6ZV5lQH3pMCNSZOYK3ZeC9/fm3sWMsnqDLgbOn1/zqDQ43sYZCDxZEpwEZ?=
 =?us-ascii?Q?U+WE6cAxXmtaINHvJ0CLtmYt9hbl93NWfx+aXkgiBDj9sCAZYSp0QTWguHdi?=
 =?us-ascii?Q?G3yKln49EdBZPx1xqtzHE08nF3iHdvFH0Ye87dV6R6DKdxE80RJHMWY81U61?=
 =?us-ascii?Q?yo5egxAKkyVDgiAbrRcFW+Junq9BPrO3cMbeLNOmAoyxxp5QvFkRl7xugtqv?=
 =?us-ascii?Q?xTTf2RqIrLGQQDWCgoRDPjHJ4ujTp24fJC24h14dUWYZJPcaUyVLRF90KPvC?=
 =?us-ascii?Q?nYxfm3VLg1fnb2+mUOSBXNyQHqWpjUoAFrh8yc8wFpLW5swsaKp6jhwHoCMG?=
 =?us-ascii?Q?579RjLMEAQ7m9k9Q/Qqn/Ca0ME24Yl2QsQAyC1nSgOTqnJ0ckS4LP/TVM9TI?=
 =?us-ascii?Q?0N+BwywBybSSJ+ZxJ62S+cOsZKprVs5b1j3BW03FGdnxwFzmu6swmXl3nbmq?=
 =?us-ascii?Q?9GT4pQMt9BUEk+SkjLwxhcRsFDqcV/WhBBcQtfmNbrHiFB0oq8/FNs4FUbhu?=
 =?us-ascii?Q?D4QNdUB+SOrts3Y0oAk3nr2w79LO8vD4KUCCDzhxxMymAR+TA30Kdnpq/dUb?=
 =?us-ascii?Q?yRUtr2QNehTt8bhj4nSL9Zwuh1GZTCzTiTT9KBkretkFJkK7aV2IfHcmoJle?=
 =?us-ascii?Q?9qUmuIKLbtkU+X7Z3Pub8hTOTZxinD8lFW94bv/3bJgQHCytzyiGIDjSq2yN?=
 =?us-ascii?Q?91ZpxKRQkITVFyf0AQnGYOF2xmfnGMxnMTYCV3gUKVCWGNgxqpP4hFB+3mVW?=
 =?us-ascii?Q?LL/6mo+cxuK/zH1f5qJDkHkCBZGijp+IucTWe826709qRybVZHRoOQH+5XAK?=
 =?us-ascii?Q?J9kPRkyEP1IynOPWuWKWD9dUkYJAZEA7o6BicAEl2LC2kSipOpAU4U5n8acR?=
 =?us-ascii?Q?c87gI03dwXPMRNIvpwt1i2XdpB+Tr98O0ZV28qRbHnbK+mLEORrZv53x3NoE?=
 =?us-ascii?Q?jcVInw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fbf2a44-b044-4f17-8673-08d9ec2411cc
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 23:29:51.2479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y/herNsvyAr/Nz1u/yu2n6ZcXSawpb/4lLAmeCrZfDxcyTDOmecBeWGRsM3b2jTCps/Jw6ZD31sqtjoDTcrwNUjDysplqBBJKcJhTMIQHZs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3007
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=947 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202090122
X-Proofpoint-GUID: zJUb634q_kYtQMjk3PEFumu2YUIXtJfu
X-Proofpoint-ORIG-GUID: zJUb634q_kYtQMjk3PEFumu2YUIXtJfu
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it creates a thread using a helper based on
copy_process we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 0467b3ce1c94..706ca3dc3423 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define USER_WORKER		BIT(0)
 #define USER_WORKER_IO		BIT(1)
+#define USER_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 1f6e7184b31f..81a1096d6ee9 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1530,7 +1530,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1542,6 +1543,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2153,7 +2159,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & USER_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1