Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <fd4a237e-7494-9bd5-1952-164c22896c43@oracle.com>
Date:   Wed, 9 Feb 2022 14:48:51 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v7 0/5] Free the 2nd vmemmap page associated with each
 HugeTLB page
Content-Language: en-US
To:     Muchun Song <songmuchun@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Oscar Salvador <osalvador@suse.de>,
        David Hildenbrand <david@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Matthew Wilcox <willy@infradead.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Xiongchun duan <duanxiongchun@bytedance.com>,
        Fam Zheng <fam.zheng@bytedance.com>,
        Muchun Song <smuchun@gmail.com>,
        Qi Zheng <zhengqi.arch@bytedance.com>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
        Barry Song <21cnbao@gmail.com>,
        "Bodeddula, Balasubramaniam" <bodeddub@amazon.com>,
        Jue Wang <juew@google.com>
References: <20211101031651.75851-1-songmuchun@bytedance.com>
 <CAMZfGtUeL45=WG3ceaZ_tALMGZTLtuD9jbfKEzeQv270OnaLYQ@mail.gmail.com>
 <35c5217d-eb8f-6f70-544a-a3e8bd009a46@oracle.com>
 <CAMZfGtW=e___8kpe1B5a1rK+SV63bP_Nwucj89QKaX4ZOMUpaw@mail.gmail.com>
 <CAMZfGtV0JKcjVL0qGoYCQJ-LsXdng7Z2UjBym5hf_WM0LcYi=Q@mail.gmail.com>
 <20211123190952.7d1e0cac2d72acacd2df016c@linux-foundation.org>
 <CAMZfGtW+DoKp_gCcPSy33Urc86A58rRp8HJ+-GOuW9vFP-BwxQ@mail.gmail.com>
 <CAMZfGtV-ODDGQ6dUuo_eSEDn2kDSiUjNDc=nyFwoRRSxNLsTeg@mail.gmail.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <CAMZfGtV-ODDGQ6dUuo_eSEDn2kDSiUjNDc=nyFwoRRSxNLsTeg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXk2cllwajF5ay9MMXJqclVzWktIVFI1RzNBS0FJZ29yRUdlcG5PMVhzTjEx?=
 =?utf-8?B?eE5iMmtyWnVRd0RDZVFEMmcvNUk0SUdmZ1FzT1JJc0FhZkJoL0lueEo4WXB5?=
 =?utf-8?B?QTl3MmgzZXlwWi9WSUdveUJhMFhUcExuS3dyeTZQeWo5SjBwT0tsQWNiamFV?=
 =?utf-8?B?QTdGMmNrMGo5NUVYanlONXljcE01Vy9sNFdwYm1NMXVjcTFkSXNFM2h2Zjdt?=
 =?utf-8?B?Sm5IS1JWR2U2dW9wLzVnUXpXa3krZ1lqUlRMc3BoMUk3bENwRW1CNWxHY0h0?=
 =?utf-8?B?dFM3MVorNzlXNGg5dzdYQVg1dU1TQUFQUU5FTGZqa3J5bFhaNGRTd0JuMVdO?=
 =?utf-8?B?TzFOaFZvWVFpNVp4WUExSW5STlE0T20rMEV4UFpHWHRFckJ6WjIxbUIwVXdF?=
 =?utf-8?B?K3ZCZDE0VWRnOVBvcmpIV1B1bjdneW03dEYwbWNFclNNa3plZExKT2lKdjFD?=
 =?utf-8?B?YWF3NWxReFlBcmJoaXNqRmRWNUkzS2FlNUszb1NRWHpVUzBzUmxvSGZwLzlo?=
 =?utf-8?B?ejh1QW9wMU1oc3B6TkNNaTh1SmFZbVNhS3crRktHbEtZR2doRlpwNE1JN1Q1?=
 =?utf-8?B?NVdRVlo5WVJnbUF4TWhrUU4xMkpPYWtIeS9qd1J4Vjh0V050VFFMcmIzb1RY?=
 =?utf-8?B?bUMxeG56bHhidnFIamN6N1lVQm4xUmh1eXpHRzFBejEzL3U0cUY0dU1ERjdp?=
 =?utf-8?B?RnAwbjJ2RWcrNWxJRW5KUnUxWVB4YjNxdmhzNFh1WStVNmFoS0pmdEhXcXlI?=
 =?utf-8?B?T3RQRTZ1cUw4RTBLTEZQTWJOQ1VCZjhaTzBvTUt2b3VmWHM2ejhVWjZadExD?=
 =?utf-8?B?Z1lNN3doWWdmMTJjYTNjSHNqcGxldmxwVVh1bjl1dFJXRXlUT2dHK3dleldE?=
 =?utf-8?B?MndDQVR5OFBHaWN6ejh2Ni9CZ2JzRnNXU0tmYkxVR1JpL3ppczk2Vm9WYXpP?=
 =?utf-8?B?UE41UmJrYTlXODNxNnBQYUtlUGFmWi9aVWEzME1USjBvMXV1NWMramJRRUxn?=
 =?utf-8?B?Zk1oZHQzWWd3UTVlSDRFc3JldHhEOWxqRWhrU2t3RjRPMy8rV1g1MHJUZDJj?=
 =?utf-8?B?QWw5ZnhGODBJTVhwenN4Z0owQzZsb1Jwdnh6Tys0eVlqazd4Nk9YczRVbDhu?=
 =?utf-8?B?QjA1RVN6cFlJM1NNaUVpSXdQNVB6NlFxbzRaTHdnZXF2cUhjeFE4U1QwZjFY?=
 =?utf-8?B?RU82REthcTB0UHVSUVhNdVZnekFEcTQ1YlVsMmdDeHl1NTV0T09mcmo2ako0?=
 =?utf-8?B?KzAyV2pTSm9vcHNQVWxBdkVJbDdOK1lYeEdzVE9RZmEweW5PV3ViVGFxZ3Ni?=
 =?utf-8?B?MGJMb1Q3V2NUMmJSTVczTHhjd2tuQmNzWmhndEhoTHJzeW13WWd1eWVmTDRI?=
 =?utf-8?B?MnJFV2d3OVdPejVSMzVTNkttZnlpbkYrQXhGcWpYUStUazVxbDRnMXdaelVv?=
 =?utf-8?B?VUxRMTNvS0NLc1ZlYjkxTUhDVlVZVGMzTTcxdVk1T1RibDEwTTVVclBjMFNh?=
 =?utf-8?B?SEN6eVora0NUVThFTWlrYk9xeVR2a0pvNFBNaEZNelpBVVBBNjBWT0VFM3NY?=
 =?utf-8?B?ZmFPUk9EbHI2VkZlRXFyTExKRlVEbU9naGhYRGs4K3V0S2REdmlJOVVDY29u?=
 =?utf-8?B?eC9EYUs4VnVsdXdHOTgvUFJYSWRmdDE0Z1diWG4vUVpSb0ZHNEFYNm96a2dr?=
 =?utf-8?B?WkE4UXF3ZXNYaG9zWWpVMXJwZnFJSWNhSDJseUxXVWFGOTBlbTBRVHhMeUlV?=
 =?utf-8?B?Qm83VGU4aGVkUE5Kd1VpTUYxYk1oM283Vm9ST2xpR2VONVN4Y1FIcVhxT1ZS?=
 =?utf-8?B?eEJoK0djZjBNaklmU0JxUTFDZjU5VnFVZEpGNkJhRTdyd0NqWHMvT1o0YS9v?=
 =?utf-8?B?MFJ6alcwZkt6bmxMSzY1c0Q2OTNMOXg1WDhoWUwwdGVVQmNpYUVrZGVNNURL?=
 =?utf-8?B?dHlzUzdzNVdlRWlBc2x2Y0trMUhuMlZCa29hR1dkTEJTbHY5dm1uNDNGazJ0?=
 =?utf-8?B?TnhiM2dLMlRHQkJCakQyajVEUGpSZ0ZIbEVKZDJBQW5HRVpCQkI2SHkydkhX?=
 =?utf-8?B?WkZSaDNTdFlzZ0lSeE9YSUlkTjFMeXZRV0xrM0dFOVg4ZnlvRW16bW45Y3Z2?=
 =?utf-8?B?T2RPc08zZEUwY1VFdEVMSEFpNXQ5c2dFS2lpQjMraDhUSEJsSzE5YUNLSCs2?=
 =?utf-8?Q?tB//7sc+b/7xf3KJpqPLG3U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 208111fb-40df-4f22-c94b-08d9ec1e594f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 22:48:54.4179
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9b9Jc4+a5KMloZMSpa26Ktjt0+iW11kcVpZegrE1is4ZdJ7lbKM0N7jaHi/xXD9PVr9Su8G6JDHqV7XE9ikemQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2384
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202090118
X-Proofpoint-GUID: tzsQlv_gsMos4mFp-7Hf1AUa0DGts-r7
X-Proofpoint-ORIG-GUID: tzsQlv_gsMos4mFp-7Hf1AUa0DGts-r7
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/8/22 23:44, Muchun Song wrote:
> On Wed, Jan 26, 2022 at 4:04 PM Muchun Song <songmuchun@bytedance.com> wrote:
>>
>> On Wed, Nov 24, 2021 at 11:09 AM Andrew Morton
>> <akpm@linux-foundation.org> wrote:
>>>
>>> On Mon, 22 Nov 2021 12:21:32 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
>>>
>>>> On Wed, Nov 10, 2021 at 2:18 PM Muchun Song <songmuchun@bytedance.com> wrote:
>>>>>
>>>>> On Tue, Nov 9, 2021 at 3:33 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>>>>>>
>>>>>> On 11/8/21 12:16 AM, Muchun Song wrote:
>>>>>>> On Mon, Nov 1, 2021 at 11:22 AM Muchun Song <songmuchun@bytedance.com> wrote:
>>>>>>>>
>>>>>>>> This series can minimize the overhead of struct page for 2MB HugeTLB pages
>>>>>>>> significantly. It further reduces the overhead of struct page by 12.5% for
>>>>>>>> a 2MB HugeTLB compared to the previous approach, which means 2GB per 1TB
>>>>>>>> HugeTLB. It is a nice gain. Comments and reviews are welcome. Thanks.
>>>>>>>>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Ping guys. Does anyone have any comments or suggestions
>>>>>>> on this series?
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>
>>>>>> I did look over the series earlier.  I have no issue with the hugetlb and
>>>>>> vmemmap modifications as they are enhancements to the existing
>>>>>> optimizations.  My primary concern is the (small) increased overhead
>>>>>> for the helpers as outlined in your cover letter.  Since these helpers
>>>>>> are not limited to hugetlb and used throughout the kernel, I would
>>>>>> really like to get comments from others with a better understanding of
>>>>>> the potential impact.
>>>>>
>>>>> Thanks Mike. I'd like to hear others' comments about this as well.
>>>>> From my point of view, maybe the (small) overhead is acceptable
>>>>> since it only affects the head page, however Matthew Wilcox's folio
>>>>> series could reduce this situation as well.
>>>
>>> I think Mike was inviting you to run some tests to quantify the
>>> overhead ;)
>>
>> Hi Andrew,
>>
>> Sorry for the late reply.
>>
>> Specific overhead figures are already in the cover letter. Also,
>> I did some other tests, e.g. kernel compilation, sysbench. I didn't
>> see any regressions.
> 
> The overhead is introduced by page_fixed_fake_head() which
> has an "if" statement and an access to a possible cold cache line.
> I think the main overhead is from the latter. However, probabilistically,
> only 1/64 of the pages need to do the latter.  And
> page_fixed_fake_head() is already simple (I mean the overhead
> is small enough) and many performance bottlenecks in mm are
> not in compound_head().  This also matches the tests I did.
> I didn't see any regressions after enabling this feature.
> 
> I knew Mike's concern is the increased overhead to use cases
> beyond HugeTLB. If we really want to avoid the access to
> a possible cold cache line, we can introduce a new page
> flag like PG_hugetlb and test if it is set in the page->flags,
> if so, then return the read head page struct. Then
> page_fixed_fake_head() looks like below.
> 
> static __always_inline const struct page *page_fixed_fake_head(const
> struct page *page)
> {
>         if (!hugetlb_free_vmemmap_enabled())
>                 return page;
> 
>         if (test_bit(PG_hugetlb, &page->flags)) {
>                 unsigned long head = READ_ONCE(page[1].compound_head);
> 
>                 if (likely(head & 1))
>                         return (const struct page *)(head - 1);
>         }
>         return page;
> }
> 
> But I don't think it's worth doing this.
> 
> Hi Mike and Andrew,
> 
> Since these helpers are not limited to hugetlb and used throughout the
> kernel, I would really like to get comments from others with a better
> understanding of the potential impact. Do you have any appropriate
> reviewers to invite?
> 

I think the appropriate people are already on Cc as they provided input on
the original vmemmap optimization series.

The question that needs to be answered is simple enough:  Is the savings of
one vmemmap page per hugetlb page worth the extra minimal overhead in
compound_head()?  Like most things, this depends on workload.

One thing to note is that compound_page() overhead is only introduced if
hugetlb vmemmap freeing is enabled.  Correct?  During the original vmemmap
optimization discussions, people thought it important that this be 'opt in'.  I do not know if distos will enable this by default.  But, perhaps the 
potential overhead can be thought of as just part of 'opting in' for
vmemmap optimizations.
-- 
Mike Kravetz