Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 9 Feb 2022 16:01:02 -0600
From:   Rob Herring <robh@kernel.org>
To:     Tony Lindgren <tony@atomide.com>
Cc:     linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        linux-omap@vger.kernel.org, Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCHv2] dt-bindings: clock: Add binding for TI clksel
Message-ID: <YgQ5no/7cEW4yRrM@robh.at.kernel.org>
References: <20220203073929.59296-1-tony@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220203073929.59296-1-tony@atomide.com>
Precedence: bulk

On Thu, 03 Feb 2022 09:39:29 +0200, Tony Lindgren wrote:
> In order to prepare for fixing lots of devicetree unique_unit_address
> warnings for the TI clock nodes, let's add a binding for the TI clksel
> clocks. This allows us to move the overlapping reg properties for the
> component clocks to be children of the related clksel nodes. And with
> that we need the reg property only for the parent clksel node making
> the reg property unique like it should be.
> 
> We want to set #clock-cells = <2> in case we ever start parsing ranges
> of clkcsel instances directly using a clksel driver rather than using the
> existing component clock drivers and child nodes.
> 
> And before the devicetree files can be updated, we need to update the
> TI clock drivers to get the IO address from the parent clksel node.
> 
> Cc: Tero Kristo <kristo@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> 
> Changes since V1:
> 
> - Set additionalProperties to type object as suggested by Rob
> 
> - Changed #clock-cells to 2 for parsing ranges of clksel instances
> 
> - Updated patch description for more info on why this is needed
> 
>  .../bindings/clock/ti/ti,clksel.yaml          | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml
> 

Applied, thanks!