Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Victor Erminpour <victor.erminpour@oracle.com>
To:     davem@davemloft.net
Cc:     victor.erminpour@oracle.com, kuba@kernel.org, bpoirier@nvidia.com,
        l4stpr0gr4m@gmail.com, jiapeng.chong@linux.alibaba.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        trivial@kernel.org
Subject: [PATCH] net: mpls: Fix GCC 12 warning
Date:   Wed,  9 Feb 2022 16:28:38 -0800
Message-Id: <1644452918-576-1-git-send-email-victor.erminpour@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HHAjB5MVbGtdTAYEyNVNVG7vOommo3ZGpOcsvvA0Ta3M++fSeJmmsSjIjtTX?=
 =?us-ascii?Q?hpXow0SP6tZ2NwFwSI8kVJ/UDZRjJEiECtnDSVPwAFUukfiIvFOzhSchhKos?=
 =?us-ascii?Q?5BBsSkxBzp76HbgZv8sMRQunHaQSPqeTGi4v5UsrxA01zgrHXpuDnkNhmCyM?=
 =?us-ascii?Q?I/ZUyn75sOV/ovmXyrJhUE5WUXrcWv2U/+JHPDFSQvG3dmXyXHBNx6x5PZfO?=
 =?us-ascii?Q?5P+u/JJxNIkRYKMBaLtkBDoN85hUq2DVpyoQWsGIs2HDtPdDOSJMSsF8B+Lu?=
 =?us-ascii?Q?Qrbcufsrz1bioj4blZGSTp8inOWxkOBce6M7Ga74sIVFqW7w/BqzIcK9NEY6?=
 =?us-ascii?Q?BeDowyGwoV2YjTprgA+BNkxC82XT6o2/Kxb2kbAWvHWKRYZ+0lcQCPv0uYEL?=
 =?us-ascii?Q?LMVTyKalU303P+gH3a9lEk8myai5KZxT46b3faz1hw8XvMnISY3OtLtOfatw?=
 =?us-ascii?Q?zKo0iHe1u7Wo2fsZXyt3c46Am4hYfH5Ydpju7cdp2qZOsCe5G/HznOkQ63BY?=
 =?us-ascii?Q?RaCB3CJac0AAcs0WVRx1GY6+Ihc+0pIpMvDpD4FktQuTQmkRnvNZkesoZg+S?=
 =?us-ascii?Q?iAXu5dep5ZYAycamv8suWU7A+WOvyctejHMFB2WNWK7Crn57VSirAiRKLEWX?=
 =?us-ascii?Q?MsKprtnwp0I5eMM/W5j1n5iTnmtyJ5CwJSlXWCFlQyVNlimQ/UzDl16qdooG?=
 =?us-ascii?Q?9kYp+bcURDf5pZ/V/efv8jl9/0gpPXikXSsvxCIUTHc59SONvzfs2PtPrXOe?=
 =?us-ascii?Q?VXDOWr3JjAmeVKm3Zx5MepLMGuvuTjusDJ+F/VBD9RMMCCLO1Fd9om7yKfqg?=
 =?us-ascii?Q?DlI4fNw23rr+8ZDMME14lBS2U2cHZZQBJHxcBQ6qzoFkAC92lxq0bcqwXtQy?=
 =?us-ascii?Q?X9lCIzjphGoDUt/l3V7sb1Trl3X92WHzAogZlkrddmytJ4g6Ii2fMbcjhYw8?=
 =?us-ascii?Q?+tcjGcpY5lSJhuwy1nbr17SdOvZF+G8uQUjsB52otWW+TX6C13HcI15LJZiA?=
 =?us-ascii?Q?JHbZnIxvvOviWCRD6lABINRiLjzUSZsAsX1AVckq+ddxPnAyctDj+9IWDwRP?=
 =?us-ascii?Q?5GYTVvPWofCE/VeqABiutc4pXr4EcUn48wFQ/0I2TSfNzjIfYCCpPpFNWKqi?=
 =?us-ascii?Q?diiYoQrNY8JscXQK4R0w4YwXLso7CG5EzVPUq2+Mcez+pZ6FclX2Z6PLqHY2?=
 =?us-ascii?Q?UrTbqMC42k2N34iuywR6Ng+YI5DK53b1h/xUrROgrHLcEAqkLBUbHiKmS8aW?=
 =?us-ascii?Q?XNE4MjxSvdHjJwlC0A3SfOhb7JgARtv3pN5dWNuhoAICHJMkLWXEHRHWHCGY?=
 =?us-ascii?Q?PRq/kH4HFrDTAbUuI4tHshGoSxZJOPROEFotJEydO15B6NeZHxzSecoU+Vg2?=
 =?us-ascii?Q?KRYHek/IsaH+7JjXizJhTTGFzt8SGJdBTknu+Ue9idZGyKJE+56f9ft/nYjV?=
 =?us-ascii?Q?a0oefeU4ihTdmHH4DiMdC6+ZWxmwd8xzYygTiR97oUCvgsdR3nb+pb3IVZpf?=
 =?us-ascii?Q?6L3KZIR+hDLGHcNMUA9OejIDlOVsNLxy6Gh/GiubEbNcS2cYKYQ6Q9BXigES?=
 =?us-ascii?Q?jDM3xdi3vdppaNstKmCnOKNACFucDvHtErdwINYZxmaOSANms3wEAJ71Cz36?=
 =?us-ascii?Q?5xMh4WpqBaBq4U8sgpgVDZYBgesFrPO1iuR5zqKSPPqAp62x2DpdNQD3f96c?=
 =?us-ascii?Q?+YsUaQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 118e9d32-29fa-49a5-a802-08d9ec2c4c64
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4472.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 00:28:46.4004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pi60mDKbNtG+4WEqVPLjcbjT8jF0SBzZZqJ4KoD+laHXVrM3VwuPA6/nGfSiLuLgVE1TNEhOiZbpPalwVhGXSdyqcZdUxFEcDOSRe74i8Ec=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2701
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100000
X-Proofpoint-GUID: hwIxjDIYBqpZT3Ya9XdRCRjTbwrafDUJ
X-Proofpoint-ORIG-GUID: hwIxjDIYBqpZT3Ya9XdRCRjTbwrafDUJ
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable outside the switch, which silences the warning:

./net/mpls/af_mpls.c:1624:21: error: statement will never be executed [-Werror=switch-unreachable]
  1624 |                 int err;
       |                     ^~~

Signed-off-by: Victor Erminpour <victor.erminpour@oracle.com>
---
 net/mpls/af_mpls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 48f75a56f4ae..d6fdc5782d33 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1607,6 +1607,7 @@ static int mpls_dev_notify(struct notifier_block *this, unsigned long event,
 	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
 	struct mpls_dev *mdev;
 	unsigned int flags;
+	int err;
 
 	if (event == NETDEV_REGISTER) {
 		mdev = mpls_add_dev(dev);
@@ -1621,7 +1622,6 @@ static int mpls_dev_notify(struct notifier_block *this, unsigned long event,
 		return NOTIFY_OK;
 
 	switch (event) {
-		int err;
 
 	case NETDEV_DOWN:
 		err = mpls_ifdown(dev, event);