Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 9 Feb 2022 15:44:41 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc:     "hpa@zytor.com" <hpa@zytor.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V8 13/44] mm/pkeys: Add initial PKS Test code
Message-ID: <20220209234441.GO785175@iweiny-DESK2.sc.intel.com>
References: <20220127175505.851391-1-ira.weiny@intel.com>
 <20220127175505.851391-14-ira.weiny@intel.com>
 <1ac1daf90285869ddfdf52daa8d39bc462253883.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1ac1daf90285869ddfdf52daa8d39bc462253883.camel@intel.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Mon, Jan 31, 2022 at 11:30:14AM -0800, Edgecombe, Rick P wrote:
> On Thu, 2022-01-27 at 09:54 -0800, ira.weiny@intel.com wrote:
> > +static void crash_it(void)
> > +{
> > +       struct pks_test_ctx *ctx;
> > +       void *ptr;
> > +
> > +       pr_warn("     ***** BEGIN: Unhandled fault test *****\n");
> > +
> > +       ctx = alloc_ctx(PKS_KEY_TEST);
> > +       if (IS_ERR(ctx)) {
> > +               pr_err("Failed to allocate context???\n");
> > +               return;
> > +       }
> > +
> > +       ptr = alloc_test_page(ctx->pkey);
> > +       if (!ptr) {
> > +               pr_err("Failed to vmalloc page???\n");
> > +               return;
> > +       }
> > +
> > +       /* This purposely faults */
> > +       memcpy(ptr, ctx->data, 8);
> > +
> > +       /* Should never get here if so the test failed */
> > +       last_test_pass = false;
> > +
> > +       vfree(ptr);
> > +       free_ctx(ctx);
> 
> So these only gets cleaned up if the test fails? Could you clean them
> up in pks_release_file() like the later test patch?

Not a bad idea.  Although if someone is running this they are most likely not
concerned with it.

> 
> > +}
> 
> snip
> 
> > +
> > +static void __exit pks_test_exit(void)
> > +{
> > +       debugfs_remove(pks_test_dentry);
> > +       pr_info("test exit\n");
> > +}
> 
> How does this get called?

Left over from when this was a module.  Thanks for catching.

Ira