Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Feb 2022 18:01:13 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     patchwork-bot+netdevbpf@kernel.org, Qing Wang <wangqing@vivo.com>,
        dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: cavium: use div64_u64() instead of
 do_div()
Message-ID: <20220209180113.3b3f0f5d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <056a7276-c6f0-cd7e-9e46-1d8507a0b6b1@wanadoo.fr>
References: <1644395960-4232-1-git-send-email-wangqing@vivo.com>
        <164441341163.22778.9220881439999777663.git-patchwork-notify@kernel.org>
        <056a7276-c6f0-cd7e-9e46-1d8507a0b6b1@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 9 Feb 2022 21:01:35 +0100 Christophe JAILLET wrote:
> Le 09/02/2022 =C3=A0 14:30, patchwork-bot+netdevbpf@kernel.org a =C3=A9cr=
it=C2=A0:
> > Here is the summary with links:
> >    - net: ethernet: cavium: use div64_u64() instead of do_div()
> >      https://git.kernel.org/netdev/net-next/c/038fcdaf0470
> >=20
> > You are awesome, thank you! =20
>=20
> Hi,
>=20
> I think that this patch should be reverted because do_div() and=20
> div64_u64() don't have the same calling convention.
>=20
> See [1]
>=20
> [1]:=20
> https://lore.kernel.org/linux-kernel/20211117112559.jix3hmx7uwqmuryg@peng=
utronix.de/

Would you mind sending a revert?