Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2409332pxb; Wed, 9 Feb 2022 18:38:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzL6p01m1ElAyvC6tDoulkQk42KovZwi19LGKQff7YvmEEyuUyv++gHVU5fJYrrqLYEx+uG X-Received: by 2002:a17:902:d485:: with SMTP id c5mr4544941plg.1.1644460689649; Wed, 09 Feb 2022 18:38:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644460689; cv=none; d=google.com; s=arc-20160816; b=nRHheXuBU4gJPNiMNHiSb+9eMUPtThhN/ehbDQYyF1i6OM7XTvRumlVhiXGPglynqY nz/cPk7ZIAVIMY4TE5yN5xAVWF9tuXJx8ySvAQ7Hm7bgx1YR43zkzlSIdVRcKL0LNMu2 /mxPROvW04UCqsLu1PfA4mlAr7djrc3XQsUQd8GHgR539QB2pch/yrlQTaTIQjSkBqCp ++p8cqnfq3TeJi7FDJL7ExJ5JoBWfH5+Vqt/LJLVzIt9yrBlfbSdNaEgBY6Jo+3+l83W xJ90sdtQl06oT/zvUs71/cMuwTe3twNu35ONfgTNyHYu+GLuQ38EKY82CGVREzpblDS9 VDvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=EUJ1/o6NvtML/PtU58yHRBa2wAxZLdaOiVQlGNEqfb0=; b=z5QL0qEdcd1iLcue2uxaHVIkGzc6DEdbAIXOUrpPORjxG8HACIhRhHO985eFhOYH6q F4ljj8CXiZDZOllsgCnK7FubVLqYu5AVj9vqv3+sVaNrETnNCZPTRMjtdsn0yVTxls3f Eljb8+tdBnNdTvcg+djirh5MOTvLUeSfrGGhhj5ClrPICZY5VP9el4Lc1a7ujswDcMEa ClYSJxGgOl3AgwShti4AUzN61nYZrwlvfCF66Vz/BUU6V1cfJkYPhsyDNCPdotzXl7rG X5pmnd+mjEdpixMfxVy6Gf61T9FWMg5EJ/8Ey/wB96AM8lK/xKNOt1r4LFBLAODJ+11k 5xqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V43w39BD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2si641429plo.58.2022.02.09.18.37.55; Wed, 09 Feb 2022 18:38:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V43w39BD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234401AbiBJCAR (ORCPT + 99 others); Wed, 9 Feb 2022 21:00:17 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:60380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234409AbiBJB7S (ORCPT ); Wed, 9 Feb 2022 20:59:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC75728CF4; Wed, 9 Feb 2022 17:36:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60345616D6; Thu, 10 Feb 2022 00:58:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CC71C340E7; Thu, 10 Feb 2022 00:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644454711; bh=mam86/hmxQgJVtMNzGAN4d9yDX7tUd/mNwP63YOf5F0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V43w39BD+F7dgNOypAmevLK7ZC6WIHOc6o8/cF+MhMVC/EVUxmqPQ8vDQHiDCvV/f irB7Wz9NLzP1SlVu6aNFPaBgJOstrhxffUFNNxu7k6VlPF4jCI2nWhjbjGNUgqVs59 ebtdYPEEZynoQ6PT8+hSwJWjYwlc5fpsjIYH4H0CnnVDlaAtitTDvs7nTOHCfqFMxQ qpkZudq2YjYMmvS2UlMID9yAiKRMAJBm1EEhW8XWOyF463eudtGIpR7ye03BHMogZa O0ZqLg7Se1rLLIsOKb1hRR41IA2qmnOTOIdoKeX029kqv7d7sFheCZn05VmNx4roUK t6EIKQRONKUFg== Date: Wed, 9 Feb 2022 16:58:30 -0800 From: Jakub Kicinski To: Cpp Code Cc: Pravin Shelar , Linux Kernel Network Developers , "David S. Miller" , ovs dev , LKML Subject: Re: [PATCH net-next v8] net: openvswitch: IPv6: Add IPv6 extension header support Message-ID: <20220209165830.5f3645ab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20211124193327.2736-1-cpp.code.lv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Feb 2022 12:46:01 -0800 Cpp Code wrote: > > ok, I see advantage of using skb_header_pointer() in this case, but > > replacing all check_header() with skb_header_pointer() would add lot > > of copy operation in flow extract. Anyways for this use case > > skb_header_pointer() is fine. > > > > Acked-by: Pravin B Shelar > > Could this be applied please. Please repost with Pravin's ack included.