Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Victor Erminpour <victor.erminpour@oracle.com>
To:     a.zummo@towertech.it
Cc:     alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org, trivial@kernel.org,
        victor.erminpour@oracle.com
Subject: [PATCH] rtc: pcf8523: Fix GCC 12 warning
Date:   Wed,  9 Feb 2022 16:30:27 -0800
Message-Id: <1644453027-886-1-git-send-email-victor.erminpour@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D7a96bNUJqWI/3xaZ+0QvtcoHjp6N1DjX/plQ75ts4yq1bdcAFOEBBdNcR7U?=
 =?us-ascii?Q?6E3wvX7ndtQyGiaQXbdl5HTtXv9gyMGzd0OMZbdiKnZncLcyR8z+5Ey0PSR/?=
 =?us-ascii?Q?jfOjo5fvQT/3fKHcWFQGpxVYubey0MHMZs84ZCXkbnEC77rQDWKsKMVoig6+?=
 =?us-ascii?Q?ULVFySuq3F88gHVgqBLmHZI67/vYpDwULBOKhDKctbndCyLtEuHpOiV801/4?=
 =?us-ascii?Q?sVdeyePQBYMXRI+z8FYOnyE6fT27oXElTnloDT3dnUnHQpdM7ek3Z50fxMsK?=
 =?us-ascii?Q?iiyZoqeOe2DDVkn/R0cVe/C/0ppz5taCAVmScC4l6NBX23cM8zDcv3KnUDmV?=
 =?us-ascii?Q?i1bnl/7WrkUVW9RoVG/FloH3oifCMqDKlKJ40nM4XiU7q2HcgtTK1Jla9Dm/?=
 =?us-ascii?Q?0kkNt4dk+EMjzDSPskajvzUfFk3/w2O/EaWi9mZr2CWB2vH9wDPfJVa3bkj6?=
 =?us-ascii?Q?eNUz9nhmREr21vgzsGuBlrbnciwHm+sJc/u4EY22JybgWjoRAqvZaPS3eKLp?=
 =?us-ascii?Q?1c/r9j9SFvzw8zSpVzPeXYpX3N061oa3R6WrACTM9Kp/r2tN6iveOvJqinrX?=
 =?us-ascii?Q?nZZJRbAVazR+cE7+46PYR0U+Aeh+OnKUlcpqiQz9HPA1rIZ3a6StsmyG03Yn?=
 =?us-ascii?Q?tsaeDCzNJKwrIY1j8LEDHB1TrCkuSkBA9LxNwQqhN8vaANLU8bB2G+1Ho51U?=
 =?us-ascii?Q?ONVXfZWQFl/EMnolGC1G9mfaRVwB1F+nXyw3goAMc4w4ucY5l2c7qcvSRpdo?=
 =?us-ascii?Q?BrZcmrT6wo22ywmJEtAbU8lNalM8S8300adE2GPBPrgjMuKA7oxkB/1qEIPw?=
 =?us-ascii?Q?5aoqmFF+YLCaug8kNpcX2l6MZPUzPdDzv76kh8P7w41O/MwN0pvxdWaCfjIl?=
 =?us-ascii?Q?YrUlkiWxG5xPRl/DHj+myyl+0/3VtjDOHA26CXoNkcsKnpg/W4QqqvOvKiSL?=
 =?us-ascii?Q?CtwyBfsDEY5FjnKmQ6iPA3vMWjL8EwLu8qu2aJ7nm6hwMETM1WdKIwFP0g/v?=
 =?us-ascii?Q?/KdVa6AnKOIOP9id7mp6EbIU6J3j5tBXekXvActnYwmD7Zb27KQ9MqS/yIuA?=
 =?us-ascii?Q?rpLbRjT0g6wsHPCa8j1w0cPRrtQuPb795m3VhTLWNSVt0OXVBqzfo25kGrAc?=
 =?us-ascii?Q?qqJXYMm0ZWOI90Ct7wNRMT0YFG6n0Kd+oD4pk0XT9TsSRtaQPPL18jWdJr5d?=
 =?us-ascii?Q?8zmov6pmgxxTVMRrcCMKqneoIlKIXTeYG8+BKKpa8/42K/ivQU2Onf3HfBlr?=
 =?us-ascii?Q?jH6MFgS/nrRXgDBdw0NmMxRS0NpnUXeiCtM79hta9JaNOwO8kVVwNUoSunu+?=
 =?us-ascii?Q?aFxkPSRbcJ0hvxrCsPM12wFxwrjW2M6PrnzcvEZyNNBZEfqUDBMUSEVOCER2?=
 =?us-ascii?Q?0OmlUF1AsIvgaCBJPntMddJ52NR84Q5yBWXqCdCRwsYvf34o7YVlBfv4vZdp?=
 =?us-ascii?Q?Hckk9/5iUS1M7gqTBQ6vIxKlueN78+rFjUKA+wOYvQ2Cu4k4NxzEhxTB8L4/?=
 =?us-ascii?Q?5D4g+EZ4uwDhatB1lN56I1JhbJN6JlCTcXMFooKAMfgCn9Qg32jXpQ21uX2b?=
 =?us-ascii?Q?+mfGPa9c1n8cm+kXWJJME8j9kum2A9LBhGR06M7khAY1oNp53SbtIb6xqjiH?=
 =?us-ascii?Q?HF5RqE4jvFKAzuVomIsNy+cO6XxMnKVHyUV3anZvxAPijYeAk1YqLcRPzkPr?=
 =?us-ascii?Q?v9LQTg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91f7a4a7-5d32-40e0-c64f-08d9ec2c8d6c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4472.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 00:30:34.6786
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vpPnCD/PelbhxzPKNXyKPJ1IsL/g3XZyJsy4XrLiJU4anP/sYlhcm8iVeVRVhngKzVAg/gsHmca+cb0yMd9V893JXfnkknIysYSPQL+d2/I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2701
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100000
X-Proofpoint-ORIG-GUID: s5pTDQbunDLUe0lM7RbVSrJIwElIpOWP
X-Proofpoint-GUID: s5pTDQbunDLUe0lM7RbVSrJIwElIpOWP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move variables outside the switch, which silences warnings:

./drivers/rtc/rtc-pcf8523.c:284:20: error: statement will never be executed [-Werror=switch-unreachable]
  284 |                 u8 mode;
      |

./drivers/rtc/rtc-pcf8523.c:245:21: error: statement will never be executed [-Werror=switch-unreachable]
  245 |                 u32 value;
      |                     ^~~~~

Signed-off-by: Victor Erminpour <victor.erminpour@oracle.com>
---
 drivers/rtc/rtc-pcf8523.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c
index c93acade7205..baa89f431ebd 100644
--- a/drivers/rtc/rtc-pcf8523.c
+++ b/drivers/rtc/rtc-pcf8523.c
@@ -240,9 +240,9 @@ static int pcf8523_param_get(struct device *dev, struct rtc_param *param)
 {
 	struct pcf8523 *pcf8523 = dev_get_drvdata(dev);
 	int ret;
+	u32 value;
 
 	switch(param->param) {
-		u32 value;
 
 	case RTC_PARAM_BACKUP_SWITCH_MODE:
 		ret = regmap_read(pcf8523->regmap, PCF8523_REG_CONTROL3, &value);
@@ -279,9 +279,9 @@ static int pcf8523_param_get(struct device *dev, struct rtc_param *param)
 static int pcf8523_param_set(struct device *dev, struct rtc_param *param)
 {
 	struct pcf8523 *pcf8523 = dev_get_drvdata(dev);
+	u8 mode;
 
 	switch(param->param) {
-		u8 mode;
 	case RTC_PARAM_BACKUP_SWITCH_MODE:
 		switch (param->uvalue) {
 		case RTC_BSM_DISABLED: