Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Victor Erminpour <victor.erminpour@oracle.com>
To:     mustafa.ismail@intel.com
Cc:     shiraz.saleem@intel.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, trivial@kernel.org,
        victor.erminpour@oracle.com
Subject: [PATCH] RDMA/irdma: Fix GCC 12 warning
Date:   Wed,  9 Feb 2022 16:33:55 -0800
Message-Id: <1644453235-1437-1-git-send-email-victor.erminpour@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kuYKAcj8vcblJBwWpegnXpNdpVd71j/B84OMeW5Q2ku2Y/a3xGAKumvu33zL?=
 =?us-ascii?Q?MO4qjEwCgDwG6nJsJSZLnc9UuShjMPc++m6O9ayvBoydB7dbK7ovsGSjKhPz?=
 =?us-ascii?Q?VuB5fAk8C6BDfwLPJiZwBvlIWbmlaEknXFUlUcmpOyjx2UcIag8BTE5rpWJu?=
 =?us-ascii?Q?HbcRAu5tEemGGilvVAxp/RthtElCxDFPmOUf+FPDb47j4Vz3UEUvAdYbFQNn?=
 =?us-ascii?Q?f2VnUBknIbjg0IG0VbxELJRvyH2W8wYSydSoA+fsmtuLktWj1nRBphbnmTvU?=
 =?us-ascii?Q?CvHiRbgeSPc06d0mVE4UYuNG2kr0aNLML9zHO1dFkGidGrh3zZEuHo/xVk/F?=
 =?us-ascii?Q?b6O/8QIzK24a6B3JVh3gQDiHM5GwPhTH7LxbZMxemRlYJfZs4+xQcc7cRDoy?=
 =?us-ascii?Q?7mRk1RhXVb+CPCNSCm5F+c0fmcl8VcsdivujbnV3pGfSBbztVvTuw8AB0tGz?=
 =?us-ascii?Q?tp6cXNx4YkaLpBfQDFz15ZA+DZThib0xOzJe+v728rvO8d/6TmrxIgy8c4c4?=
 =?us-ascii?Q?Moxwj6S8wZ3u33MftayEM2BfghQxMNB3Vwdf7B4YdzwEjL+/P0lvgn8AJAjk?=
 =?us-ascii?Q?68w8L8Agiqrb/E2VHaVBHBIb3j/j05DeYWeW05mTarzOkMScYKBOKOm7M46u?=
 =?us-ascii?Q?oRjE8O6tBioscKDhivUm2Ss7CGPNxJl6Y4YDnc7f7PgJTTM0swPYjRyrujqa?=
 =?us-ascii?Q?vOK8YFlsNvA+Fo2El+WmhWj6Zpz6P5ufHquEyUxfO73uTWEecsdFB0eEklHm?=
 =?us-ascii?Q?11q0Bb8Tkd7KP0Ng/I0hjO22EGu+H/R3yoHi5f2hvXOM1L/Lm6jcHhgHWh5s?=
 =?us-ascii?Q?8eLN78NAhz+wvHrqaltdCkBPPOdCcMQ2M0ejr+AJfvvwHtN3murvZTYLztwH?=
 =?us-ascii?Q?8HeUz/XREHKnWC62T0C5sBvIgbT18zerJqBv3E0JGCKu309Jp/KdvsdFygwV?=
 =?us-ascii?Q?TmDncLHNMjwUoEIUtxqqNTW1MkPWHuvyhWFxXtIjrcI3pqY31XaOGhIaxpmR?=
 =?us-ascii?Q?2LxPMg/tPqqY0NG64MMt6rM6fNTvH+xd47snMY2TzwcDIvXNdkGWwT0hbNx2?=
 =?us-ascii?Q?CB6zpuliDVkO3GK+ACAeQRgmlc9KPqPDq5k2RrsguTyk1pftQ7ZVZQlUJ3hd?=
 =?us-ascii?Q?tMhpT4aiCD8cEbf3Zp/Y7A5m3foa0sZwPzUwcGOYaqAABiI7lslQqVyMyS89?=
 =?us-ascii?Q?f5Jd5EoPH+Mu5S2PPmEJNfdmt95wJr+m5ysrWMyqbmqd+r79zCLC5+BJ1LPc?=
 =?us-ascii?Q?DnmcXzttitoVrRKTMTQsbwTza+ezFyJ+Eyiz8XZewU/eR9NZOijn+Rci7nIZ?=
 =?us-ascii?Q?kmj3NEy+vLFb5tCEaHAUplwpDy74ZTr0qm7EY2jVmvIiN+Hj65hrioHg6tt8?=
 =?us-ascii?Q?bi/1qiAXv+s9s2d0pSDlceL0aScqaofZx5VKZgDuVpRpqMICklpMNJ/yrEQ+?=
 =?us-ascii?Q?tRuvPAmr9JzfzuU9S2VMG34P3IZNVSuguysde/vBUkYqnhsSxUcEjCWevzAe?=
 =?us-ascii?Q?pN9g6UcNr+7s1iCP+k50xJEm8MVEguSvHuPeBUMLM1zt8bgLWauWcCP7tmC5?=
 =?us-ascii?Q?NlTihy8XVl/JS18cv1zbqrO2MzJmWSxxQMM14xDaIyTUqTJBc7+AO0nH88bL?=
 =?us-ascii?Q?5KIJrGaEOf39wsezSYerj1LsiOIXeXwSS8qfffSYwdxbpt+wZTiBGuiQRZ/V?=
 =?us-ascii?Q?DQKzMg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40c05896-1006-444c-ac91-08d9ec2d08df
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4472.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 00:34:01.7915
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yGn668fCro5kRF15GMUrrsDLHCZyrp0e8s1fZWiKXKgfDidHF0sIZZkLapsRuWfRKYHWSw9aKaOmSvGU1R/AT2ZTEuJW/jicDlWkJ/8D0ng=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3039
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100000
X-Proofpoint-ORIG-GUID: 1fCCKkKfLWSK3EHIMbaFj8ybzvZ6U1h9
X-Proofpoint-GUID: 1fCCKkKfLWSK3EHIMbaFj8ybzvZ6U1h9
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable into the case that uses it, which silences the warning:

./drivers/infiniband/hw/irdma/hw.c:270:47: error: statement will never be executed [-Werror=switch-unreachable]
  270 |                         struct irdma_cm_node *cm_node;
      |

./drivers/infiniband/hw/irdma/utils.c:1215:50: error: statement will never be executed [-Werror=switch-unreachable]
  1215 |                         struct irdma_gen_ae_info ae_info;
       |

Signed-off-by: Victor Erminpour <victor.erminpour@oracle.com>
---
 drivers/infiniband/hw/irdma/hw.c    | 2 +-
 drivers/infiniband/hw/irdma/utils.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
index 89234d04cc65..a41a3b128d0d 100644
--- a/drivers/infiniband/hw/irdma/hw.c
+++ b/drivers/infiniband/hw/irdma/hw.c
@@ -267,8 +267,8 @@ static void irdma_process_aeq(struct irdma_pci_f *rf)
 		}
 
 		switch (info->ae_id) {
-			struct irdma_cm_node *cm_node;
 		case IRDMA_AE_LLP_CONNECTION_ESTABLISHED:
+			struct irdma_cm_node *cm_node;
 			cm_node = iwqp->cm_node;
 			if (cm_node->accept_pend) {
 				atomic_dec(&cm_node->listener->pend_accepts_cnt);
diff --git a/drivers/infiniband/hw/irdma/utils.c b/drivers/infiniband/hw/irdma/utils.c
index 398736d8c78a..16b65a6c7db1 100644
--- a/drivers/infiniband/hw/irdma/utils.c
+++ b/drivers/infiniband/hw/irdma/utils.c
@@ -1212,12 +1212,12 @@ enum irdma_status_code irdma_hw_modify_qp(struct irdma_device *iwdev,
 			return status;
 
 		switch (m_info->next_iwarp_state) {
-			struct irdma_gen_ae_info ae_info;
 
 		case IRDMA_QP_STATE_RTS:
 		case IRDMA_QP_STATE_IDLE:
 		case IRDMA_QP_STATE_TERMINATE:
 		case IRDMA_QP_STATE_CLOSING:
+			struct irdma_gen_ae_info ae_info;
 			if (info->curr_iwarp_state == IRDMA_QP_STATE_IDLE)
 				irdma_send_reset(iwqp->cm_node);
 			else