Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2441020pxb; Wed, 9 Feb 2022 19:42:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZP58q1R9SbU371CzoC3/qFwIQMGybINZPjs6JlcExrzdj+LDlwbTY4fZYfpHql3LitK4B X-Received: by 2002:a05:6402:371:: with SMTP id s17mr6211571edw.315.1644464563499; Wed, 09 Feb 2022 19:42:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644464563; cv=none; d=google.com; s=arc-20160816; b=GP/6rrWJPlzn7XKOsmWIzie8J5ef1UIhvUr3V0TVNc/MqTfYLQKK3d4958w3i582j/ GgZ7PbOR92OtintvGeudImwybehTnDTpz+7Rqz19DvJSujxXNObz2Ey7muftSmTXZ3Gg 0hPFXPpCEOTOG7SmTRuHC6JxfJMfsDVFWndJBZkG+uWpM9KR5q1G5MHYFrj9qLTxalJ2 tVR5deErim/eqFa7hapSNSsC25rTt5rrMMN1Zccu27a76J/FMQete4egvxcwGqfrqS+z S9cfDXzevClPKc3PBbbTo+Xb7eHGfYIdnKeAOHo3zwv+RoNsrRuBuOHWurFwUo3VWFoI lnWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=IrtpaL7Y7P/7BcLvPQerLsa8BLgAGhvSJ4wBMBuL5R0=; b=fkIMVgSaHh3sEWTJgy8PBp5daOXt85v+wn/wQE3BlDG1DTFr9dCS8BI5p2n97v4TwK BV09wlHgBtbph5peU653pn9sM4uUBU4YPtRuip78m4e9yTrWQ0VGXke/NEgLTzrmFpvr FNWg+BvqPP0gX0cjLA3seE217mvlwvQhyu6Da92C6y6DEklhmu+IHnRlqteVDbchoX3i yRvS/3wFE/sx+OYGIYNpoqvHcGYyhbyh5s5O9rDbMJUUQm4cu1i/2cL1bvbSocarSYma 9w3CfVN28E1zSsmqoMR6O+wIayFh1aHWdw2Gp8il7flBQMuinV24goiiwX8wcSTAGonB Zcdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N9pUXKks; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g10si15775952edz.128.2022.02.09.19.42.19; Wed, 09 Feb 2022 19:42:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N9pUXKks; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231366AbiBJCgd (ORCPT + 99 others); Wed, 9 Feb 2022 21:36:33 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231255AbiBJCg0 (ORCPT ); Wed, 9 Feb 2022 21:36:26 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92001237D8; Wed, 9 Feb 2022 18:36:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC503B8237D; Thu, 10 Feb 2022 02:36:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13ED9C340E7; Thu, 10 Feb 2022 02:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644460585; bh=bP1AetIUeykZM0C9T+LTSmrM0rMHwqKDK4UtSUG36mQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=N9pUXKksn9FrliIkYoOBR+ievtONsYuwkC9IXa1SHRr9hv6rj9MQt0WGpfVAbP+oq qZKbpmwiiBz6opxil1U/Ofky8Ka2Lsg0LjIDkAAdUKPBK8FuEYbF8TLp7+8ElM/IB6 Bz92dIL8Ar/kxuq6RK8s66QovL+urjEWF4bpeBse0LwEsS9Tp2Q31nuMJlMljyda2/ IciHCk7aYCJ0M7PnmHmYUh61ruD3sbhJztgs5LzA9bnYiy0wYZTxRVHeB5bRtrQPip xLVRIr5Bq/bHEqvXQquBcXFANvv6wzOvANdoTDrV35tbbc8qn2hmISfbk5TumnOJmd ttzKjnLOPn5eA== Date: Wed, 9 Feb 2022 18:36:23 -0800 From: Jakub Kicinski To: Mans Rullgard Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Vladimir Oltean , Juergen Borleis , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: lan9303: fix reset on probe Message-ID: <20220209183623.54369689@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220209145454.19749-1-mans@mansr.com> References: <20220209145454.19749-1-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Feb 2022 14:54:54 +0000 Mans Rullgard wrote: > The reset input to the LAN9303 chip is active low, and devicetree > gpio handles reflect this. Therefore, the gpio should be requested > with an initial state of high in order for the reset signal to be > asserted. Other uses of the gpio already use the correct polarity. > > Signed-off-by: Mans Rullgard Pending Andrew's review, this is the correct fixes tag, right? Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")