Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2510192pxb; Wed, 9 Feb 2022 22:10:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCiAupLdlqNxP1bAEBxa0VCQ3mGVacGAF+JEy5Zt1LL+XmKen1ttfHrcoUix+kfqfWiix0 X-Received: by 2002:a17:906:4f11:: with SMTP id t17mr5218312eju.655.1644473402345; Wed, 09 Feb 2022 22:10:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644473402; cv=none; d=google.com; s=arc-20160816; b=vSx1ulJ+iMr//sTpujt6ljlY6gl7UcnegQF2n16Y5N3xiABslsZGAtRfWMvdyf3X3O z1ddY1iwmCpXaogskLQWNAzRrsuoa+rGYF5jA9TvTjwv5OnLVVMwy32NN+gFBpwEpZNa 7rMg6lw2ye/qBwi+oMo9sNSv5ge7qcePSYq6Uq4ZSDFN4gyqwN2WFZpyy4Poe4Dxdtl+ HIpgOV19M6CEokIEoX3VUB0+vG5noZI8cFg9kA1OQTyWoeYQrbbg73QEZAgyQy8B2UjY reb4yARk4WoydNguNTc5ZEsNK3nZVbgdf09dcYSrULUKoeK+nbbX8YfmyQ4aAqNrgwt/ BWxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date; bh=Q3iGhgOt69+Yeli0x/V6SnFKZFZf9u6gR7xEhNXM1ZQ=; b=ckKXJW+ecXnqAKN/U0n7N9Ij6eR8iU606xJD9Q9cGGxpynZYOAntEy6rE1lLOLMZvE DIJw/VykThSDiVuYE8szpUuXeaX7xVgZ9TzWwG/f/uRaTgp21E7iHB6vFNYm6oCvZb+3 iVGmb3eUm+RU9J6pPUXkxAwTXC+DGeMrpNwtyMFawd3P71QFl1phjzHL1Ljc89PZTlnb 5I1AiIb/h/D5tlt5L1ubP2H2UXv4SjPR588dCoCKm9b7qw++HstkXCMX/Unyuyrshfjt Jz0J/8j4aHoDhOkkJb4VSW0nu5WPvPAFiG0Ke6hwAgh+rHIdVxZ5BFRMv33CLyEVsAoR Zr9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs39si8038475ejc.129.2022.02.09.22.09.37; Wed, 09 Feb 2022 22:10:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235024AbiBJF61 (ORCPT + 99 others); Thu, 10 Feb 2022 00:58:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbiBJF6T (ORCPT ); Thu, 10 Feb 2022 00:58:19 -0500 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C4391C5; Wed, 9 Feb 2022 21:58:20 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0V42eJYQ_1644472693; Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0V42eJYQ_1644472693) by smtp.aliyun-inc.com(127.0.0.1); Thu, 10 Feb 2022 13:58:15 +0800 Date: Thu, 10 Feb 2022 13:58:13 +0800 From: Gao Xiang To: David Howells Cc: Jeffle Xu , linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, gregkh@linuxfoundation.org, tao.peng@linux.alibaba.com, willy@infradead.org, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, linux-fsdevel@vger.kernel.org, eguan@linux.alibaba.com, gerry@linux.alibaba.com, torvalds@linux-foundation.org Subject: Re: [Linux-cachefs] [PATCH v3 00/22] fscache, erofs: fscache-based demand-read semantics Message-ID: Mail-Followup-To: David Howells , Jeffle Xu , linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, gregkh@linuxfoundation.org, tao.peng@linux.alibaba.com, willy@infradead.org, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, linux-fsdevel@vger.kernel.org, eguan@linux.alibaba.com, gerry@linux.alibaba.com, torvalds@linux-foundation.org References: <20220209060108.43051-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220209060108.43051-1-jefflexu@linux.alibaba.com> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On Wed, Feb 09, 2022 at 02:00:46PM +0800, Jeffle Xu wrote: ... > > > Jeffle Xu (22): > fscache: export fscache_end_operation() > fscache: add a method to support on-demand read semantics > cachefiles: extract generic function for daemon methods > cachefiles: detect backing file size in on-demand read mode > cachefiles: introduce new devnode for on-demand read mode ... > > Documentation/filesystems/netfs_library.rst | 18 + > fs/cachefiles/Kconfig | 13 + > fs/cachefiles/daemon.c | 243 +++++++++-- > fs/cachefiles/internal.h | 12 + > fs/cachefiles/io.c | 60 +++ > fs/cachefiles/main.c | 27 ++ > fs/cachefiles/namei.c | 60 ++- Would you mind taking a review at this version? We follow your previous advices written in v2 and it reuses almost all cachefiles code except that it has slightly different implication of cachefile file size and a new daemon node. I think it could be as the first step to implement fscache-based on-demand read. Thanks, Gao Xiang