Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Feb 2022 20:37:16 -0800 (PST)
From:   Hugh Dickins <hughd@google.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
cc:     Hugh Dickins <hughd@google.com>, SeongJae Park <sj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for-mm 1/2] mm/internal: Implement no-op mlock_page_drain()
 for !CONFIG_MMU
In-Reply-To: <CAMuHMdV7EaHK5zJAbLU9eKwMYxFdAQ0TiS+Ydg56mGkBv09dHA@mail.gmail.com>
Message-ID: <be1b571c-ca4b-ab4a-ea8c-43fd579e3a32@google.com>
References: <20220209094158.21941-1-sj@kernel.org> <20220209094158.21941-2-sj@kernel.org> <715a8b2e-1048-c098-8b89-bcf3c13cbd75@google.com> <CAMuHMdV7EaHK5zJAbLU9eKwMYxFdAQ0TiS+Ydg56mGkBv09dHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 9 Feb 2022, Geert Uytterhoeven wrote:
> On Wed, Feb 9, 2022 at 4:38 PM Hugh Dickins <hughd@google.com> wrote:
> > The thing is, SeongJae's patch makes me wonder, why did it not need a
> > !CONFIG_MMU definition for need_mlock_page_drain() too?  That's because
> > mm/swap.c's call to it is under an #ifdef CONFIG_SMP, and I imagine that
> > CONFIG_MMU=n usually goes along with (but does not necessarily imply?)
> > CONFIG_SMP=n.  It'll be safer to add a need_mlock_page_drain() stub too.
> 
> RISC-V K210 is SMP without MMU.

Thanks Geert, that makes it very clear that we also want the stub for
need_mlock_page_drain().  I'll follow now with update of SeongJae's patch.

My fear of wider implications of not having CONFIG_SMP turned out to
be a false alarm.  The UP lru_add_drain_cpu() calls mlock_page_drain()
just like the SMP one does: the difference between them is merely that
the UP case doesn't need an efficient way for asking in advance whether
drain on another cpu will be needed.

Hugh