Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Qing Wang <wangqing@vivo.com>
Cc:     Maya Erez <merez@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wireless: ath: use div64_u64() instead of do_div()
References: <1644395972-4303-1-git-send-email-wangqing@vivo.com>
Date:   Thu, 10 Feb 2022 08:40:56 +0200
In-Reply-To: <1644395972-4303-1-git-send-email-wangqing@vivo.com> (Qing Wang's
        message of "Wed, 9 Feb 2022 00:39:32 -0800")
Message-ID: <87v8xnrzpj.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Qing Wang <wangqing@vivo.com> writes:

> From: Wang Qing <wangqing@vivo.com>
>
> do_div() does a 64-by-32 division.
> When the divisor is u64, do_div() truncates it to 32 bits, this means it
> can test non-zero and be truncated to zero for division.
>
> fix do_div.cocci warning:
> do_div() does a 64-by-32 division, please consider using div64_u64 instead.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
>  drivers/net/wireless/ath/wil6210/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The subject prefix should be "wil6210:", but I can fix that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches