Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 11:06:03 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     David Laight <David.Laight@ACULAB.COM>,
        'Jiapeng Chong' <jiapeng.chong@linux.alibaba.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] staging: pi433: using div64_u64() instead of do_div()
Message-ID: <20220210080603.GJ1951@kadam>
References: <20220121114955.96979-1-jiapeng.chong@linux.alibaba.com>
 <03591933cc384d7e91ede82f0cdd76a8@AcuMS.aculab.com>
 <9c563d78-f883-65ee-9e7b-cf44e3b238e8@wanadoo.fr>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9c563d78-f883-65ee-9e7b-cf44e3b238e8@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?3wdkRkzspH8t2xL8Hx1O58lvw6zNosOWyymu8YJsqRnY5i6xwuqQH7eVYB?=
 =?iso-8859-1?Q?O6RuHWRiBZSkFliRLuTkKvyQ06cG9TIg5H2NAzJTJ5jvNhaWw1HYZNgVQG?=
 =?iso-8859-1?Q?1br+keImhCypmn+OELj5Pv5cDVtPyx30OMv+Gl9QOcXqSsxCbgsZdd9v7a?=
 =?iso-8859-1?Q?+Dl4YgCUC02tEqCQxrpJ39kNX8WdTHVBhmdKNQsojC5pTdq3U96t7MUWnS?=
 =?iso-8859-1?Q?VujnuDfIutP3Iz7GAEGHaIHBL8jzwJV1G0ODxY2l5KmP4+hqdtZLuz0Ehh?=
 =?iso-8859-1?Q?f2yBzlbPpRvEa6+JWvNbQhgrWT2TF6lxGlMEovBjo7Gpc3jj1JUiCL6lma?=
 =?iso-8859-1?Q?YsjwslpV49MEebfUX5g5VOxTnTTYCVALvdxZALxUlSz/zAA4j3SBsHkdIU?=
 =?iso-8859-1?Q?JwOVXJ6lMoWzLe6oAyd3N7hVhxbF+8W43fyLEsMIOM8awElJYNeVtKmfm9?=
 =?iso-8859-1?Q?NVF2P8cUrUw8viN6aQHLFRmDoBF1I2iXoO6Jlwacv/J/MEIifxLWavpd/O?=
 =?iso-8859-1?Q?e/I9y7L2c7v2Nw64zoSUarVKrDT3xFavNwYtarPDPr6r6b1MKk0EORbT7g?=
 =?iso-8859-1?Q?cPBXPRM0Wu1j3KfVnFg5nIZCy68FmfvMVGwv4PUpG64G3zZlktIVyWyuM+?=
 =?iso-8859-1?Q?cCwO4jKUu8cJlfNCac08AWv5vhm3dNFHI/rd3hb0atGIrtGRf9E6NmEKxT?=
 =?iso-8859-1?Q?5tYtxh2+/OlxUlON40t2qSSLIPvgIRCIOfBleMvBJPU4EGIbUH0sCnJFm/?=
 =?iso-8859-1?Q?RaU2dpTCtcjF1bOKWtwK2a38CI3MTg4rSNFmBB9KBLbu8vJKnJKcWHs1ap?=
 =?iso-8859-1?Q?a8i4cO3VbIAHs9C5M6v79sPAO1sGhq27Mci7c8OxCScZruAglrUeODY/2a?=
 =?iso-8859-1?Q?nwA1YfUh7mH9AM+4SbsmfvMkYusE8fMC+GdO3JYm2XH8LjkcusYzkQv6Tn?=
 =?iso-8859-1?Q?ADdj4gQ9F82lc2jRMJ/BMNOHK8o7HlE/0V8DCUWtSrv+KPEfF7l00xYDwK?=
 =?iso-8859-1?Q?pmkrCWEAneQwztsdUD22OPf0fefy4BS4NUN2VNnWOxkkjrh1BO/p6U3Oqt?=
 =?iso-8859-1?Q?Z69zXzljNtydmz78/+TDkHEt/+GX0AIRw80Ziae+GeLbGuWZJ/hWtc+6Go?=
 =?iso-8859-1?Q?QFqV2tsPBgpsqNdlzu/QzRUf0/nyfb2WbIR64bNAeSD9L9GTcMc3Wg6yz+?=
 =?iso-8859-1?Q?TsM4ZgPtOoH0LLozgt5YjTtCFB/uThUxq99E++koIDr3J3unKqWTkkSq2J?=
 =?iso-8859-1?Q?lAGZlinD9s2SgslvCU8f5U+/vtVme/GLgKKWq+NJpDjPrFF12Ffn8bV+8R?=
 =?iso-8859-1?Q?2xPkLp+Rlj0+8WhfTmP2xekRJrPiSDy83wP2hs+S/Bh1RBUEOiiHlqpCQ3?=
 =?iso-8859-1?Q?0GsShWzLLdT/8YJnk6XuEtjm6seVrmacXK/ZhYrON09z0as8Sk9ltShr8B?=
 =?iso-8859-1?Q?biWXV6CyZ5z4Ih7G7sCkFYhUuARangtGt8CGWC1svdsir/GErg0Xf0mH8d?=
 =?iso-8859-1?Q?VxkPfMRDkzcCrioYD/+d/QV8aprMXPGN/6Rb06jpgwXaOKw6XTtK5f+4Bt?=
 =?iso-8859-1?Q?Xe31Ooyy7gUvTOg2x2ML/PZsKQbUSzXVH5NTRrPRccsX884FgHqjh1kwYS?=
 =?iso-8859-1?Q?x80444PtQemEev1yvh53mzc/JThNwNxSGMmLG8gpKiJDnvSXnSS7ILVjCs?=
 =?iso-8859-1?Q?wpC2jPbg8BZGOgzxMAgdIMEd3EJRJLg66fkNvBUcc0N9PvHHnFQddjvQ1E?=
 =?iso-8859-1?Q?CQWg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44c37fd3-660f-435e-794a-08d9ec6c3d4a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 08:06:28.3549
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gcpdD5z98zmLSie8T8gH8DhcfR4W8odhcNOVzI245Rk0KyywqnB7uW1Z/0ag36WFI8is+j1OUlnM6+IVY5aXhEtcWaFm8u1fyk3CkwisitE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4425
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100042
X-Proofpoint-GUID: 4cD6i82BcxZP1el39_kTxI5jBIjo9Ubs
X-Proofpoint-ORIG-GUID: 4cD6i82BcxZP1el39_kTxI5jBIjo9Ubs
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 09, 2022 at 08:15:13PM +0100, Christophe JAILLET wrote:
> Le 21/01/2022 ? 14:34, David Laight a ?crit?:
> > From: Jiapeng Chong
> > > Sent: 21 January 2022 11:50
> > > Subject: [PATCH] staging: pi433: using div64_u64() instead of do_div()
> > > 
> > > Clean the following coccicheck warning:
> > > 
> > > ./drivers/staging/pi433/rf69.c:286:1-7: WARNING: do_div() does a
> > > 64-by-32 division, please consider using div64_u64 instead.
> > 
> > That is one of patchcheck's worse warnings.
> > 
> > You need to check the domain of the divisor, not its type.
> > 
> > do_div() exists to avoid expensive 64bit divides when the
> > divisor is small.
> > 
> > 	David
> > 
> > -
> > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> > Registration No: 1397386 (Wales)
> > 
> > 
> 
> Moreover, the patch is broken by itself.
> 
> See [1] were it was already reported that do_div() and div64_u64() don't
> have the same calling convention.
> 
> Looks that div64_u64() and div64_ul() works the same way.

We could mark those as __must_check functions.

regards,
dan carpenter