Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 08:40:46 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     zhaoxiao <zhaoxiao@uniontech.com>
Cc:     thierry.reding@gmail.com, lee.jones@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: vt8500: Rename variable pointing to driver private
 data
Message-ID: <20220210074046.vxskduecvgiehvnl@pengutronix.de>
References: <20220209064755.7287-1-zhaoxiao@uniontech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fyuwep3g3kqdbwyv"
Content-Disposition: inline
In-Reply-To: <20220209064755.7287-1-zhaoxiao@uniontech.com>
Precedence: bulk


--fyuwep3g3kqdbwyv
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 09, 2022 at 02:47:55PM +0800, zhaoxiao wrote:
> Status quo is that variables of type struct vt8500_chip * are named
> "pwm", "chip" or "pc". The two formers are all not optimal because

There are no variables named "pwm" or "pc".

> usually only struct pwm_device * variables are named "pwm" and "chip" is
> usually used for variabled of type struct pwm_chip *.
>=20
> So consistently use the same and non-conflicting name "pc".

The intention is fine, but you missed a few instances that are named
"vt8500". The statistic in mainline looks as follows:

	$ git grep -o -h -E 'struct vt8500_chip \*[a-zA-Z0-9_]*' linus/master driv=
ers/pwm/pwm-vt8500.c | sort | uniq -c
	      2 struct vt8500_chip *chip
	      5 struct vt8500_chip *vt8500

(So there 2 variabled named "chip" (that you renamed to "pc") and 5 that
are named "vt8500". I prefer to rename the "chip"s to "vt8500".

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--fyuwep3g3kqdbwyv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEyBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmIEwXsACgkQwfwUeK3K
7AmJmwf4pLI+xky/sNclDRJg2Ypliqo7er293BmkpQULSlxeCTscd0Cl5DAuPzu5
EqieGUMK5TWQXrCzmByT4/DZMdAVZKD/MS562QMmt31ZO+qyGFiT52iFAShqqDbv
KHE48UL7Qx3z3lTl3BLW/kDAanm24DtzQA5q6jT3EWko1HGbmM94Lk6xOfj0CgG1
I0seC3QwNugGJ79qjwkbb+bHCcMo2JGkMTFPPy7mibkfx5l5MnbPWLYU7uJHdR5w
A7ynb5iknN/OxjrbVv0/r8B9+PWN0uOWRVOCNGiK6ZIIeN8YvhDxHVke1hNYnowP
S41JpAYy9TdGGvSTYBy56A1KPeBh
=EHRm
-----END PGP SIGNATURE-----

--fyuwep3g3kqdbwyv--