Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a940cf331d493c8755454e8557c2330901e30986.camel@perches.com>
Subject: Re: [PATCH] media: si21xx: use time_after_eq() instead of jiffies
 judgment
From:   Joe Perches <joe@perches.com>
To:     Qing Wang <wangqing@vivo.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 10 Feb 2022 01:07:19 -0800
In-Reply-To: <1644481917-14908-1-git-send-email-wangqing@vivo.com>
References: <1644481917-14908-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2022-02-10 at 00:31 -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> It is better to use time_xxx() directly instead of jiffies judgment
> for understanding.
[]
> diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb-frontends/si21xx.c
[]
> @@ -336,7 +336,7 @@ static int si21xx_wait_diseqc_idle(struct si21xx_state *state, int timeout)
>  	dprintk("%s\n", __func__);
>  
>  	while ((si21_readreg(state, LNB_CTRL_REG_1) & 0x8) == 8) {
> -		if (jiffies - start > timeout) {
> +		if (time_after(jiffies, start + timeout)) {
>  			dprintk("%s: timeout!!\n", __func__);
>  			return -ETIMEDOUT;
>  		}

Appreciate all the conversions (IMO it should have been sent as
a block of patches with a cover letter instead of independent
unrelated patches) but wouldn't all of these be simpler and more
consistent using a style where the addition is done once and the
timeout test is something like:

	unsigned long end = jiffies + timeout;

	while (foo) {
		if (time_after(jiffies, end)) {
			error_msg(...)
			return -ETIMEDOUT;
		}
		bar...;
	}