Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2682497pxb; Thu, 10 Feb 2022 03:16:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJx/2ifYgf7dXL599rkUcxNFVz0l2VtIpYljcTXScAgexx9FGcgmaYjQ/zgfdJwp1lYwYd6o X-Received: by 2002:aa7:c9cf:: with SMTP id i15mr5161493edt.115.1644491800667; Thu, 10 Feb 2022 03:16:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644491800; cv=none; d=google.com; s=arc-20160816; b=DtIDj+ePefTQh66AMgpTgB8X0JWwex8EYYiRMG7Q0yS93X9IKz250LEQpNLJ7Od4fh gz7pEfw0QNYI8e0hfNHQk80NTC0SBUsYBOTl/I/Cp/Zo5J+xIzDaD8lHtUWByhU+QCHV GwJxQKeqDtXasKTjxae6zoSPg69aFDivR76HRdEEC2MaU5lsSVfUCN/Wd6NesfkpaMsC xyIEkjZM5kQmdObqdfjqbPq2n1D7LIFsYKU7r2SAk1fSXl3MQFrS5HLVh8rGIg36yWAt LF/ld2wo/GbegUIYF4GDgGh/gJhkT5OUHZJD5E/C18QVq96whhgEeyzVxBLSlezUsZxk URtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=81HmC6N36AUv3DS+gd84GgUi8DyL6BEk+8tTF7TOR9A=; b=yTJxkVQwIUEh/B4oChQFFH06j8V0d/qgXgZy08Dy8ZQfnFDfd1wzqHvUm6jflFxZnd UqpyrNFmYMCMGvg9M6Nvj64HNNX0T+8stOIhmdYZNAzTkxL/e0MydBoQ1iTLOdm91UDi DT8NSpPP1ucuZSIke6q2iVUK3A2fsfh5uzbznvLLevtI6XHv1F+H5NSFU2xy6FBD9P6k V3ktBthY6g+CwSh2WPrd32gwXABKiQFPGlimrkWA8oqqeoMM8Mow+pZ7o2a4SCag6FdW qjpbiYactLiIN3uEEyQ7QmcyDZ0cQ3kiDoDh2F199MMAgvkeQ+2nkF/d3VxNHigRuoZy MDXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=klBWVq+V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz10si15875561edb.585.2022.02.10.03.16.16; Thu, 10 Feb 2022 03:16:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=klBWVq+V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239881AbiBJKix (ORCPT + 99 others); Thu, 10 Feb 2022 05:38:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238091AbiBJKiv (ORCPT ); Thu, 10 Feb 2022 05:38:51 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4C36184 for ; Thu, 10 Feb 2022 02:38:52 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id y18so1446765plb.11 for ; Thu, 10 Feb 2022 02:38:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=81HmC6N36AUv3DS+gd84GgUi8DyL6BEk+8tTF7TOR9A=; b=klBWVq+VcpD1JwYhqrguON/wgfmRIoeAkScl31urYeBrPusoY43z4JDi85XGNQ/nAi HNpnPOrNRyM/rETRpPRxnLjtBJaagIoMTide+qa+TG0/D6Z3ZuGMpG7qqNbcmsdxzBPr Cs6gy3oP686jfbbE1xNzeAz2dv27FFO/FDo2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=81HmC6N36AUv3DS+gd84GgUi8DyL6BEk+8tTF7TOR9A=; b=IXzfm8kuH858VJQydSSQpWjxnH52a1OV8gkq5el3577bsJvTxfWDCUPYYOaGE5eWVM wh89Tx0YmCeOnA51nSU4Cd3EVw7X2LYxj0+XEyOQRkHdZxgchedvkrY4jP3HQcoUJ9JT 8x4N4KaEkWlWTVHUbCl4z3l1EUU0WMr7fQIJmSvbZ1zFHFobLHRyl8rKnmInd8HFo0lH 8gBKgcJHMt4HPwdqoxOJkjMGyZuoSOYAf88mM2le9cxkBGq6CdK7qRtzsRrkMu2bmo8Z 9VqK6EZ7QHzAk+S6KWT4auOS01pZKj5cFXtnOnf7Rv+z4JF8bfnWB+VFbKD6BERJR1Wp Hf5Q== X-Gm-Message-State: AOAM532slaoDG8vkNLRJMP+IxnpiEJsDoBqk/ce5aRPwHcJwKk/v3g0i LrdMubKgBDZzO/21E9Xo63FzPA== X-Received: by 2002:a17:902:8f92:: with SMTP id z18mr7040383plo.42.1644489532286; Thu, 10 Feb 2022 02:38:52 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:b164:4f36:23f1:78c]) by smtp.gmail.com with ESMTPSA id c4sm10941176pfl.131.2022.02.10.02.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 02:38:51 -0800 (PST) From: Pin-Yen Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter Cc: Pin-Yen Lin , Hsin-Yi Wang , Maxime Ripard , Pi-Hsun Shih , Sam Ravnborg , Tzung-Bi Shih , Xin Ji , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID Date: Thu, 10 Feb 2022 18:38:27 +0800 Message-Id: <20220210103827.402436-1-treapking@chromium.org> X-Mailer: git-send-email 2.35.0.263.gb82422642f-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The length of EDID block can be longer than 256 bytes, so we should use `int` instead of `u8` for the `edid_pos` variable. Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Signed-off-by: Pin-Yen Lin Reviewed-by: Jernej Skrabec --- Changes in v2: - add "Fixes" tag - collect review tag drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 2346dbcc505f..e596cacce9e3 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -846,7 +846,8 @@ static int segments_edid_read(struct anx7625_data *ctx, static int sp_tx_edid_read(struct anx7625_data *ctx, u8 *pedid_blocks_buf) { - u8 offset, edid_pos; + u8 offset; + int edid_pos; int count, blocks_num; u8 pblock_buf[MAX_DPCD_BUFFER_SIZE]; u8 i, j; -- 2.35.0.263.gb82422642f-goog