Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9cd8a336ed31eaf6bea2ad53f185abac22dc8474.camel@gmail.com>
Subject: Re: [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Antoniu Miclaus <antoniu.miclaus@analog.com>, jic23@kernel.org,
        robh+dt@kernel.org, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 10 Feb 2022 09:26:21 +0100
In-Reply-To: <YgOtN+wha+j3ZFIO@smile.fi.intel.com>
References: <20220131100102.15372-1-antoniu.miclaus@analog.com>
         <Yf7AjXsRuhFeFTpD@smile.fi.intel.com>
         <e59fce3747428f30afdf77f9839910664e3e8524.camel@gmail.com>
         <YgOtN+wha+j3ZFIO@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2022-02-09 at 14:01 +0200, Andy Shevchenko wrote:
> On Mon, Feb 07, 2022 at 09:29:54PM +0100, Nuno Sá wrote:
> > On Sat, 2022-02-05 at 20:23 +0200, Andy Shevchenko wrote:
> > > On Mon, Jan 31, 2022 at 12:00:59PM +0200, Antoniu Miclaus wrote:
> > > > The ADMV1014 is a silicon germanium (SiGe), wideband,
> > > > microwave downconverter optimized for point to point microwave
> > > > radio designs operating in the 24 GHz to 44 GHz frequency
> > > > range.
> > > 
> > > Excellent job!
> > > A few comments / questions below.
> > > 
> > > ...
> > > 
> > > > +config ADMV1014
> > > > +       tristate "Analog Devices ADMV1014 Microwave
> > > > Downconverter"
> > > > +       depends on SPI && COMMON_CLK && 64BIT
> > > 
> > > Why 64BIT only?
> > 
> > Could not resist on this one... The thing is that CCF uses unsigned
> > long for rates and this part operates in high GHz values. That
> > means,
> > as CCF stands, this cannot work on 32bit.
> 
> I read it a bit differently, i.e. CCF has a bug that needs to be
> addressed.
> 

Totally agreed...

However, this can be something that might take time
to support in CCF (I definetly have plans to send a RFC to, at least,
start the discussion around this) so I guess we can already support
this device like this. I believe this is somethig straight to remove
as soon as CCF works in 32bit archs for high speed devices...

- Nuno Sá