Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     =?iso-8859-1?Q?=27Uwe_Kleine-K=F6nig=27?= 
        <u.kleine-koenig@pengutronix.de>, Qing Wang <wangqing@vivo.com>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] pwm: use div64_u64() instead of do_div()
Thread-Topic: [PATCH] pwm: use div64_u64() instead of do_div()
Thread-Index: AQHYHclpMmDYeR7Hx0KRNkbIRj4HSKyMibOg
Date:   Thu, 10 Feb 2022 09:48:44 +0000
Message-ID: <9273cd6497354dd882faf55b194ff590@AcuMS.aculab.com>
References: <1644395998-4397-1-git-send-email-wangqing@vivo.com>
 <20220209152609.gqeivcehkuzgz3sk@pengutronix.de>
In-Reply-To: <20220209152609.gqeivcehkuzgz3sk@pengutronix.de>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Uwe Kleine-König
> Sent: 09 February 2022 15:26
...
> > -	do_div(cycles, period_ns);
> > +	div64_u64(cycles, period_ns);
> 
> This is wrong, div64_u64() has a different calling convention than do_div().
> 
> The issue however is real. Please add

Not really although I can't see a check I'd assume that period_ns
is expected to be much less than a second - so well under 32 bits
There is certainly a general expectation that multiplying by
other 'largish' values won't exceed 64 bits.

Plausible the pwm 'period' should actually be a u32.
But then care would be needed to ensure the multiplies have
64bit results.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)