Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: nitirawa=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 10 Feb 2022 18:06:59 +0530
From:   nitirawa@codeaurora.org
To:     Lukas Wunner <lukas@wunner.de>, Keith Busch <kbusch@kernel.org>
Cc:     Vidya Sagar <vidyas@nvidia.com>, Keith Busch <kbusch@kernel.org>,
        robh+dt@kernel.org, rafael.j.wysocki@intel.com, hch@lst.de,
        bhelgaas@google.com, mmaddireddy@nvidia.com, kthota@nvidia.com,
        sagar.tv@gmail.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: Query related to shutting down NVMe during system suspend
In-Reply-To: <20220210054019.GA929@wunner.de>
References: <65b836cd-8d5d-b9c2-eb8f-2ee3ef46112b@nvidia.com>
 <20220209202639.GB1616420@dhcp-10-100-145-180.wdc.com>
 <0801d0ee-1c39-4413-7865-6c1c61e4706e@nvidia.com>
 <20220210054019.GA929@wunner.de>
Message-ID: <65a50f83e87d4cf8b1ac1b740b4fa35b@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2022-02-10 11:10, Lukas Wunner wrote:
> On Thu, Feb 10, 2022 at 09:41:04AM +0530, Vidya Sagar wrote:
>> On 2/10/2022 1:56 AM, Keith Busch wrote:
>> > Christoph prefers to append quirks for platforms that need full device
>> > shutdown on s2idle instead of changing the driver default.
>> >
>> > We use dmi matching for our current platform quirk list. I do not know
>> > what the equivalent is for device-tree based platforms. Do you know?
>> 
>> I'm afraid I don't.
> 
> of_machine_is_compatible()

Thanks Lukas and keith . Yes it worked using of_machine_is_compatible as 
it checks root node of device tree for a given compatible value.
@keith - I have posted the change using above API to enable nvme quick 
suspend quirks for sc7280 platform. Please can you review it.