Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2821158pxb; Thu, 10 Feb 2022 06:21:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOcnN+qcaSAnK5y6IIDicPMZ3djzHmJ9snmmRbPRwtKXEnyV/lb+i0Efs4UemV7B4zcfAn X-Received: by 2002:a05:6402:b50:: with SMTP id bx16mr8455295edb.319.1644502891214; Thu, 10 Feb 2022 06:21:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644502891; cv=none; d=google.com; s=arc-20160816; b=U9vMk2dEAWb+kAi+Rh/ybjaX01SphdZFWl6SaWjch9Vq0Nuy41bFn9BMlWsC2mlemU jXoVZ3pWLiLXT8dKRTLXvT9oYmE9YsEzV7G8zv17PUwVegQQVSPpQNpK5FexPhw4Bu9C s84RR5Eiybg+vUQDnfBRvhS6ydMAoVbbAm/1nsSd1OL2BXuYbF99rONM3r38X8j1+Qwo uiZ+7Bnhv3cLvJafwBfPAwNJipwKD5sR9hc/cjOjCWRqNAd6Gx4IsPv5ntm4m7UG0Tn4 kYE7OLYwZHSEn9cbypFQ5ic1luKVfxx1yA1tYK+UHL+ttl2bKExtAqjYf7R+ErtN8bYU +cxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=nBHhq49uCc75DS97sG44+fUdr0Nlml2Df6wYV8Jv/k8FL4Ps3HTXDMN8D+Z3UZ39VB W0Sgp8A8JsClJ7DrQqcaVNzi8IwpIp75gUwWfkVZrwe4++4unkPNwIAcWU6Qabvueq7K 42wj2EBhRa5dtF087VrREg1IjIwfzjt7vmnAUrrnZphNPg0+An6ulcd3QAGajk5NvpVs eoyVFdi8OP+9H9zgSqcs5kbK0Jlyuwq180koSjyVaKGjuI/PpI8TpjHl0qe+77kezUbh wvPHu7KD2EJOa1ve6pCpFANC+4YuDNH4/WAaEpnCqenuBw2WRRVvLPDBMYdFuMRdnsm2 cSNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=ppLX4h1T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m17si5881476edd.66.2022.02.10.06.21.05; Thu, 10 Feb 2022 06:21:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=ppLX4h1T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242177AbiBJN11 (ORCPT + 99 others); Thu, 10 Feb 2022 08:27:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242168AbiBJN1T (ORCPT ); Thu, 10 Feb 2022 08:27:19 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D891B5 for ; Thu, 10 Feb 2022 05:27:20 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id k1so9562559wrd.8 for ; Thu, 10 Feb 2022 05:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=ppLX4h1TEy8PBW7a4orzxmSRVpkxMMzDVgFrPPO+f6wmqSNbpVbyd980agqXUsmsK4 1t3S3V3yoGn5PBZR2wXsNiBwTiBg+7IWH1M5aJJPZiGs155neECX0Xdc2i3WXR7UwbMM aT3Xtfs00uZGf1TbnMYWNrEUtQHMZ5qRjlmiRc0/xqYQhMq8duwRHg0U0Z9pXtKzJ45Q hYfhYVE/1cZLNyTrYw1GNDxUZjkYoAd3FPrsD2ljbrv3HGwfrkyETIATbgIB71TaTNDV dnfvww2HWwcMyGbOkxaLGF8pIQWjKAPbfSCnWB56bK0zNRSMtsjTh7NuJVkUEYKppMbv lTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=0z31NOR+o7yyOcc4H62t47McRGKvq2tBTqS/36GDSQvRT1+RkbdtsRWPw+FAFXgfxJ 75ji0xP5SRFCe5u3AW4F48nJ+DtVrwgStiWf2RtN7YxdgEzWKV8f0b5bAML1FqZHf9uY 2CLLZWnqrGztmq9n+dey8AwpbzrkOCu5zRN+beNYxU822av0IqwSd680yPEdJlHeXr8I 2FxiFDDGQZgLmHvqwB8+T/zkGCXKHAZnQZPU0HOCHruR4U7xekC32hbQlpSQ0HFABq3y imCfPE6OtLmLeDK/H2jqYgZoSl88HBaejb1aNvHY6I5IXVd/w3Ag//0ovQ41amB3uII2 kefg== X-Gm-Message-State: AOAM533om7OZVTE8gLJ7TZ9cYe0TcQxMl0XZKSAdelTOc4H+ug5315ft 8NcBM244tphN+8BYm+DzXL3Tdw== X-Received: by 2002:a5d:4745:: with SMTP id o5mr485824wrs.275.1644499638587; Thu, 10 Feb 2022 05:27:18 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id h6sm1559790wmq.26.2022.02.10.05.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 05:27:18 -0800 (PST) Date: Thu, 10 Feb 2022 14:27:15 +0100 From: LABBE Corentin To: Rob Herring Cc: linus.walleij@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2] dt-bindings: mtd: drop mtd/cortina,gemini-flash.txt Message-ID: References: <20220131080858.1777518-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Wed, Feb 09, 2022 at 03:18:41PM -0600, Rob Herring a ?crit : > On Mon, Jan 31, 2022 at 08:08:58AM +0000, Corentin Labbe wrote: > > Drop mtd/cortina,gemini-flash.txt since it is nearly already handled by > > Documentation/devicetree/bindings/mtd/mtd-physmap.yaml. > > > > Reviewed-by: Linus Walleij > > Signed-off-by: Corentin Labbe > > --- > > Change since v1: > > - fixed typo on syscon > > > > .../bindings/mtd/cortina,gemini-flash.txt | 24 ------------------- > > .../devicetree/bindings/mtd/mtd-physmap.yaml | 18 +++++++++++++- > > 2 files changed, 17 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt b/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > deleted file mode 100644 > > index efa5b2aba829..000000000000 > > --- a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > +++ /dev/null > > @@ -1,24 +0,0 @@ > > -Flash device on Cortina Systems Gemini SoC > > - > > -This flash is regular CFI compatible (Intel or AMD extended) flash chips with > > -some special bits that can be controlled by the machine's system controller. > > - > > -Required properties: > > -- compatible : must be "cortina,gemini-flash", "cfi-flash"; > > -- reg : memory address for the flash chip > > -- syscon : must be a phandle to the system controller > > -- bank-width : width in bytes of flash interface, should be <2> > > - > > -For the rest of the properties, see mtd-physmap.yaml. > > - > > -The device tree may optionally contain sub-nodes describing partitions of the > > -address space. See partition.txt for more detail. > > - > > -Example: > > - > > -flash@30000000 { > > - compatible = "cortina,gemini-flash", "cfi-flash"; > > - reg = <0x30000000 0x01000000>; > > - syscon = <&syscon>; > > - bank-width = <2>; > > -}; > > diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > index f827984936f6..82eb4e0f453b 100644 > > --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > @@ -44,7 +44,9 @@ properties: > > - numonyx,js28f128 > > - sst,sst39vf320 > > - xlnx,xps-mch-emc-2.00.a > > - - const: cfi-flash > > + - enum: > > + - cfi-flash > > + - jedec-flash > > Why is jedec-flash being added? The old doc made no mention of it. > Because one board (gemini-dlink-dns-313.dts) use it. See commit a10d862e585e06aacc3a03e230fdf8faf6b1caf0 """ The flash on the DNS-313 needs to be probed as JEDEC, it does not conform to the common CFI standard. """ I will add this (the addition of jedec-flash) in commmit log. Regards