Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e3cebd32-689d-f74e-f53a-b24e1bf71f6f@canonical.com>
Date:   Thu, 10 Feb 2022 14:03:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dt-bindings: arm: at91: add Kontron's new KSwitches
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Rob Herring <robh+dt@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>
References: <20220210125705.481612-1-michael@walle.cc>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
In-Reply-To: <20220210125705.481612-1-michael@walle.cc>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/02/2022 13:57, Michael Walle wrote:
> The Kontron KSwitch D10 MMT series ethernet switches features a LAN9668
> SoC with either 8 copper ports or 6 copper port and two SFP cages.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  .../devicetree/bindings/arm/atmel-at91.yaml        | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index c612e1f48dba..e019e79f9551 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -174,6 +174,20 @@ properties:
>            - const: microchip,lan9668
>            - const: microchip,lan966
>  
> +      - description: Kontron KSwitch D10 MMT 8G industrial ethernet switch
> +        items:
> +          - const: kontron,kswitch-d10-mmt-8g
> +          - const: kontron,s1921
> +          - const: microchip,lan9668
> +          - const: microchip,lan966
> +
> +      - description: Kontron KSwitch D10 MMT 6G-2GS industrial ethernet switch
> +        items:
> +          - const: kontron,kswitch-d10-mmt-6g-2gs
> +          - const: kontron,s1921
> +          - const: microchip,lan9668
> +          - const: microchip,lan966
> +

This should be just one entry with an enum.

>        - items:
>            - enum:
>                - atmel,sams70j19


Best regards,
Krzysztof