Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965361AbXBLU1x (ORCPT ); Mon, 12 Feb 2007 15:27:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965318AbXBLU1x (ORCPT ); Mon, 12 Feb 2007 15:27:53 -0500 Received: from smtp.osdl.org ([65.172.181.24]:41238 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965361AbXBLU1w (ORCPT ); Mon, 12 Feb 2007 15:27:52 -0500 Date: Mon, 12 Feb 2007 12:27:38 -0800 From: Andrew Morton To: James Bottomley Cc: ricknu-0@student.ltu.se, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values Message-Id: <20070212122738.b5e9a8af.akpm@linux-foundation.org> In-Reply-To: <1171132062.3373.31.camel@mulgrave.il.steeleye.com> References: <20070210174628.3764.89569.sendpatchset@thinktank.campus.ltu.se> <1171132062.3373.31.camel@mulgrave.il.steeleye.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.19; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 18 > On Sat, 10 Feb 2007 12:27:42 -0600 James Bottomley wrote: > When discussion about TRUE and FALSE came up a long time a go in the > context of the mid layer we agreed to strip the defined constants out of > that code and just go with 1 and 0 inline ... because the code was > pretty much being rewritten. We also decided to encourage but not force > the driver writers simply to use 1 and 0 as well ... a lot of people are > deeply wedded to the TRUE and FALSE defines, it turned out. Given that we now have a standard kernel-wide, c99-friendly way of expressing true and false, I'd suggest that this decision can be revisited. Because a "true" is significantly more meaningful (and hence readable) thing than a bare "1". - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/