Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87fcba54-b54a-ea20-63ba-f447f4d34506@linux.intel.com>
Date:   Thu, 10 Feb 2022 16:43:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.5.1
Subject: Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support
Content-Language: en-US
To:     =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Wolfram Sang <wsa@kernel.org>,
        Raul E Rangel <rrangel@chromium.org>,
        Marcin Wojtas <mw@semihalf.com>,
        Grzegorz Jaszczyk <jaz@semihalf.com>, upstream@semihalf.com,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        "Easow, Nimesh" <Nimesh.Easow@amd.com>,
        "Limonciello, Mario" <mario.limonciello@amd.com>
References: <20220208141218.2049591-1-jsd@semihalf.com>
 <20220208141218.2049591-3-jsd@semihalf.com>
 <YgPdYw6hDoN198Hf@smile.fi.intel.com>
 <CAOtMz3OJNopHKgKDvGNfVWwvvo57=LyiRcnT+x6TxwLb+hgkyw@mail.gmail.com>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <CAOtMz3OJNopHKgKDvGNfVWwvvo57=LyiRcnT+x6TxwLb+hgkyw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/10/22 10:18, Jan Dąbroś wrote:
> śr., 9 lut 2022 o 16:28 Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> napisał(a):
>>
>> On Tue, Feb 08, 2022 at 03:12:18PM +0100, Jan Dabros wrote:
>>
>> ...
>>
>> I have noticed code duplication.
>>
>>> +     status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
>>> +     if (status) {
>>> +             if (status == -ETIMEDOUT)
>>> +                     dev_err(psp_i2c_dev, "Timed out waiting for PSP to release I2C bus\n");
>>> +             else
>>> +                     dev_err(psp_i2c_dev, "PSP communication error\n");
>>> +
>>> +             dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
>>> +             psp_i2c_mbox_fail = true;
>>> +             goto cleanup;
>>> +     }
>>
>>> +     /* Send a release command to PSP */
>>> +     status = psp_send_i2c_req(PSP_I2C_REQ_RELEASE);
>>> +     if (status) {
>>> +             if (status == -ETIMEDOUT)
>>> +                     dev_err(psp_i2c_dev, "Timed out waiting for PSP to acquire I2C bus\n");
>>> +             else
>>> +                     dev_err(psp_i2c_dev, "PSP communication error\n");
>>> +
>>> +             dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
>>> +             psp_i2c_mbox_fail = true;
>>> +             goto cleanup;
>>> +     }
>>
>> If you are going to update the series, consider to introduce a common helper.
>> Otherwise, consider a follow up.
> 
> Thanks for your comment. Since Jarkko is running some long-lasting
> tests with v4 patchset, I would like to keep this as is for now (and
> make a follow up commit). If there will be some additional comments
> for v4 from him and will spin v5 - I will introduce a common helper
> function then.
> 
Test run fine overnight, although I wasn't expecting this breaking 
Baytrail since patch is practically touching only semaphore detection at 
probe time on Baytrail. I'm up to you would you address Andy's comments 
as a follow up or as v5.

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>