Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2945767pxb; Thu, 10 Feb 2022 08:53:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2oEqaCxWCP4zthAubDiUIoO5L0EdJ6Zyxay98vp2zpjVQWA0nxGy0HiIAphdZSyT6toc8 X-Received: by 2002:a17:907:3f09:: with SMTP id hq9mr7369737ejc.32.1644511983161; Thu, 10 Feb 2022 08:53:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644511983; cv=none; d=google.com; s=arc-20160816; b=hRiVGwB2ZtgPS/lBVkAWQ6rTNCUjINYjlUtMpeGPXrWe7qK73bmzDRgDzUdiyvEr7+ kAi+IpTqOdRE17+O9v0Zxy7+qF+0UwV4JO41IaT3jInCrxL4L2Vy6qrkn1iz7dUtz4bP rR0OSsfZjs70921jGhJgQAQUmKCWKJ76jYVAlAiOvY07dBs9b5ogoOshBIx3Wdllc92q theIvPri/HNeL8ivzXulvHRjenEQ92ebsyrqek2/V4oH3ZjBfVsCJa8X651W5pqZD2pf M8e7kSw31oU0jP0A7t96/qxndWbnEMc6cyttUX0WtVA1WKBAIMUw5xe9OVJzcdHZihmB SM6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yFSefZtuKQy+rRIhxF1xA6U/rPoybWM9PhFAUBbHG4I=; b=woUhQaAlNQBC1pFqNipWX0F3Zpix7nt/bGaXJEU2K1dVFklfdn34g4VtAPZ3487n8l 5rK7xuRReGOba9S+fwC34rZpFjmynzdX4trAh4mG9ber8cMANav5qBvIBE/V9N0MgdUP RlsCAwuKJxZcUhEHo/KvdPgwuHytrnkQ7N9EJ5cHG8yAS9A7rPeFBs/LgDaYblv4aX28 lMNtwVwWkQXRmpnpr3Y882zvCPrEUwnQkENQPFoEFFWz7gqiPXcnX2ltuiX7MDFb4D85 YXKJoVrXt+U2pY6r7B2AdlBFtsag6FGoS/JOghBwd4gVPx/FEV5MsL9riccGm9xJhkYM vv6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=omKDqNLO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17si15990606edf.596.2022.02.10.08.52.37; Thu, 10 Feb 2022 08:53:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=omKDqNLO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244076AbiBJQNa (ORCPT + 99 others); Thu, 10 Feb 2022 11:13:30 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239586AbiBJQN0 (ORCPT ); Thu, 10 Feb 2022 11:13:26 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35F3BEB; Thu, 10 Feb 2022 08:13:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D909CB82502; Thu, 10 Feb 2022 16:13:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E2B2C004E1; Thu, 10 Feb 2022 16:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644509604; bh=yFSefZtuKQy+rRIhxF1xA6U/rPoybWM9PhFAUBbHG4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=omKDqNLOK28NXXBpI8y/0QKJdODpuPMxSBXgJitMG6FMucQbGqWziba50lf04oWmO NZupU4/tQ5M6BE+zCe13cWEvGoPCHXLlROWv9dbL0YhHb1ScBhKi9GoF5ZAQ8kJBZE o4/2JuEIFiq61S/7ttd9ZQj9elCt38NhyCPSYUADGDHJoMlN0tO/ooXJKk2+Lr77pc JaFyKR+ZgZuvnM4xEnIjsLsEqtW381pogJQM42X21sosnJ3OoHoz3abs2lq/6Aoznw L7l3hRa3GIikd2DIe8CzEO2rywLlJv5slLdehwZDFDCy/TOVBf+iov9aWUaVIrxqaV 2OzALRYnYl+Aw== Date: Thu, 10 Feb 2022 08:13:22 -0800 From: Jakub Kicinski To: Menglong Dong Cc: David Ahern , David Ahern , Steven Rostedt , mingo@redhat.com, David Miller , Hideaki YOSHIFUJI , pablo@netfilter.org, kadlec@netfilter.org, Florian Westphal , Menglong Dong , Eric Dumazet , alobakin@pm.me, paulb@nvidia.com, Kees Cook , talalahmad@google.com, haokexin@gmail.com, memxor@gmail.com, LKML , netdev , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Cong Wang Subject: Re: [PATCH v3 net-next 1/7] net: skb_drop_reason: add document for drop reasons Message-ID: <20220210081322.566488f6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20220128073319.1017084-1-imagedong@tencent.com> <20220128073319.1017084-2-imagedong@tencent.com> <0029e650-3f38-989b-74a3-58c512d63f6b@gmail.com> <20220209211202.7cddd337@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Feb 2022 21:42:14 +0800 Menglong Dong wrote: > How about introducing a field to 'struct sock' for drop reasons? As sk is > locked during the packet process in tcp_v4_do_rcv(), this seems to work. I find adding temporary storage to persistent data structures awkward. You can put a structure on the stack and pass it thru the call chain, that's just my subjective preference, tho, others may have better ideas.