Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 07:35:40 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v6 net-next 5/5] net: mscc: ocelot: use bulk reads for
 stats
Message-ID: <20220210153540.GC354478@euler>
References: <20220210041345.321216-1-colin.foster@in-advantage.com>
 <20220210041345.321216-6-colin.foster@in-advantage.com>
 <20220210103636.gtkky2l2q7jyn7y5@skbuf>
 <20220210152103.GB354478@euler>
 <20220210152712.jchztf34gf3pgsyf@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220210152712.jchztf34gf3pgsyf@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9Rv5++Q+65HCELKWCjfTM/wStuqB7snhvaw1O3gw5pwlzhcMONyXg/mRXZQl?=
 =?us-ascii?Q?Dr6FQYpz+ECe2BfOAPN/ng7ONOaNtPj7Q9951eYg9+sPyFdS1EXnL9Rp2Z4N?=
 =?us-ascii?Q?yLIZFSD42TJVO55AL3HRLVYJfOZX6fqc0JCo/lb6ZoZDm/KD4Q6valkE1GO7?=
 =?us-ascii?Q?zw32AMVOiQIYidVKHyo5CCuWlGzjevRZwFaDRqBN4PY3nNm7DvUmTOehych0?=
 =?us-ascii?Q?EiI1lCvOJOF9vqrx3srJnWRJo+GupxdkHk0COh3sMmTkE0EE2sHaAYqXrgsf?=
 =?us-ascii?Q?vigQDoLUd7Nxoc+ze3gtoeqmUthKzIiEC9HbaWay9a7hqLJ6eZ/4ek2SlfLu?=
 =?us-ascii?Q?wjKWjdARtJMXIM4C/njGTyR4nUvXAV0m8yqojHrPyednd4LkaIuZozUZUTzA?=
 =?us-ascii?Q?oNjnAMkjGiJ5XUQaCRFKggpIwWLUXHt/Fdfc8gy8cmfNmziZQ5ph08nsFz0U?=
 =?us-ascii?Q?gdwX3gsj452ny4rurqMsohxFuQDPt3YP/iBH04db1uwTgznleaiI8nzM5TJi?=
 =?us-ascii?Q?sanBvbWbHsLGZxV+nLiJazL24XoqHP8iuS31sAIh8Su7duIWyaDzOYRePv2Y?=
 =?us-ascii?Q?lkY80VhtT5k1aI1Xf69LbDZs3Ujz4to8URfRrqM1QU2cLspUp9dP4e4x3z5p?=
 =?us-ascii?Q?sAdSXqeTogbqgkfpVUNnx9QSpQOjjbvvAX2/7/or1/f5dAd1EpKOaervzuxN?=
 =?us-ascii?Q?b8BO3QEaZatFKsntehwCRgifn52qgnvlyXSX7HyfaIgUtAg4MltqY0V+Efud?=
 =?us-ascii?Q?7Knb/Y9fmZATI7Lt+4xwgVE0bkRNeLVr76sxNkTtaINHUqcapjjCkYspkv3P?=
 =?us-ascii?Q?0ecc1s29TAf17CY17zYre5X1DEf6RBclZrht+gLwQ8FLR7bWBZfamgi6CvWX?=
 =?us-ascii?Q?lZVdgYNML+2T6rlm3aBM55LPoexk7cndzj79mrxFgM61eRUcp4A8mTCGkpEb?=
 =?us-ascii?Q?Q5EBwyYenCDFIkTz2WrGyB+YxPq1vA4fdPJnC8GCtlcDfy4DT50aNQVxYsnM?=
 =?us-ascii?Q?aSI5wQlRJIhgtbIYObNrKnm6os8YZahZ9Af/o8jJa3IcVa+kf++7Jl6GyL4Q?=
 =?us-ascii?Q?SKsnmXRmJt6GwalVY4AekGDSdW///lryUkoDqjutGx9X4PZ1ZcyaSilLp37E?=
 =?us-ascii?Q?RwhEB88U5KjSb3ho9dwvn/ABwWPD2KIgQXxNMHJtHsGY6J5Prk41Zkojsft6?=
 =?us-ascii?Q?0++Rl1yf1ZZKlHmh6S2Ws2tdAIGZXjRHe/njdHD1wTdMLnsAHjRwI59ehCcJ?=
 =?us-ascii?Q?MQIm+AKDV4c73jIyznh8Tm5exKl5DJVPPcZiH/2ggfXZEKM9zguI8WxD/iCa?=
 =?us-ascii?Q?pviJh9eosswaHVawckctbZSifcq9NklxuqaqY1YlhinMmnpkwtZnZXcFQkos?=
 =?us-ascii?Q?6kR82vAE+Fkp4ZSpiS51Xemvjd5CNnUdL1YNGUJE+DSYZ1Tgf0swWE6GDfuW?=
 =?us-ascii?Q?ed3Ghf2KwR/DUgLfy0yV+ySGuePphShMiF1/07MVOZzFTdfvHbZUhM/4FHfy?=
 =?us-ascii?Q?AgsKfQVMaYNGro9YJLGTUxS667CS8WbQgLKmDa0pYnMDVGdl9YuIGQZrv5bC?=
 =?us-ascii?Q?99xwFosZlJJAIN3q8ODX60a5vUgXl+WD23nfiMCEceaNaE+OyhCQZMvzc1UV?=
 =?us-ascii?Q?GZ5EfG8oVz2Hcza8fbTiEiBgQMv9SlnoBCgF+Ocd5jlNOont5n31bjpw34Aj?=
 =?us-ascii?Q?WDe//3pShFCJb5mvsfbSw/q2oqM=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0b06cc-3b5e-4146-19c6-08d9ecab003b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 15:35:44.8008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C2huxfnJJ+q1sAkeqer5Dbwk4QqH/eXys/wSH2NrQqh+pw2ML08tR7iXqRt62yie3yR+2QKcoGeJR0OFVG4s+f50A1COQWso70UnIhK9UWc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3307
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 10, 2022 at 03:27:13PM +0000, Vladimir Oltean wrote:
> On Thu, Feb 10, 2022 at 07:21:03AM -0800, Colin Foster wrote:
> > > ocelot_check_stats_work() should also check for errors.
> > 
> > Another change I'm catching: I assume calling dev_err while holding a
> > mutex is frowned upon, so I'm moving this err check after the counter
> > copy / mutex unlock. I'll submit that fix after patch 1 gets merged into
> > net / mainline.
> 
> Where did you read that? Doing work that doesn't need to be under a lock
> while that work is held isn't preferable, of course, but what is special
> about dev_err?

I didn't read it anywhere, just a hunch about string formatting
overhead. Either way - not necessary to do inside of stats_lock, so I
moved it out. Next round will hopefully be early next week.