Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S . Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        linux-mmc@vger.kernel.org,
        Pali =?ISO-8859-1?Q?Roh=E1r?= <pali@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v9 05/24] wfx: add main.c/main.h
Date:   Thu, 10 Feb 2022 17:37:51 +0100
Message-ID: <2534738.AP0T11PbZZ@pc-42>
Organization: Silicon Labs
In-Reply-To: <87a6ey3d0e.fsf@kernel.org>
References: <20220111171424.862764-1-Jerome.Pouiller@silabs.com> <39159625.OdyKsPGY69@pc-42> <87a6ey3d0e.fsf@kernel.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?X8riKY7zQJ9pEza02PoeEwfR8pX51fVrA4sVvXf42gz0A2Ft4t0pE4svHO?=
 =?iso-8859-1?Q?d5nlSngZswA1LaWrvySO7FwHurEeP21SW8Mj0iaW1cn18fVQaOLQfmyFIY?=
 =?iso-8859-1?Q?XBjggXIv5z/TbmgZfaZVrj0uTPnO4JU8hQB/xpeAtl755GJ9Uib3m+uiTg?=
 =?iso-8859-1?Q?GTpd59B6cBvz0bFxZWmLiBpTcJXZ6ZFZiZB0lXvhIHuqb1fMpL/JEtksYS?=
 =?iso-8859-1?Q?oYK23+jolVMdeF3Zj4rSPcG21TCGRbTa6MFRr+8dPiu/0n3cPK6+5G4aQi?=
 =?iso-8859-1?Q?sHPoxyYe9/qmX7Lph6A+r9W5BVqrCJkonuFn/2QzwOZbuEutjGdpXukMNY?=
 =?iso-8859-1?Q?3ZCFaKx6dujmLgn1/9/FkoPIUgimmIsuIjOawLcI5dhDbBVrXUuZfZsC0v?=
 =?iso-8859-1?Q?2EruMLlXLqN/sqTdUVcixLhmbs2dhzHPQ2SjGJEzoaisPQcsEymB5odt6C?=
 =?iso-8859-1?Q?Zu6mRiTumuDpctEJ36xMyzCG5sN3p4KNVLuhcn+zsWOimOBk/wrFhc+eR9?=
 =?iso-8859-1?Q?+XEhOJTxAvmzzgXp4w2frcxLoa87DeKlYdrvrzicgIPqB9FpZTwdg+phSo?=
 =?iso-8859-1?Q?b6XjY4nTPJ0gkR8vjB53YkiHkKCF2u3fTi8JLn6nT8kvxRUisspDfJSy1h?=
 =?iso-8859-1?Q?1iVWt1BlQkSpV+JmLx3sKeNmjDj2vETCkjF2z/74VuDT0dBexIvVmnE8Gw?=
 =?iso-8859-1?Q?SV7YoFZb1/p8hNo1PW2HmHKgA04owDRaf+47b2gPJc9JIRRzJ8Ow8NaInz?=
 =?iso-8859-1?Q?saUpcpLc/QydTkO0Zbx67cUDcqlR7Vn0oHZGg2vF02YIQPXdWasHyQVsDr?=
 =?iso-8859-1?Q?LdfQ4zKx2XaHt7VFjFgoHn+vR7dQoLV2Rwu/7vGxZwZJnDZ/uXFuxYzGzN?=
 =?iso-8859-1?Q?tdwRQltR0whMrvsVgnc+Eaad7d+c0YK0gOX4/ZbwCFS+dbzEZjao5n58xB?=
 =?iso-8859-1?Q?to8kXKHY4dOMsghSwqB2FtKifvDOUQJbmVorgxIYNpbFRQcxjM4qq1a08y?=
 =?iso-8859-1?Q?gA+jVTCDTTXe55SuqND08aZuRmty2h6MeVBCnIJ4QqLMEPz5F7W2Ei4b7l?=
 =?iso-8859-1?Q?eccA57clhYXkYB62/wzkk4907IZN+mA1aEPIeeIz+Q+SFcg4uvCmumo7x4?=
 =?iso-8859-1?Q?mOnGag7tQ1rwc4a5/z11Un8R7LpYfPdULY1r9VFqsk8XUTEjUXjGximnej?=
 =?iso-8859-1?Q?7H+iZ1i6ddsYMmZCvIyh4DIpmYyi6rPZKeD8I9PxaUcIox3BsEdFL4/+Jj?=
 =?iso-8859-1?Q?BWvFubdJYK7Iooznxl70cC6T8+aSPUgSws9cL6eJSsGXxN2oF6SirUdU1g?=
 =?iso-8859-1?Q?W81tw6MvleUWkoIHilTZEw0i65ekouGGKltetzcwb2sWNP2VmdGFXgix+v?=
 =?iso-8859-1?Q?/wmlANL1awmQoQ0u7RUx/oECK7IRgfWUUDTPd89TtCLGclkPzEOZwgb89y?=
 =?iso-8859-1?Q?qiucx++q122HlJWpcPq/qaKvAK1I5hLR7aEsteCZAbt1R2cRrF0wA1XJKh?=
 =?iso-8859-1?Q?vF6MKtKrw99d9BAFfDpjTOFQIoG+p/y7zUVrQ7TGEnel26Xz+VZuTWfipq?=
 =?iso-8859-1?Q?R56K+OyLTKtAAim6CGK4I4B2bL1P9FdANqRZQKcg6Wb+ejbKdCF5olVhgj?=
 =?iso-8859-1?Q?yhLCM7p6fbNZ9zVSvcFrnKs4jj02+PG2Lc2VVX1LCVaHLIMvIo0OP6P+6o?=
 =?iso-8859-1?Q?9/dwsfSa1g8Q2uLRsV8=3D?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a62a4f3-e030-4c6e-d245-08d9ecb3b30d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 16:37:59.9790
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iaUJdvj17JAAD4H1Wy+d0NBFLOpFMZ3UCMbzEtsv2GTd4THgunx3klKBkt1UXivwR2q7UMegTXtk97DvVfmDDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1339
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 10 February 2022 17:25:05 CET Kalle Valo wrote:
> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
>=20
> > On Thursday 10 February 2022 15:51:03 CET Kalle Valo wrote:
> >> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
> >> > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote:
> >> >> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
> >> >>
> >> >> > Kalle, is this function what you expected? If it is right for you=
, I am
> >> >> > going to send it to the staging tree.
> >> >>
> >> >> Looks better, but I don't get why '{' and '}' are still needed. Ah,=
 does
> >> >> the firmware require to have them?
> >> >
> >> > Indeed. If '{' and '}' are not present, I guarantee the firmware wil=
l return
> >> > an error (or assert). However, I am more confident in the driver tha=
n in the
> >> > firmware to report errors to the user.
> >>
> >> Agreed.
> >>
> >> > If there is no other comment, I am going to:
> >> >   - submit this change to the staging tree
> >>
> >> Good, it's important that you get all your changes to the staging tree
> >> before the next merge window.
> >>
> >> >   - publish the tool that generate this new format
> >> >   - submit the PDS files referenced in bus_{sdio,spi}.c to linux-fir=
mware
> >> >   - send the v10 of this PR
> >>
> >> I'm not sure if there's a need to send a full patchset anymore? We are
> >> so close now anyway and the full driver is available from the staging
> >> tree, at least that's what I will use from now on when reviewing wfx.
> >>
> >> What about the Device Tree bindings? That needs to be acked by the DT
> >> maintainers, so that's good to submit as a separate patch for review.
> >
> > There is also the patch 01/24 about the SDIO IDs.
> >
> > I think the v10 could contain only 3 patches:
> >
> >     1. mmc: sdio: add SDIO IDs for Silabs WF200 chip
> >     2. dt-bindings: introduce silabs,wfx.yaml
> >     3. [all the patches 3 to 24 squashed]
> >
> > Would it be right for you?
>=20
> TBH I don't see the point of patch 3 at this moment, we have had so many
> iterations with the full driver already. If people want to look at the
> driver, they can check it from the staging tree. So in the next round I
> recommend submitting only patches 1 and 2 and focus on getting all the
> pending patches to staging tree.

Ok.

> And the chances are that a big patch like that would be filtered by the
> mailing lists anyway.

I believe that with -M, the patch would be very small.

--=20
J=E9r=F4me Pouiller