Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 11:04:36 -0800
From:   Keith Busch <kbusch@kernel.org>
To:     Nitin Rawat <quic_nitirawa@quicinc.com>
Cc:     Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
Subject: Re: [PATCH v2] nvme/pci: Add quick suspend quirk for Sc7280 Platform
Message-ID: <20220210190436.GA1658231@dhcp-10-100-145-180.wdc.com>
References: <1644512104-24035-1-git-send-email-quic_nitirawa@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1644512104-24035-1-git-send-email-quic_nitirawa@quicinc.com>
Precedence: bulk

On Thu, Feb 10, 2022 at 10:25:04PM +0530, Nitin Rawat wrote:
> Enable quick suspend quirks for Sc7280 platform, where power
> to nvme device is removed during suspend-resume process. This
> is done to avoid the failure dring resume.
> 
> This enables simple suspend path for this platform.
> 
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> 
> Change from v1-v2:
> 
> *Moving the check condition outside vendor/device check
>  to make this platform specific
> 
> ---
>  drivers/nvme/host/pci.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 6a99ed6..fa25d9fab 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3032,6 +3032,13 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
>  		if ((dmi_match(DMI_BOARD_VENDOR, "LENOVO")) &&
>  		     dmi_match(DMI_BOARD_NAME, "LNVNB161216"))
>  			return NVME_QUIRK_SIMPLE_SUSPEND;
> +	} else if (of_machine_is_compatible("qcom,sc7280")) {
> +		/*
> +		 * Append quick suspend quirks for sc7280 platforms
> +		 * so that simple suspend path is executed for this
> +		 * platform to avoid any resume failure.
> +		 */
> +		return NVME_QUIRK_SIMPLE_SUSPEND;
>  	}

Did you test this? Because I think you said that this is the Kioxa
controller matching the vendor:device in the previos "else if", which
means we won't reach this part.