Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Feb 2022 23:33:36 +0200
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     Rob Herring <robh@kernel.org>, Dong Aisheng <aisheng.dong@nxp.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Fabio Estevam <festevam@gmail.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
        NXP Linux Team <linux-imx@nxp.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        Jacky Bai <ping.bai@nxp.com>
Subject: Re: [RESEND v4 05/10] arm64: dts: freescale: Add the imx8dxl
 connectivity subsys dtsi
Message-ID: <YgWEsHZHqDK1sCYz@abelvesa>
References: <1639680494-23183-1-git-send-email-abel.vesa@nxp.com>
 <1639680494-23183-6-git-send-email-abel.vesa@nxp.com>
 <20220126124732.GR4686@dragon>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220126124732.GR4686@dragon>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K7noT6TCaNbmqgJKrnCrbeyRnoxfid4QOR438MXVgRKXJgFjvk1MzU9WkPcV?=
 =?us-ascii?Q?5I4O0jS5INFxzLUJVl7ASyzJMJQRYaX9O8TS/uiIhnKpu09AQWHXjcGj0to7?=
 =?us-ascii?Q?QOW7o+m+tDcBMAZpLz3kPJlvaZkCF4E0UuRo/0uPmPWBHT89GLmBCkvu7SfV?=
 =?us-ascii?Q?B0Op34G6+nNpwnGH+fqf4SYh5fbWHwxORuSnePQ7KomoQiJtaTO5el6whvm2?=
 =?us-ascii?Q?VqH1WsV4ATVDAz0/PXYmrCRwpogL7OhXYrDaOqmLl73Zke6QqwzD1n1hN9tw?=
 =?us-ascii?Q?QI3Iz5ge8kkowdt91rpzBXaOOSroCk8TW5FRT2dEtxPKU7sywrGMFJ3TF+5E?=
 =?us-ascii?Q?zZZqnFA0rZhkf68AfbrY2FKIfuv0Ew+zM8sotx0k0RP6TMCYR3EOQEshwCQd?=
 =?us-ascii?Q?GcPhosJvTjSxLXHs9g7FnmfvKGoaZrGG7kE7A/FHcIAlxGIO0AXiLkl9Ivox?=
 =?us-ascii?Q?1HptVCethBZrEWEDjG0wY+vJdEsVA8j0iM9rkDBMdL8IM9Dh66sJGHeQGeDx?=
 =?us-ascii?Q?PJa5jVtrfCiRKc51b08kMVOUC7w/xgn0saChA2m6NvNe69awD5j3OiI68+PA?=
 =?us-ascii?Q?x4mD2xj48TRSOAtzhyWzyxmxKpEHXJwH5ZhO1cVj8oLctgMNLlaiHMrITEvK?=
 =?us-ascii?Q?Z0Y7DiRrjIdZy9Wv6DVicWfNdc8iY7sqNhsRXcNgCi1am2hxHys+ESBmPsJZ?=
 =?us-ascii?Q?94VckzdzStYf5sk31iR9Ao286KoOUkcAoJSAJyhvAcPKa3IKKqd/krJx3wjG?=
 =?us-ascii?Q?XG/wJ1pjOFbGZ7V6SYX0sWcEQUrn0yPOv24GmVB21u6CP2R2KgI5MS7P4+Ne?=
 =?us-ascii?Q?uweTeEi6ZZb5YpERcTyy7puasu8dcOAnxn5FtOIOeIDeWmyQHx/C8w1lw4Uf?=
 =?us-ascii?Q?1osiVFNVtGnK8jBcHZAr4MCjRTR4MPEDdiHcPwV6x7Qw3eeB3T9SELaSuRPO?=
 =?us-ascii?Q?8jQSIkWlAzyNgf6b1gagWsNOuJCfah7lUBKnL++OLAwBxouscIYkwmwtsJIK?=
 =?us-ascii?Q?qr6g8MlRYjndDFIt+wEIUIhUki8nv0dqCQZsmulzggHI97QEbN4J9kAZvnI+?=
 =?us-ascii?Q?QFOstVMLKMQoPFqSwSklMFuoJX2Dky5SYMDnO+JFqR3VVChhm/g6B86Im59Y?=
 =?us-ascii?Q?dgKwHcn1bzEBhvy4Dzp8yEtSNJJygRMrsZxW9X7wNPgBgaIhPCk0AxeVKWEs?=
 =?us-ascii?Q?S3Qms5fZjAXxQch9Zwgo6Tszjs8/Q2CpadVJnDrxg57eZFmNjFG6I0tEpMoL?=
 =?us-ascii?Q?SMRwjYRS9iSvPPrFPY8K4USDSeCYoZc1zYSClJLkjFRgEGFW3Jzm67hC50uL?=
 =?us-ascii?Q?YJoORDXcAZHYJz/8XNwWrW2hrAIybYeCHI/bDM9KO1GSU0y8/Ka0F+RLftXs?=
 =?us-ascii?Q?wNVizDvcMkD0/1qLZx5MxRBPdKwAO2338VWX3Tt+Z8UfAmQQp9UC+U3timTK?=
 =?us-ascii?Q?B0mZpW6aQNB/mRkaVXh25E+a0eT057vxOwfRWhY/0WjxsxBaYIDIqzukf3Pc?=
 =?us-ascii?Q?tZtjhB6oEP9ukOLzjJ5ZNhHoz8bE/+1BdBGv9PPMpkcmttGBtmOcpu5F6enA?=
 =?us-ascii?Q?/N972f8ty4t6tbK+9UjPIkh2c336BgwR0ER2pnKWCxC71WT3xu41ad6ZU+oE?=
 =?us-ascii?Q?Svah1Hep6FFDigl46TnsqBU=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88862aed-b2e0-4d40-d0a5-08d9ecdd0053
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4679.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 21:33:38.8462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tDksEAWXe0WyaMUejAkQlmPkAacLhGMU1bfqy5cbvOVt5GxSFT2sVd7cY2pMuGKRJ0vz23emqqbFmbEgZVzrhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6075
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-01-26 20:47:33, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 08:48:09PM +0200, Abel Vesa wrote:
> > From: Jacky Bai <ping.bai@nxp.com>
> > 
> > On i.MX8DXL, the Connectivity subsystem includes below peripherals:
> > 1x ENET with AVB support, 1x ENET with TSN support, 2x USB OTG,
> > 1x eMMC, 2x SD, 1x NAND.
> > 
> > Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >  .../boot/dts/freescale/imx8dxl-ss-conn.dtsi   | 137 ++++++++++++++++++
> >  1 file changed, 137 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
> > new file mode 100644
> > index 000000000000..b0059296a03f
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
> > @@ -0,0 +1,137 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2019-2021 NXP
> > + */
> 
> Shouldn't we include imx8-ss-conn.dtsi here?  Otherwise, the
> /delete-node/ and &conn_subsys reference below looks baseless.
> 

Nope. The way this works is: imx8dxl.dtsi includes both
imx8-ss-conn.dtsi (the generic part) and imx8dxl-ss-conn.dtsi
(the imx8dxl specific part), in this exact order.
And same does imx8qxp.dtsi. It includes the imx8-ss-conn.dtsi
(the generic part) and then includes imx8qxp-ss-conn.dtsi
(the imx8qxp specific part). And so on.

All other comments will be addressed in the next version of this
patchset.

> > +
> > +/delete-node/ &enet1_lpcg;
> > +/delete-node/ &fec2;
> > +
> > +&conn_subsys {
> > +	conn_enet0_root_clk: clock-conn-enet0-root {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <250000000>;
> > +		clock-output-names = "conn_enet0_root_clk";
> > +	};
> > +
> > +	eqos: ethernet@5b050000 {
> > +		compatible = "nxp,imx8dxl-dwmac-eqos", "snps,dwmac-5.10a";
> > +		reg = <0x5b050000 0x10000>;
> > +		interrupt-parent = <&gic>;
> > +		interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
> > +		interrupt-names = "eth_wake_irq", "macirq";
> > +		clocks = <&eqos_lpcg IMX_LPCG_CLK_2>,
> > +			 <&eqos_lpcg IMX_LPCG_CLK_4>,
> > +			 <&eqos_lpcg IMX_LPCG_CLK_0>,
> > +			 <&eqos_lpcg IMX_LPCG_CLK_3>,
> > +			 <&eqos_lpcg IMX_LPCG_CLK_1>;
> > +		clock-names = "stmmaceth", "pclk", "ptp_ref", "tx", "mem";
> > +		assigned-clocks = <&clk IMX_SC_R_ENET_1 IMX_SC_PM_CLK_PER>;
> > +		assigned-clock-rates = <125000000>;
> > +		power-domains = <&pd IMX_SC_R_ENET_1>;
> > +		clk_csr = <0>;
> 
> Is this property documented anywhere?
> 
> > +		status = "disabled";
> > +	};
> > +
> > +	usbotg2: usb@5b0e0000 {
> > +		compatible = "fsl,imx8dxl-usb", "fsl,imx7ulp-usb";
> > +		reg = <0x5b0e0000 0x200>;
> > +		interrupt-parent = <&gic>;
> > +		interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>;
> > +		fsl,usbphy = <&usbphy2>;
> > +		fsl,usbmisc = <&usbmisc2 0>;
> > +		/*
> > +		 * usbotg1 and usbotg2 share one clcok
> 
> s/clcok/clock
> 
> > +		 * scfw disable clock access and keep it always on
> > +		 * in case other core (M4) use one of these.
> > +		 */
> > +		clocks = <&clk_dummy>;
> > +		ahb-burst-config = <0x0>;
> > +		tx-burst-size-dword = <0x10>;
> > +		rx-burst-size-dword = <0x10>;
> > +		#stream-id-cells = <1>;
> > +		power-domains = <&pd IMX_SC_R_USB_1>;
> > +		status = "disabled";
> > +	};
> > +
> > +	usbmisc2: usbmisc@5b0e0200 {
> > +		#index-cells = <1>;
> > +		compatible = "fsl,imx8dxl-usbmisc", "fsl,imx7ulp-usbmisc";
> > +		reg = <0x5b0e0200 0x200>;
> > +	};
> > +
> > +	usbphy2: usbphy@0x5b110000 {
> > +		compatible = "fsl,imx8dxl-usbphy", "fsl,imx7ulp-usbphy";
> > +		reg = <0x5b110000 0x1000>;
> > +		clocks = <&usb2_2_lpcg IMX_LPCG_CLK_7>;
> > +		status = "disabled";
> > +	};
> > +
> > +	eqos_lpcg: clock-controller@5b240000 {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x5b240000 0x10000>;
> > +		#clock-cells = <1>;
> > +		clocks = <&conn_enet0_root_clk>,
> > +			 <&conn_axi_clk>,
> > +			 <&conn_axi_clk>,
> > +			 <&clk IMX_SC_R_ENET_1 IMX_SC_PM_CLK_PER>,
> > +			 <&conn_ipg_clk>;
> > +		clock-indices = <IMX_LPCG_CLK_0>,
> > +				<IMX_LPCG_CLK_2>,
> > +				<IMX_LPCG_CLK_4>,
> > +				<IMX_LPCG_CLK_5>,
> > +				<IMX_LPCG_CLK_6>;
> > +		clock-output-names = "eqos_ptp",
> > +				     "eqos_mem_clk",
> > +				     "eqos_aclk",
> > +				     "eqos_clk",
> > +				     "eqos_csr_clk";
> > +		power-domains = <&pd IMX_SC_R_ENET_1>;
> > +	};
> > +
> > +	usb2_2_lpcg: clock-controller@5b280000 {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x5b280000 0x10000>;
> > +		#clock-cells = <1>;
> > +
> 
> Unneeded newline.
> 
> Shawn
> 
> > +		clock-indices = <IMX_LPCG_CLK_7>;
> > +		clocks = <&conn_ipg_clk>;
> > +		clock-output-names = "usboh3_2_phy_ipg_clk";
> > +	};
> > +
> > +};
> > +
> > +&enet0_lpcg {
> > +	clocks = <&conn_enet0_root_clk>,
> > +		 <&conn_enet0_root_clk>,
> > +		 <&conn_axi_clk>,
> > +		 <&clk IMX_SC_R_ENET_0 IMX_SC_C_TXCLK>,
> > +		 <&conn_ipg_clk>,
> > +		 <&conn_ipg_clk>;
> > +};
> > +
> > +&fec1 {
> > +	compatible = "fsl,imx8dxl-fec", "fsl,imx8qm-fec";
> > +	interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
> > +		     <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>,
> > +		     <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>,
> > +		     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>;
> > +	assigned-clocks = <&clk IMX_SC_R_ENET_0 IMX_SC_C_CLKDIV>;
> > +	assigned-clock-rates = <125000000>;
> > +};
> > +
> > +&usdhc1 {
> > +	compatible = "fsl,imx8dxl-usdhc", "fsl,imx8qxp-usdhc";
> > +	interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> > +};
> > +
> > +&usdhc2 {
> > +	compatible = "fsl,imx8dxl-usdhc", "fsl,imx8qxp-usdhc";
> > +	interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
> > +};
> > +
> > +&usdhc3 {
> > +	compatible = "fsl,imx8dxl-usdhc", "fsl,imx8qxp-usdhc";
> > +	interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> > +};
> > -- 
> > 2.31.1
> >