Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v6 net-next 5/5] net: mscc: ocelot: use bulk reads for
 stats
Thread-Topic: [PATCH v6 net-next 5/5] net: mscc: ocelot: use bulk reads for
 stats
Thread-Index: AQHYHjTfHymZJxNNSUWpsn5mKney/KyMl74AgABPeYCAAAG4AA==
Date:   Thu, 10 Feb 2022 15:27:13 +0000
Message-ID: <20220210152712.jchztf34gf3pgsyf@skbuf>
References: <20220210041345.321216-1-colin.foster@in-advantage.com>
 <20220210041345.321216-6-colin.foster@in-advantage.com>
 <20220210103636.gtkky2l2q7jyn7y5@skbuf> <20220210152103.GB354478@euler>
In-Reply-To: <20220210152103.GB354478@euler>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iyYSZ0GOT2XBlaxwgilkIxm3R/rdhJQZ0Ievd6xAJWSyFDNeoYBqbyNwst9F?=
 =?us-ascii?Q?uzVj77nCOWSz1g8kpbCtEKZja17KvhM0rSrP7fBBBlPR8DSVpnBs+DUs94qx?=
 =?us-ascii?Q?fMWTcXVMY2t/mkvHCSdf+ZTXUjP4yTEjhO9N4grZfUGQHEju+cf9mRH37O2W?=
 =?us-ascii?Q?zJBwsw0YtklK5EEWwruLJx2aKmSUI2Kq7jA1nYHI4pzwYkaOI/yzS9E1ObQG?=
 =?us-ascii?Q?174VvYgc8o5ns1pqUH4MdiEaZtWenFtbXYZP1pGGJa2HvwnwQoegFZkAAs+E?=
 =?us-ascii?Q?DxoAZO2SKnspZA+1vw1O13WDDpPczk21fRjyb6UoNQFOXhvFHTMl21fDtU+U?=
 =?us-ascii?Q?8sSoWWFzursZoPnHzP6xjxyGJw+QxbznhRFdaL08g/iiqKm6RkuCj1SZMvF+?=
 =?us-ascii?Q?aCzfRkO18GVC/elU++o4lO3awqn0qwIflgCvFDAhhOFyOiP5/c35k1IeQlya?=
 =?us-ascii?Q?RlGhQVcdiphEkXh56so2NpNQ6xdAYNajjv2+qHYRoGYI9vCi4cKFjQBgANNi?=
 =?us-ascii?Q?LceaDo+n1jz8HXUTPaufKoFTlhjT0LLZbsSbC1VsbIKTBP6c6+eUYfI1HHeR?=
 =?us-ascii?Q?F9dDeHESrAHCKTuuNroOR2GCyp/Y5QT0QZEayytrr6akU741vjPkhepI8VRK?=
 =?us-ascii?Q?b9J5XFUh6A4uOBmljHZhJacCD2LcWGIrC8cmpa70WN3qZTNqW41RBYXJijEh?=
 =?us-ascii?Q?aA31yGR7Mp1x3P4KSEpwPjDAcxV5Ge5KIDwaZpsv3WfdirtsMV57fp52oZ8V?=
 =?us-ascii?Q?ZCpg+Si5aZ0vw2sMsQPvUFb58BCgZ26XysEo8MHyB5uGlCwF94QrgUK4FYvb?=
 =?us-ascii?Q?XCNWF6jzCihnJJkqx/3ecob9XdPDtnuSyQfFnn01IQ4RADKmmCC5mAzo2PG/?=
 =?us-ascii?Q?G+1IlJeVZs+Rdc7qyCAF909RLuMXQlG4ynVj3YC+ywiS28Y8xEb95YrBOgmS?=
 =?us-ascii?Q?Yt3Ryfe3P2LKj2sCHO+kx7mTe081Kh9aBGCSmlN9FJLnZ9RIUvLA2zgegPHy?=
 =?us-ascii?Q?v6qtMgS29uF1bjTG22DcLZadzYTpNpLhAAqnY51cq0eokZN5IsRmdQ6mJmQe?=
 =?us-ascii?Q?7XiEZhS+MoVL5on1XRH5jXdSBBuciYu0AKoCw3bw1T+8/R/8vrrrU/xA38gy?=
 =?us-ascii?Q?7pNcTvYOj92jBtqp9j8y9Vc4gRHThct6u43InGoO9Xocl13i5pgH9X+7NWdZ?=
 =?us-ascii?Q?bfNzUpX0eLNfPg/bWJH3H2N8Ov7y+I3+3I/XIgNf9XXpLsFF/86//Y6Yl49T?=
 =?us-ascii?Q?fY/tR9Mne1p4xhJ0P579yZw5qbVwIX7BpVoQP9aFXcliGlgEELKaGXmKeP6J?=
 =?us-ascii?Q?Z18mS36gS7mSJ3B20VZv4T/runCLSENA0U+NBILsh62wJmBy3osCryDvRLY0?=
 =?us-ascii?Q?yMzEWMNJjDrYiTCWO1oRBU2p4AWuAcpOb2UXTjGXG5xxzRLFY+WYL18OPfRM?=
 =?us-ascii?Q?LzpcmopHhe6NP9QQ4l8/L8enpNBqGg3vXxgJWoEh2iIa0CzTY2LcZaDtISLN?=
 =?us-ascii?Q?Y98OKc/HB/fEsFRnuq35dZqkb+IQIHvrHPQbZVXASIhaNAVtY9z5YP7BmXgo?=
 =?us-ascii?Q?rFg0xh4cj/ySH+FjS+zakk5JKhIJD3nnfM8SKokIQ8XoSUZ4qqxFFX9tfvoG?=
 =?us-ascii?Q?8I0yWSE/bSrvKm7WAh8Jt63sXcYbDqGrKTU7SNcm0ySX?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F1D8F08F6FD55C4C93ECB7AB6154E32B@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d6d6293-33a0-4211-5904-08d9eca9d012
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 15:27:13.3033
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1jeVoBiVqy7NVOAYhl2rTH2yEPSQir063AoSa/ta1ez6Uv722nqHMhI1MHEUqg/hFVkpYAiUIuH1N/518RLmEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4730
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 10, 2022 at 07:21:03AM -0800, Colin Foster wrote:
> > ocelot_check_stats_work() should also check for errors.
>=20
> Another change I'm catching: I assume calling dev_err while holding a
> mutex is frowned upon, so I'm moving this err check after the counter
> copy / mutex unlock. I'll submit that fix after patch 1 gets merged into
> net / mainline.

Where did you read that? Doing work that doesn't need to be under a lock
while that work is held isn't preferable, of course, but what is special
about dev_err?=