Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3265223pxb; Thu, 10 Feb 2022 16:52:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTXimCKJujVPywuhJMN1BhDf/acu98T7zrqyn6s5noX2F4YUQLAHbHcGf4nStRNpwwJfuv X-Received: by 2002:a17:902:f612:: with SMTP id n18mr9869966plg.102.1644540759092; Thu, 10 Feb 2022 16:52:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644540759; cv=none; d=google.com; s=arc-20160816; b=COV0tJFgwO29Vm1/8dIoxujXTDURRrnizuJ54oQxL2a08kbCcx0lppiDW8vgp/QwVv VKDgoQyOUtMIeyxJNxtouu17gZPSVFsyEIl2YOCdc+RvghXWxckn/Ce27tz+oKX2omvq SQ0lr5ppgfeiN1pXlwSSwlCirmJIcn8lDW9ufSWhydjW+fMD86MuCYaBIyQv2V9TnxS7 Q5y/PuiuBpZXQVawoKNgBJo7U1nEaTeQvK6tpHv4kcEffU6f2ZF83ZjJFRQEXeUOb1y4 d+jMYBD7Heu+5pmDuu6DGKupp/Gf8HLwA6RhQtR9XOiv2xvu1EJslcYl95StfglNVExs Qh0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=rY3phGFyqzvqC5XqBvgZRHwWvJirMd+irMKZuvfo6EI=; b=L4M/VL1eDloW7RcNCLIeSc6Kf7+c2g7B0D7xsQc55h7Ww5pMnaYfIob7Hl0R8xMbZP NuSDLJ28uV8NWwM01QNbntusv5pIWR96DB4sYOrNvn3CCp6n6r8yF70fr8od85VgeizR lPW+Pe8IUB9IfvHnsOxDWL6hEmhWxB+9IWwGKmmJtktXbiWFJqs54xU2KbB82VNpjYHs 70oYql6JN8q3V78NQ5at1wCS7ZT6Ncm2j2QtF1a8Bfa6xiRGQFPRz/9hAPh8VzSWAhz0 lFdB3Cpx6kzA7TL2xnnA/BCSSD2K61IsQqXYj8PimePEDDCw1NXSmBzgWKbLpC7zSq2c ufPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MY5TpNx9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j72si2909093pge.872.2022.02.10.16.52.27; Thu, 10 Feb 2022 16:52:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MY5TpNx9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244193AbiBJQ0n (ORCPT + 99 others); Thu, 10 Feb 2022 11:26:43 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244177AbiBJQ0k (ORCPT ); Thu, 10 Feb 2022 11:26:40 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 544C2CC6 for ; Thu, 10 Feb 2022 08:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644510400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rY3phGFyqzvqC5XqBvgZRHwWvJirMd+irMKZuvfo6EI=; b=MY5TpNx97fcJ3wiV/4Ov1NVh+PgOh8buMoGlUNCBSYSBXOWsSQMpDGEFC0GCZJvKBmDjo2 FHgRh/EaiIXioo6yP03EAFQ+AHa+CQNb5WAiVUl8npEWej39ifd2OxV352VUyWO2ntpZE9 ZMQvkjugiJucKsB5SJZlDHrMETWQ51s= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-364-NiKtVzJLOUyC7tiPHOP9Yg-1; Thu, 10 Feb 2022 11:26:39 -0500 X-MC-Unique: NiKtVzJLOUyC7tiPHOP9Yg-1 Received: by mail-lj1-f199.google.com with SMTP id bd23-20020a05651c169700b0023bc6f845beso2791028ljb.17 for ; Thu, 10 Feb 2022 08:26:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rY3phGFyqzvqC5XqBvgZRHwWvJirMd+irMKZuvfo6EI=; b=iLNORUZ2ZbBXTzrNUtfRGv+CMt+mEKJBXudLvt4WpbRCeq8iSzVEcjAU4q+CXjQ6fA UrbrZ3YgzqiCgqFnMKQsxixOCg96H7VU/dI+OmfV8UWci6W449aN/SMWQUDVsKdr4Hmh Q1qc72elMGbiEDe3MBIXhf2HzTVWepiW3b92ik47VahvQXkOp0tLrJr3EsdLl02gAT9B EBChWglHHDpk5pof+1W7gTYvBLkDiiQ97L2wUMEGRctDxT86PiOEjIT4DeP/fbS0h8KX vsNC+u6rxQlaBZqkDsvv/gUXjLOaxzcl9maOAwSKM/1ezwYlbTPnc5GgJBzDhayopu2Y b+Kw== X-Gm-Message-State: AOAM532eIv9dLjSykswWkS99yjmQmE1iNmJL4qzSWJaBNQB0OxUNEpoL O7ymiepibYdkgzm/aKO2v3iPmMA6gf/ePR4RyNtnAvpLQR3uMkUu1wfYV66CwZEdSQ7TNBry61e iPaVj8PG5H4TbV0VFe64mq1nnydyqpI5nob5zZDY= X-Received: by 2002:a2e:9b42:: with SMTP id o2mr5338854ljj.85.1644510397726; Thu, 10 Feb 2022 08:26:37 -0800 (PST) X-Received: by 2002:a2e:9b42:: with SMTP id o2mr5338822ljj.85.1644510397492; Thu, 10 Feb 2022 08:26:37 -0800 (PST) MIME-Version: 1.0 References: <20220209170358.3266629-1-atomlin@redhat.com> <20220209170358.3266629-3-atomlin@redhat.com> In-Reply-To: From: Aaron Tomlin Date: Thu, 10 Feb 2022 16:26:26 +0000 Message-ID: Subject: Re: [PATCH v5 02/13] module: Simple refactor in preparation for split To: Christophe Leroy Cc: "mcgrof@kernel.org" , "cl@linux.com" , "pmladek@suse.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "live-patching@vger.kernel.org" , "atomlin@atomlin.com" , "ghalat@redhat.com" , "allen.lkml@gmail.com" , "void@manifault.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2022-02-10 11:18 +0000, Christophe Leroy wrote: > > +#define MODULE_SECT_READ_SIZE (3 /* "0x", "\n" */ + (BITS_PER_LONG / 4)) > > This is used only in sysfs.c, why move it to internal.h ? Agreed. Since use is exclusive to kernel/module/sysfs.c it should be moved. Kind regards, -- Aaron Tomlin