Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3295217pxb; Thu, 10 Feb 2022 17:45:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzNdDl+CxY4HOS1+9t0TAhG4DFuZfthXHgkgV6/VSQZaoFgUN97XSfg1/K2yv/cVF8+pHnW X-Received: by 2002:a17:906:604d:: with SMTP id p13mr8372112ejj.639.1644543914487; Thu, 10 Feb 2022 17:45:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644543914; cv=none; d=google.com; s=arc-20160816; b=wrFNpYr88P/7hXzg3mIStbs9gku0v6yUX/7T/AzKEODtrg+OBFw4U0b9Si4/8qgwDi PQGrF4dr98Kg7ov4hgKYctmON0rvT8DO6Orq0PvBJT1awlh3EYAzJcqCHIeOBF+GY22e XXDuPDS3fJpDXF2WAQbSwhJ8IuuuCrT+COTz+cBLegYum3WwmZtC7PNxdTZQaPLre1+L kWmcx4n2OF/E1ljtFS7CfPb2L+L05o9yg9LReEvapI3CVfsfeE+V/r7PJzaWjKcz7Jo9 sAtKQ0OZf1rBOEI4P9fUcI+43b1AQQ7Cm1hbKWAhYzsDtjkZs4koBhgYfHmkB4m3zQX0 kCdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mEKCxhU+JNeT1eMVQTnlAK3ulpLxB/CwopnVgEI95lA=; b=jIa/XphxQpP9l4K9+Pw4Kh9kGo5aLtQwt119eUC2UERy+FZu4eLlphqnNW9465LYWI yORzheSB8YG2QLeSTAoVDoSZf9n0qoe+WkC8qN1ppO0Jtg8Cqmk3nLIyJ6a7/lCqDwpf eedSjSkoLjSpHIPRsFJc2VjPXtB3rTfIalqH9ybwW0Xkn63NIrCVsUY1Xq4Lsd2hdkkt NhRllYVomx6fPYiY+uNnnbboNlCGG4jkLy5EzmVzIa9tQKT1Jm8VceQMhtGnvvkETWJu Ic/TRtt7bUhvRzR9OS/onQfqWs+YHOvPUPnvjAMwrI9VXngRJanTZ08wAnZjj0J2480J t+4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0cvSbH4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x8si6504182edr.258.2022.02.10.17.44.50; Thu, 10 Feb 2022 17:45:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0cvSbH4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343540AbiBJSvJ (ORCPT + 99 others); Thu, 10 Feb 2022 13:51:09 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbiBJSvI (ORCPT ); Thu, 10 Feb 2022 13:51:08 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E122E7F; Thu, 10 Feb 2022 10:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mEKCxhU+JNeT1eMVQTnlAK3ulpLxB/CwopnVgEI95lA=; b=0cvSbH4Y/kCukzwjlS9gIBRS9q dlBTzfjS8ziXZfcR+CMHsEhjsW2GEW1VYCrlMfcE+mYjv62nsLJtP83VGg1D7qh9Q4eJYe3lNhCsJ RHk/cxEZvK1ZiJeGTg8iSaPYN7SpO7ECLYNa0Wbg9vm4YDgAjyXrhU8h2fAZGGW16QRXUatVgk/71 2rgmFNeCSDTu5WQ4CtEnayeDCr/nQbR/oL3zD+10caFRB1eVMHFmUh4OajwwJO/DQaxDFNBVoqiqB e+RMqxk4oLD2lqlu64XvAviH70qmscakTpquZlrjpT8OR/XLMFVsRK4shrjSwHq00P3BoR00beij8 E8VHEIEA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIEWw-004g2X-9h; Thu, 10 Feb 2022 18:50:58 +0000 Date: Thu, 10 Feb 2022 10:50:58 -0800 From: Luis Chamberlain To: Joe Perches Cc: Aaron Tomlin , Christophe Leroy , "cl@linux.com" , "pmladek@suse.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "live-patching@vger.kernel.org" , "atomlin@atomlin.com" , "ghalat@redhat.com" , "allen.lkml@gmail.com" , "void@manifault.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" Subject: Re: [PATCH v5 01/13] module: Move all into module/ Message-ID: References: <20220209170358.3266629-1-atomlin@redhat.com> <20220209170358.3266629-2-atomlin@redhat.com> <926e5c35d50ec5f6d7e789831be96744ca8d6423.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <926e5c35d50ec5f6d7e789831be96744ca8d6423.camel@perches.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 09:02:09AM -0800, Joe Perches wrote: > On Thu, 2022-02-10 at 14:45 +0000, Aaron Tomlin wrote: > > On Thu 2022-02-10 11:11 +0000, Christophe Leroy wrote: > > > > diff --git a/MAINTAINERS b/MAINTAINERS > [] > > > > @@ -13001,7 +13001,7 @@ L: linux-kernel@vger.kernel.org > > > > S: Maintained > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next > > > > F: include/linux/module.h > > > > -F: kernel/module.c > > > > +F: kernel/module/main.c > > > > > > Shouldn't it be the entire directory ? > > > > Indeed it should. Moving forward: kernel/module/* > > Better would be: > > F: kernel/module/ > > in case it ever gets subdirectories too. Yes, that also later allows us to add entries for things like say livepatching. Or we peg the livepatching file to the livepatching tag. Either way, one of the side goals of the split is to eventually help scale maintenance. Luis